Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/lint-commits: catch non-conventional subject
@ 2021-10-26 18:35 Chocimier
  2021-10-29 19:23 ` [PR PATCH] [Updated] " Chocimier
  2021-10-29 19:24 ` [PR PATCH] [Merged]: " Chocimier
  0 siblings, 2 replies; 3+ messages in thread
From: Chocimier @ 2021-10-26 18:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

There is a new pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org subject
https://github.com/void-linux/void-packages/pull/33768

common/lint-commits: catch non-conventional subject
None

A patch file from https://github.com/void-linux/void-packages/pull/33768.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-subject-33768.patch --]
[-- Type: text/x-diff, Size: 936 bytes --]

From e76cf4026223886162fa6f7993a29ee3253797d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Tue, 26 Oct 2021 20:32:34 +0200
Subject: [PATCH] common/lint-commits: catch non-conventional subject

---
 common/scripts/lint-commits | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/scripts/lint-commits b/common/scripts/lint-commits
index 785bf0ef1d0d..f9ebf41a1d50 100755
--- a/common/scripts/lint-commits
+++ b/common/scripts/lint-commits
@@ -38,6 +38,7 @@ do
 	(NF > 2) && (length > 80) { print C ": long line: " $0; exit 1 }
 	!subject {
 		if (length > 50) { print C ": subject is a bit long" }
+		if (!($0 ~ ":" || $0 ~ "^Take over maintainership " || $0 ~ "^Orphan ")) { print C ": subject does not follow CONTRIBUTING.md guildelines:" $0 }
 		# Below check is too noisy?
 		# if (!($0 ~ "^New package:" || $0 ~ ".*: update to")) {
 		# 	print C ": not new package/update/removal?"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Updated] common/lint-commits: catch non-conventional subject
  2021-10-26 18:35 [PR PATCH] common/lint-commits: catch non-conventional subject Chocimier
@ 2021-10-29 19:23 ` Chocimier
  2021-10-29 19:24 ` [PR PATCH] [Merged]: " Chocimier
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2021-10-29 19:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

There is an updated pull request by Chocimier against master on the void-packages repository

https://github.com/Chocimier/void-packages-org subject
https://github.com/void-linux/void-packages/pull/33768

common/lint-commits: catch non-conventional subject
None

A patch file from https://github.com/void-linux/void-packages/pull/33768.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-subject-33768.patch --]
[-- Type: text/x-diff, Size: 932 bytes --]

From 11360d0216c724040a95c0a4f9b7662e422bafb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Tue, 26 Oct 2021 20:32:34 +0200
Subject: [PATCH] common/lint-commits: catch non-conventional subject

---
 common/scripts/lint-commits | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/scripts/lint-commits b/common/scripts/lint-commits
index 785bf0ef1d0d..65f584f5f84e 100755
--- a/common/scripts/lint-commits
+++ b/common/scripts/lint-commits
@@ -38,6 +38,7 @@ do
 	(NF > 2) && (length > 80) { print C ": long line: " $0; exit 1 }
 	!subject {
 		if (length > 50) { print C ": subject is a bit long" }
+		if (!($0 ~ ":" || $0 ~ "^Take over maintainership " || $0 ~ "^Orphan ")) { print C ": subject does not follow CONTRIBUTING.md guildelines" }
 		# Below check is too noisy?
 		# if (!($0 ~ "^New package:" || $0 ~ ".*: update to")) {
 		# 	print C ": not new package/update/removal?"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: common/lint-commits: catch non-conventional subject
  2021-10-26 18:35 [PR PATCH] common/lint-commits: catch non-conventional subject Chocimier
  2021-10-29 19:23 ` [PR PATCH] [Updated] " Chocimier
@ 2021-10-29 19:24 ` Chocimier
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2021-10-29 19:24 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

There's a merged pull request on the void-packages repository

common/lint-commits: catch non-conventional subject
https://github.com/void-linux/void-packages/pull/33768

Description:
None

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-29 19:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 18:35 [PR PATCH] common/lint-commits: catch non-conventional subject Chocimier
2021-10-29 19:23 ` [PR PATCH] [Updated] " Chocimier
2021-10-29 19:24 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).