Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gping: update to 1.2.6
@ 2021-10-26 23:15 cinerea0
  2021-10-27 14:41 ` cinerea0
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: cinerea0 @ 2021-10-26 23:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

There is a new pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages gping
https://github.com/void-linux/void-packages/pull/33773

gping: update to 1.2.6
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gping-33773.patch --]
[-- Type: text/x-diff, Size: 1136 bytes --]

From 5efdf78ea93684bf6434f99a9a8cd88d6a3a244c Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Tue, 26 Oct 2021 19:14:56 -0400
Subject: [PATCH] gping: update to 1.2.6

---
 srcpkgs/gping/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gping/template b/srcpkgs/gping/template
index 18a07e70728e..c3fb77d05345 100644
--- a/srcpkgs/gping/template
+++ b/srcpkgs/gping/template
@@ -1,15 +1,17 @@
 # Template file for 'gping'
 pkgname=gping
-version=1.2.0
+version=1.2.6
 revision=1
+wrksrc="${pkgname}-${pkgname}-v${version}"
+build_wrksrc="gping"
 build_style=cargo
 short_desc="Ping, but with a graph"
 maintainer="Paper <paper@tilde.institute>"
 license="MIT"
 homepage="https://github.com/orf/gping/"
-distfiles="https://github.com/orf/gping/archive/v${version}.tar.gz"
-checksum=2379d2d5c3e301140d9c65c4dcc2b99602acf511b2798f45009af4c1101a0716
+distfiles="https://github.com/orf/gping/archive/refs/tags/gping-v${version}.tar.gz"
+checksum=e36d5bc02157708c803d1855be4b2a9daa27d077fffe86c58b12c746fdc04c8f
 
 post_install() {
-	vlicense LICENSE
+	vlicense ../LICENSE
 }

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gping: update to 1.2.6
  2021-10-26 23:15 [PR PATCH] gping: update to 1.2.6 cinerea0
@ 2021-10-27 14:41 ` cinerea0
  2021-10-28 22:26 ` paper42
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: cinerea0 @ 2021-10-27 14:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33773#issuecomment-952999344

Comment:
Upstream started naming their releases "gping-${version}" instead of just "${version}" two releases after the last time you updated the package. Since `xbps-src update-check` is specific when it comes to the URL needed to check for updates, it didn't show anything other than the update to 1.2.1. The distfile now uses upstream's new naming convention, so this problem shouldn't arise again for this package. However, I think there are potentially many more packages with this same problem since the list of available updates at https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt doesn't include the "NO VERSION found" errors that tipped me off to the exact same name change situation having happened to `watchexec`.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gping: update to 1.2.6
  2021-10-26 23:15 [PR PATCH] gping: update to 1.2.6 cinerea0
  2021-10-27 14:41 ` cinerea0
@ 2021-10-28 22:26 ` paper42
  2021-10-29  4:19 ` [PR PATCH] [Updated] " cinerea0
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-10-28 22:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33773#issuecomment-954271399

Comment:
> The distfile now uses upstream's new naming convention, so this problem shouldn't arise again for this package.

It is not, you can see the whole list of versions detected by update-check when `XBPS_UPDATE_CHECK_VERBOSE=y` is set.

Putting `pattern="gping-v\K[0-9.]+(?=.tar.gz)"` to the update file seems to help.

> However, I think there are potentially many more packages with this same problem since the list of available updates at [alpha.de.repo.voidlinux.org/void-updates/void-updates.txt](https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt) doesn't include the "NO VERSION found" errors that tipped me off to the exact same name change situation having happened to `watchexec`.

That's probably correct and we should fix them when we find them. In this case, versions were detected, but only until 1.2.1. 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] gping: update to 1.2.6
  2021-10-26 23:15 [PR PATCH] gping: update to 1.2.6 cinerea0
  2021-10-27 14:41 ` cinerea0
  2021-10-28 22:26 ` paper42
@ 2021-10-29  4:19 ` cinerea0
  2021-10-30  1:06 ` cinerea0
  2021-10-30  8:49 ` [PR PATCH] [Merged]: " paper42
  4 siblings, 0 replies; 6+ messages in thread
From: cinerea0 @ 2021-10-29  4:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is an updated pull request by cinerea0 against master on the void-packages repository

https://github.com/cinerea0/void-packages gping
https://github.com/void-linux/void-packages/pull/33773

gping: update to 1.2.6
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33773.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gping-33773.patch --]
[-- Type: text/x-diff, Size: 1414 bytes --]

From 1181a675b681a193d00e55fcc3f7b2a07d1b7811 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Fri, 29 Oct 2021 00:18:25 -0400
Subject: [PATCH] gping: update to 1.2.6

---
 srcpkgs/gping/template | 10 ++++++----
 srcpkgs/gping/update   |  1 +
 2 files changed, 7 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/gping/update

diff --git a/srcpkgs/gping/template b/srcpkgs/gping/template
index 18a07e70728e..c3fb77d05345 100644
--- a/srcpkgs/gping/template
+++ b/srcpkgs/gping/template
@@ -1,15 +1,17 @@
 # Template file for 'gping'
 pkgname=gping
-version=1.2.0
+version=1.2.6
 revision=1
+wrksrc="${pkgname}-${pkgname}-v${version}"
+build_wrksrc="gping"
 build_style=cargo
 short_desc="Ping, but with a graph"
 maintainer="Paper <paper@tilde.institute>"
 license="MIT"
 homepage="https://github.com/orf/gping/"
-distfiles="https://github.com/orf/gping/archive/v${version}.tar.gz"
-checksum=2379d2d5c3e301140d9c65c4dcc2b99602acf511b2798f45009af4c1101a0716
+distfiles="https://github.com/orf/gping/archive/refs/tags/gping-v${version}.tar.gz"
+checksum=e36d5bc02157708c803d1855be4b2a9daa27d077fffe86c58b12c746fdc04c8f
 
 post_install() {
-	vlicense LICENSE
+	vlicense ../LICENSE
 }
diff --git a/srcpkgs/gping/update b/srcpkgs/gping/update
new file mode 100644
index 000000000000..08d9ce62349b
--- /dev/null
+++ b/srcpkgs/gping/update
@@ -0,0 +1 @@
+pattern="gping-v\K[0-9.]+(?=.tar.gz)"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: gping: update to 1.2.6
  2021-10-26 23:15 [PR PATCH] gping: update to 1.2.6 cinerea0
                   ` (2 preceding siblings ...)
  2021-10-29  4:19 ` [PR PATCH] [Updated] " cinerea0
@ 2021-10-30  1:06 ` cinerea0
  2021-10-30  8:49 ` [PR PATCH] [Merged]: " paper42
  4 siblings, 0 replies; 6+ messages in thread
From: cinerea0 @ 2021-10-30  1:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/33773#issuecomment-955119156

Comment:
@paper42 The update file has been added!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Merged]: gping: update to 1.2.6
  2021-10-26 23:15 [PR PATCH] gping: update to 1.2.6 cinerea0
                   ` (3 preceding siblings ...)
  2021-10-30  1:06 ` cinerea0
@ 2021-10-30  8:49 ` paper42
  4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-10-30  8:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

There's a merged pull request on the void-packages repository

gping: update to 1.2.6
https://github.com/void-linux/void-packages/pull/33773

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [ ] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [x] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-10-30  8:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 23:15 [PR PATCH] gping: update to 1.2.6 cinerea0
2021-10-27 14:41 ` cinerea0
2021-10-28 22:26 ` paper42
2021-10-29  4:19 ` [PR PATCH] [Updated] " cinerea0
2021-10-30  1:06 ` cinerea0
2021-10-30  8:49 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).