[PR PATCH] nyxt: update to 2.2.2

[PR PATCH] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 1589 bytes --]

There is a new pull request by WilliamBehrens against master on the void-packages repository

https://github.com/WilliamBehrens/void-packages master
https://github.com/void-linux/void-packages/pull/33871

nyxt: update to 2.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/33871.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-33871.patch --]
[-- Type: text/x-diff, Size: 1896 bytes --]

From 47de7e6d90f5ee72731562ddba8e40391362340d Mon Sep 17 00:00:00 2001
From: williambehrens <williambehrens@tutanota.com>
Date: Tue, 2 Nov 2021 22:20:22 +0000
Subject: [PATCH] nyxt: update to 2.2.2

---
 srcpkgs/nyxt/template | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/nyxt/template b/srcpkgs/nyxt/template
index 474015478310..9dd167063d4f 100644
--- a/srcpkgs/nyxt/template
+++ b/srcpkgs/nyxt/template
@@ -1,8 +1,8 @@
 # Template file for 'nyxt'
 pkgname=nyxt
-version=2.0.0
-revision=2
-wrksrc=nyxt
+version=2.2.2
+revision=1
+wrksrc=.
 build_style=gnu-makefile
 make_build_target=all
 hostmakedepends="sbcl git"
@@ -12,8 +12,8 @@ short_desc="Keyboard-oriented, extensible web-browser"
 maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://nyxt.atlas.engineer/"
-distfiles="https://nyxt.atlas.engineer/static/release/nyxt-linux-${version}.tar.gz"
-checksum=71154bc6ef88f176f3f7783e1c0ecc191b6dcdd996e1c67f2bbc417b651e0355
+distfiles="https://github.com/atlas-engineer/nyxt/releases/download/${version}/nyxt-${version}-source-with-submodules.tar.xz"
+checksum=22cc8489e128b8695fbdf6796509c891bde630a73fd530c7582580adb3903773
 # Disable check because ASDF/USER::PROVE is not installed
 make_check=no
 nostrip=yes
@@ -21,13 +21,13 @@ nopie=yes
 nocross="Cross-compilation fails due to package iolib/syscalls setting incorrect compiler flags"
 
 do_install() {
-	make PREFIX=/usr DESTDIR=${DESTDIR} install
-	vlicense licenses/ASSET-LICENSE
-	vlicense licenses/SOURCE-LICENSE
+    make PREFIX=/usr DESTDIR=${DESTDIR} install
+    vlicense licenses/ASSET-LICENSE
+    vlicense licenses/SOURCE-LICENSE
 }
 
 next_package() {
-	depends="nyxt"
-	short_desc+=" (transitional dummy package)"
-	build_style=meta
+    depends="nyxt"
+    short_desc+=" (transitional dummy package)"
+    build_style=meta
 }

Re: nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by WilliamBehrens on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#issuecomment-958277423

Comment:
I opened a new pr because I couldn't figure out how to fix the last one

Re: [PR REVIEW] nyxt: update to 2.2.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r741504768

Comment:
We prefer tabs, I assume your editor did this automatically, could you fix it? When commiting the change, please use git commit --amend instead of git commit to have just one commit in this PR.

Re: [PR PATCH] [Updated] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

There is an updated pull request by WilliamBehrens against master on the void-packages repository

https://github.com/WilliamBehrens/void-packages master
https://github.com/void-linux/void-packages/pull/33871

nyxt: update to 2.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/33871.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-33871.patch --]
[-- Type: text/x-diff, Size: 1896 bytes --]

From e112c5a7c41797456a22a7845b5d46f68fbc6f23 Mon Sep 17 00:00:00 2001
From: williambehrens <williambehrens@tutanota.com>
Date: Tue, 2 Nov 2021 22:20:22 +0000
Subject: [PATCH] nyxt: update to 2.2.2

---
 srcpkgs/nyxt/template | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/nyxt/template b/srcpkgs/nyxt/template
index 474015478310..9dd167063d4f 100644
--- a/srcpkgs/nyxt/template
+++ b/srcpkgs/nyxt/template
@@ -1,8 +1,8 @@
 # Template file for 'nyxt'
 pkgname=nyxt
-version=2.0.0
-revision=2
-wrksrc=nyxt
+version=2.2.2
+revision=1
+wrksrc=.
 build_style=gnu-makefile
 make_build_target=all
 hostmakedepends="sbcl git"
@@ -12,8 +12,8 @@ short_desc="Keyboard-oriented, extensible web-browser"
 maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://nyxt.atlas.engineer/"
-distfiles="https://nyxt.atlas.engineer/static/release/nyxt-linux-${version}.tar.gz"
-checksum=71154bc6ef88f176f3f7783e1c0ecc191b6dcdd996e1c67f2bbc417b651e0355
+distfiles="https://github.com/atlas-engineer/nyxt/releases/download/${version}/nyxt-${version}-source-with-submodules.tar.xz"
+checksum=22cc8489e128b8695fbdf6796509c891bde630a73fd530c7582580adb3903773
 # Disable check because ASDF/USER::PROVE is not installed
 make_check=no
 nostrip=yes
@@ -21,13 +21,13 @@ nopie=yes
 nocross="Cross-compilation fails due to package iolib/syscalls setting incorrect compiler flags"
 
 do_install() {
-	make PREFIX=/usr DESTDIR=${DESTDIR} install
-	vlicense licenses/ASSET-LICENSE
-	vlicense licenses/SOURCE-LICENSE
+    make PREFIX=/usr DESTDIR=${DESTDIR} install
+    vlicense licenses/ASSET-LICENSE
+    vlicense licenses/SOURCE-LICENSE
 }
 
 next_package() {
-	depends="nyxt"
-	short_desc+=" (transitional dummy package)"
-	build_style=meta
+    depends="nyxt"
+    short_desc+=" (transitional dummy package)"
+    build_style=meta
 }

Re: [PR REVIEW] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by WilliamBehrens on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r741506646

Comment:
Should be fixed now

Re: [PR REVIEW] nyxt: update to 2.2.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r741510886

Comment:
it isn't, did you `git add` the files before `git commit --amend`?

Re: [PR REVIEW] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New review comment by WilliamBehrens on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r741613125

Comment:
@paper42 pretty sure i did, hmm, when you say tabs to you mean the actual tab character or will 4 spaces do? Because my editor ive been using inserts 4 spaces on tab

Re: [PR REVIEW] nyxt: update to 2.2.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r741721860

Comment:
We want literal tabs, you can use `xlint srcpkgs/nyxt/template` to check if the style is correct on your own computer.

Re: [PR PATCH] [Updated] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

There is an updated pull request by WilliamBehrens against master on the void-packages repository

https://github.com/WilliamBehrens/void-packages master
https://github.com/void-linux/void-packages/pull/33871

nyxt: update to 2.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/33871.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-33871.patch --]
[-- Type: text/x-diff, Size: 1896 bytes --]

From 5301633b6a113a8015d9dd2d77dffcbabbd1778f Mon Sep 17 00:00:00 2001
From: williambehrens <williambehrens@tutanota.com>
Date: Tue, 2 Nov 2021 22:20:22 +0000
Subject: [PATCH] nyxt: update to 2.2.2

---
 srcpkgs/nyxt/template | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/nyxt/template b/srcpkgs/nyxt/template
index 474015478310..9dd167063d4f 100644
--- a/srcpkgs/nyxt/template
+++ b/srcpkgs/nyxt/template
@@ -1,8 +1,8 @@
 # Template file for 'nyxt'
 pkgname=nyxt
-version=2.0.0
-revision=2
-wrksrc=nyxt
+version=2.2.2
+revision=1
+wrksrc=.
 build_style=gnu-makefile
 make_build_target=all
 hostmakedepends="sbcl git"
@@ -12,8 +12,8 @@ short_desc="Keyboard-oriented, extensible web-browser"
 maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://nyxt.atlas.engineer/"
-distfiles="https://nyxt.atlas.engineer/static/release/nyxt-linux-${version}.tar.gz"
-checksum=71154bc6ef88f176f3f7783e1c0ecc191b6dcdd996e1c67f2bbc417b651e0355
+distfiles="https://github.com/atlas-engineer/nyxt/releases/download/${version}/nyxt-${version}-source-with-submodules.tar.xz"
+checksum=22cc8489e128b8695fbdf6796509c891bde630a73fd530c7582580adb3903773
 # Disable check because ASDF/USER::PROVE is not installed
 make_check=no
 nostrip=yes
@@ -21,13 +21,13 @@ nopie=yes
 nocross="Cross-compilation fails due to package iolib/syscalls setting incorrect compiler flags"
 
 do_install() {
-	make PREFIX=/usr DESTDIR=${DESTDIR} install
-	vlicense licenses/ASSET-LICENSE
-	vlicense licenses/SOURCE-LICENSE
+    make PREFIX=/usr DESTDIR=${DESTDIR} install
+    vlicense licenses/ASSET-LICENSE
+    vlicense licenses/SOURCE-LICENSE
 }
 
 next_package() {
-	depends="nyxt"
-	short_desc+=" (transitional dummy package)"
-	build_style=meta
+    depends="nyxt"
+    short_desc+=" (transitional dummy package)"
+    build_style=meta
 }

Re: [PR PATCH] [Updated] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 1594 bytes --]

There is an updated pull request by WilliamBehrens against master on the void-packages repository

https://github.com/WilliamBehrens/void-packages master
https://github.com/void-linux/void-packages/pull/33871

nyxt: update to 2.2.2
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl



A patch file from https://github.com/void-linux/void-packages/pull/33871.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-33871.patch --]
[-- Type: text/x-diff, Size: 1487 bytes --]

From 49b66adb8987bf96563fa8123c9a3004abfed836 Mon Sep 17 00:00:00 2001
From: williambehrens <williambehrens@tutanota.com>
Date: Tue, 2 Nov 2021 22:20:22 +0000
Subject: [PATCH] nyxt: update to 2.2.2

---
 srcpkgs/nyxt/template | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/nyxt/template b/srcpkgs/nyxt/template
index 474015478310..662fb27de3bb 100644
--- a/srcpkgs/nyxt/template
+++ b/srcpkgs/nyxt/template
@@ -1,8 +1,8 @@
 # Template file for 'nyxt'
 pkgname=nyxt
-version=2.0.0
-revision=2
-wrksrc=nyxt
+version=2.2.2
+revision=1
+wrksrc=.
 build_style=gnu-makefile
 make_build_target=all
 hostmakedepends="sbcl git"
@@ -12,8 +12,8 @@ short_desc="Keyboard-oriented, extensible web-browser"
 maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>"
 license="BSD-3-Clause"
 homepage="https://nyxt.atlas.engineer/"
-distfiles="https://nyxt.atlas.engineer/static/release/nyxt-linux-${version}.tar.gz"
-checksum=71154bc6ef88f176f3f7783e1c0ecc191b6dcdd996e1c67f2bbc417b651e0355
+distfiles="https://github.com/atlas-engineer/nyxt/releases/download/${version}/nyxt-${version}-source-with-submodules.tar.xz"
+checksum=22cc8489e128b8695fbdf6796509c891bde630a73fd530c7582580adb3903773
 # Disable check because ASDF/USER::PROVE is not installed
 make_check=no
 nostrip=yes
@@ -25,7 +25,6 @@ do_install() {
 	vlicense licenses/ASSET-LICENSE
 	vlicense licenses/SOURCE-LICENSE
 }
-
 next_package() {
 	depends="nyxt"
 	short_desc+=" (transitional dummy package)"

Re: [PR REVIEW] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by WilliamBehrens on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r741905844

Comment:
@paper42 ok now it's fixed

Re: [PR REVIEW] nyxt: update to 2.2.2

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r742124959

Comment:
    => nyxt-2.2.2_1: cleaning build directory...
    rm: refusing to remove '.' or '..' directory: skipping '/builddir/.'

Set create_wrksrc instead.

Re: [PR REVIEW] nyxt: update to 2.2.2

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r742125012

Comment:
Leave that line in.

Re: [PR REVIEW] nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New review comment by WilliamBehrens on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#discussion_r742129072

Comment:
So instead of having `wrksrc=.` or `wrksrc=nyxt` only have `create_wrksrc=nyxt`?

Re: nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by WilliamBehrens on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#issuecomment-961500867

Comment:
I'm going to close this pr for the time being as a bug was found in nyxt 2.2.2 that makes it very unstable and crash constantly. once 2.2.3 comes out with the patch for the issue I'll submit a new pr with the suggested changes.

Re: [PR PATCH] [Closed]: nyxt: update to 2.2.2

[WilliamBehrens]

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

There's a closed pull request on the void-packages repository

nyxt: update to 2.2.2
https://github.com/void-linux/void-packages/pull/33871

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl

Re: nyxt: update to 2.2.2

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#issuecomment-961534243

Comment:
You can leave it open so we have a reference for why the new version hasn't been merged yet.

Re: nyxt: update to 2.2.2

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33871#issuecomment-974661264

Comment:
Updated to 2.2.3.

Re: [PR PATCH] [Closed]: nyxt: update to 2.2.2

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1425 bytes --]

There's a closed pull request on the void-packages repository

nyxt: update to 2.2.2
https://github.com/void-linux/void-packages/pull/33871

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [ ] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl