[PR PATCH] New package: helden-software-5.5.3

[PR PATCH] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages helden-software-5.5.3_1
https://github.com/void-linux/void-packages/pull/34073

New package: helden-software-5.5.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34073.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-helden-software-5.5.3_1-34073.patch --]
[-- Type: text/x-diff, Size: 5960 bytes --]

From e32a8e2ac7c2983de61f840bca0544944294f7a3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 25 Sep 2021 21:35:22 +0200
Subject: [PATCH] New package: helden-software-5.5.3

---
 .../0001-remove-hsdebianmode-arg.patch        | 26 +++++++++++++
 .../patches/0002-fix-file-locations.patch     | 33 ++++++++++++++++
 .../patches/0003-translate-comment.patch      | 20 ++++++++++
 srcpkgs/helden-software/template              | 38 +++++++++++++++++++
 4 files changed, 117 insertions(+)
 create mode 100644 srcpkgs/helden-software/patches/0001-remove-hsdebianmode-arg.patch
 create mode 100644 srcpkgs/helden-software/patches/0002-fix-file-locations.patch
 create mode 100644 srcpkgs/helden-software/patches/0003-translate-comment.patch
 create mode 100644 srcpkgs/helden-software/template

diff --git a/srcpkgs/helden-software/patches/0001-remove-hsdebianmode-arg.patch b/srcpkgs/helden-software/patches/0001-remove-hsdebianmode-arg.patch
new file mode 100644
index 000000000000..d70db41283a1
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0001-remove-hsdebianmode-arg.patch
@@ -0,0 +1,26 @@
+commit 0b5221d64f319df11a11b255a352105196a9e755
+Author: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
+Date:   Sat Sep 25 10:29:43 2021 +0200
+
+    remove '-hsDebianMode' arg
+
+diff --git a/etc/default/helden-software b/etc/default/helden-software
+index b04bc7d..29fb662 100644
+--- a/etc/default/helden-software
++++ b/etc/default/helden-software
+@@ -1,2 +1,2 @@
+ JavaArgs="-Xms40m -Xmx256m"
+-HeldenArgs=-hsDebianMode
++HeldenArgs=""
+diff --git a/usr/games/helden-software b/usr/games/helden-software
+index 49d866b..9105ab5 100755
+--- a/usr/games/helden-software
++++ b/usr/games/helden-software
+@@ -1,6 +1,6 @@
+ #!/bin/sh
+ JavaArgs="-Xms40m -Xmx256m"
+-HeldenArgs=-hsDebianMode
++HeldenArgs=""
+ if [ -f /etc/default/helden-software ] ; then
+     . /etc/default/helden-software
+ fi
diff --git a/srcpkgs/helden-software/patches/0002-fix-file-locations.patch b/srcpkgs/helden-software/patches/0002-fix-file-locations.patch
new file mode 100644
index 000000000000..e0f1f9aa71be
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0002-fix-file-locations.patch
@@ -0,0 +1,33 @@
+commit 53d52967b979a304feb47ba1c0bd880e268964b9
+Author: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
+Date:   Sat Sep 25 10:32:19 2021 +0200
+
+    fix file locations
+
+diff --git a/usr/games/helden-software b/usr/games/helden-software
+index 9105ab5..e3622cd 100755
+--- a/usr/games/helden-software
++++ b/usr/games/helden-software
+@@ -2,6 +2,6 @@
+ JavaArgs="-Xms40m -Xmx256m"
+ HeldenArgs=""
+ if [ -f /etc/default/helden-software ] ; then
+-    . /etc/default/helden-software
++    source /etc/default/helden-software
+ fi
+-exec /usr/bin/java $JavaArgs -jar /usr/lib/heldensoftware/helden5.jar $HeldenArgs $@
+\ No newline at end of file
++exec /usr/bin/java $JavaArgs -jar /usr/lib/helden-software/helden5.jar $HeldenArgs $@
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 2c5ed8b..4319144 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -4,6 +4,6 @@ Type=Application
+ Terminal=false
+ Name=Helden-Software
+ Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
+-Exec=/usr/games/helden-software
++Exec=/usr/bin/helden-software
+ Icon=helden-software
+-Categories=Game;Java
++Categories=Game
diff --git a/srcpkgs/helden-software/patches/0003-translate-comment.patch b/srcpkgs/helden-software/patches/0003-translate-comment.patch
new file mode 100644
index 000000000000..81c0ecdacaf8
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0003-translate-comment.patch
@@ -0,0 +1,20 @@
+commit 3d65573c135929a389a5c5bcfacacebb6f69754c
+Author: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
+Date:   Sat Sep 25 10:33:17 2021 +0200
+
+    translate comment
+
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 4319144..09cd90d 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -3,7 +3,8 @@ Version=1.0
+ Type=Application
+ Terminal=false
+ Name=Helden-Software
+-Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
++Comment=Character generator for the Pen&Paper RPG DSA
++Comment[de]=Ein Generator für 'Das schwarze Auge' (DSA)
+ Exec=/usr/bin/helden-software
+ Icon=helden-software
+ Categories=Game
diff --git a/srcpkgs/helden-software/template b/srcpkgs/helden-software/template
new file mode 100644
index 000000000000..9e43e87b915f
--- /dev/null
+++ b/srcpkgs/helden-software/template
@@ -0,0 +1,38 @@
+# Template file for 'helden-software'
+pkgname=helden-software
+version=5.5.3
+revision=1
+_ver="${version}-0_all"
+_filename="${pkgname}_${_ver}.deb"
+create_wrksrc=yes
+build_style=fetch
+depends="openjdk-jre"
+short_desc="Character generator for the Pen&Paper RPG DSA"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="custom:Proprietary"
+homepage="https://www.helden-software.de/"
+distfiles="https://online.helden-software.de/rep/pool/main/h/helden-software/${_filename}"
+checksum=4bc08118ae1e78942bea543338de1ada17c21ebdb4b7f9e108910df0ba815a04
+repository="nonfree"
+restricted="yes"
+
+post_extract() {
+	ar x "${_filename}"
+	bsdtar -xf data.tar.gz
+}
+
+do_install() {
+	vmkdir usr/lib/helden-software
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons
+	vmkdir etc/default
+
+	vlicense usr/share/doc/helden-software/copyright
+
+	vbin usr/games/helden-software
+
+	vcopy usr/share/icons/* usr/share/icons
+	vcopy usr/lib/heldensoftware/helden5.jar usr/lib/helden-software/helden5.jar
+	vcopy etc/default/helden-software etc/default/helden-software
+	vcopy usr/share/applications/HeldenSoftware.desktop usr/share/applications/HeldenSoftware.desktop
+}

Re: [PR REVIEW] New package: helden-software-5.5.3

[abenson]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#discussion_r748906443

Comment:
Why this change?

Re: [PR REVIEW] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#discussion_r748914435

Comment:
Good question, I don't remember :D

I should probably drop that change there

Re: [PR PATCH] [Updated] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages helden-software-5.5.3_1
https://github.com/void-linux/void-packages/pull/34073

New package: helden-software-5.5.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34073.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-helden-software-5.5.3_1-34073.patch --]
[-- Type: text/x-diff, Size: 6663 bytes --]

From 950372804f1c91baf3255ad4ceef803ccc301d1a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 25 Sep 2021 21:35:22 +0200
Subject: [PATCH] New package: helden-software-5.5.3

---
 .../0001-remove-hsDebianMode-arg.patch        | 34 +++++++++++++++
 .../patches/0002-fix-file-locations.patch     | 42 +++++++++++++++++++
 .../patches/0003-translate-comment.patch      | 27 ++++++++++++
 srcpkgs/helden-software/template              | 38 +++++++++++++++++
 4 files changed, 141 insertions(+)
 create mode 100644 srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch
 create mode 100644 srcpkgs/helden-software/patches/0002-fix-file-locations.patch
 create mode 100644 srcpkgs/helden-software/patches/0003-translate-comment.patch
 create mode 100644 srcpkgs/helden-software/template

diff --git a/srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch b/srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch
new file mode 100644
index 000000000000..68097e83fea4
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch
@@ -0,0 +1,34 @@
+From 0b5221d64f319df11a11b255a352105196a9e755 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:29:43 +0200
+Subject: [PATCH 1/3] remove '-hsDebianMode' arg
+
+---
+ etc/default/helden-software | 2 +-
+ usr/games/helden-software   | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/etc/default/helden-software b/etc/default/helden-software
+index b04bc7d..29fb662 100644
+--- a/etc/default/helden-software
++++ b/etc/default/helden-software
+@@ -1,2 +1,2 @@
+ JavaArgs="-Xms40m -Xmx256m"
+-HeldenArgs=-hsDebianMode
++HeldenArgs=""
+diff --git a/usr/games/helden-software b/usr/games/helden-software
+index 49d866b..9105ab5 100755
+--- a/usr/games/helden-software
++++ b/usr/games/helden-software
+@@ -1,6 +1,6 @@
+ #!/bin/sh
+ JavaArgs="-Xms40m -Xmx256m"
+-HeldenArgs=-hsDebianMode
++HeldenArgs=""
+ if [ -f /etc/default/helden-software ] ; then
+     . /etc/default/helden-software
+ fi
+-- 
+2.33.1
+
diff --git a/srcpkgs/helden-software/patches/0002-fix-file-locations.patch b/srcpkgs/helden-software/patches/0002-fix-file-locations.patch
new file mode 100644
index 000000000000..2007ad5a50e6
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0002-fix-file-locations.patch
@@ -0,0 +1,42 @@
+From b6418943cedbce5e6d7bd0376d031d047a161a0c Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:32:19 +0200
+Subject: [PATCH 2/3] fix file locations
+
+---
+ usr/{games => bin}/helden-software            | 2 +-
+ usr/share/applications/HeldenSoftware.desktop | 4 ++--
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+ rename usr/{games => bin}/helden-software (61%)
+
+diff --git a/usr/games/helden-software b/usr/bin/helden-software
+similarity index 61%
+rename from usr/games/helden-software
+rename to usr/bin/helden-software
+index 9105ab5..19b3329 100755
+--- a/usr/games/helden-software
++++ b/usr/bin/helden-software
+@@ -4,4 +4,4 @@ HeldenArgs=""
+ if [ -f /etc/default/helden-software ] ; then
+     . /etc/default/helden-software
+ fi
+-exec /usr/bin/java $JavaArgs -jar /usr/lib/heldensoftware/helden5.jar $HeldenArgs $@
+\ No newline at end of file
++exec /usr/bin/java $JavaArgs -jar /usr/lib/helden-software/helden5.jar $HeldenArgs $@
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 2c5ed8b..4319144 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -4,6 +4,6 @@ Type=Application
+ Terminal=false
+ Name=Helden-Software
+ Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
+-Exec=/usr/games/helden-software
++Exec=/usr/bin/helden-software
+ Icon=helden-software
+-Categories=Game;Java
++Categories=Game
+-- 
+2.33.1
+
diff --git a/srcpkgs/helden-software/patches/0003-translate-comment.patch b/srcpkgs/helden-software/patches/0003-translate-comment.patch
new file mode 100644
index 000000000000..25bd5bc05ed6
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0003-translate-comment.patch
@@ -0,0 +1,27 @@
+From 0fa64e5fa6757ce8d74ae298287bf08ca0f3e50d Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:33:17 +0200
+Subject: [PATCH 3/3] translate comment
+
+---
+ usr/share/applications/HeldenSoftware.desktop | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 4319144..09cd90d 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -3,7 +3,8 @@ Version=1.0
+ Type=Application
+ Terminal=false
+ Name=Helden-Software
+-Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
++Comment=Character generator for the Pen&Paper RPG DSA
++Comment[de]=Ein Generator für 'Das schwarze Auge' (DSA)
+ Exec=/usr/bin/helden-software
+ Icon=helden-software
+ Categories=Game
+-- 
+2.33.1
+
diff --git a/srcpkgs/helden-software/template b/srcpkgs/helden-software/template
new file mode 100644
index 000000000000..9e43e87b915f
--- /dev/null
+++ b/srcpkgs/helden-software/template
@@ -0,0 +1,38 @@
+# Template file for 'helden-software'
+pkgname=helden-software
+version=5.5.3
+revision=1
+_ver="${version}-0_all"
+_filename="${pkgname}_${_ver}.deb"
+create_wrksrc=yes
+build_style=fetch
+depends="openjdk-jre"
+short_desc="Character generator for the Pen&Paper RPG DSA"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="custom:Proprietary"
+homepage="https://www.helden-software.de/"
+distfiles="https://online.helden-software.de/rep/pool/main/h/helden-software/${_filename}"
+checksum=4bc08118ae1e78942bea543338de1ada17c21ebdb4b7f9e108910df0ba815a04
+repository="nonfree"
+restricted="yes"
+
+post_extract() {
+	ar x "${_filename}"
+	bsdtar -xf data.tar.gz
+}
+
+do_install() {
+	vmkdir usr/lib/helden-software
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons
+	vmkdir etc/default
+
+	vlicense usr/share/doc/helden-software/copyright
+
+	vbin usr/games/helden-software
+
+	vcopy usr/share/icons/* usr/share/icons
+	vcopy usr/lib/heldensoftware/helden5.jar usr/lib/helden-software/helden5.jar
+	vcopy etc/default/helden-software etc/default/helden-software
+	vcopy usr/share/applications/HeldenSoftware.desktop usr/share/applications/HeldenSoftware.desktop
+}

Re: [PR REVIEW] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#discussion_r749349186

Comment:
Resolved, I've removed that part now.

Re: [PR PATCH] [Updated] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages helden-software-5.5.3_1
https://github.com/void-linux/void-packages/pull/34073

New package: helden-software-5.5.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34073.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-helden-software-5.5.3_1-34073.patch --]
[-- Type: text/x-diff, Size: 6661 bytes --]

From c07e057b63bab9c65642e69c4b3658cc37cb2b43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 25 Sep 2021 21:35:22 +0200
Subject: [PATCH] New package: helden-software-5.5.3

---
 .../0001-remove-hsDebianMode-arg.patch        | 34 +++++++++++++++
 .../patches/0002-fix-file-locations.patch     | 42 +++++++++++++++++++
 .../patches/0003-translate-comment.patch      | 27 ++++++++++++
 srcpkgs/helden-software/template              | 38 +++++++++++++++++
 4 files changed, 141 insertions(+)
 create mode 100644 srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch
 create mode 100644 srcpkgs/helden-software/patches/0002-fix-file-locations.patch
 create mode 100644 srcpkgs/helden-software/patches/0003-translate-comment.patch
 create mode 100644 srcpkgs/helden-software/template

diff --git a/srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch b/srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch
new file mode 100644
index 000000000000..68097e83fea4
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0001-remove-hsDebianMode-arg.patch
@@ -0,0 +1,34 @@
+From 0b5221d64f319df11a11b255a352105196a9e755 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:29:43 +0200
+Subject: [PATCH 1/3] remove '-hsDebianMode' arg
+
+---
+ etc/default/helden-software | 2 +-
+ usr/games/helden-software   | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/etc/default/helden-software b/etc/default/helden-software
+index b04bc7d..29fb662 100644
+--- a/etc/default/helden-software
++++ b/etc/default/helden-software
+@@ -1,2 +1,2 @@
+ JavaArgs="-Xms40m -Xmx256m"
+-HeldenArgs=-hsDebianMode
++HeldenArgs=""
+diff --git a/usr/games/helden-software b/usr/games/helden-software
+index 49d866b..9105ab5 100755
+--- a/usr/games/helden-software
++++ b/usr/games/helden-software
+@@ -1,6 +1,6 @@
+ #!/bin/sh
+ JavaArgs="-Xms40m -Xmx256m"
+-HeldenArgs=-hsDebianMode
++HeldenArgs=""
+ if [ -f /etc/default/helden-software ] ; then
+     . /etc/default/helden-software
+ fi
+-- 
+2.33.1
+
diff --git a/srcpkgs/helden-software/patches/0002-fix-file-locations.patch b/srcpkgs/helden-software/patches/0002-fix-file-locations.patch
new file mode 100644
index 000000000000..2007ad5a50e6
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0002-fix-file-locations.patch
@@ -0,0 +1,42 @@
+From b6418943cedbce5e6d7bd0376d031d047a161a0c Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:32:19 +0200
+Subject: [PATCH 2/3] fix file locations
+
+---
+ usr/{games => bin}/helden-software            | 2 +-
+ usr/share/applications/HeldenSoftware.desktop | 4 ++--
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+ rename usr/{games => bin}/helden-software (61%)
+
+diff --git a/usr/games/helden-software b/usr/bin/helden-software
+similarity index 61%
+rename from usr/games/helden-software
+rename to usr/bin/helden-software
+index 9105ab5..19b3329 100755
+--- a/usr/games/helden-software
++++ b/usr/bin/helden-software
+@@ -4,4 +4,4 @@ HeldenArgs=""
+ if [ -f /etc/default/helden-software ] ; then
+     . /etc/default/helden-software
+ fi
+-exec /usr/bin/java $JavaArgs -jar /usr/lib/heldensoftware/helden5.jar $HeldenArgs $@
+\ No newline at end of file
++exec /usr/bin/java $JavaArgs -jar /usr/lib/helden-software/helden5.jar $HeldenArgs $@
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 2c5ed8b..4319144 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -4,6 +4,6 @@ Type=Application
+ Terminal=false
+ Name=Helden-Software
+ Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
+-Exec=/usr/games/helden-software
++Exec=/usr/bin/helden-software
+ Icon=helden-software
+-Categories=Game;Java
++Categories=Game
+-- 
+2.33.1
+
diff --git a/srcpkgs/helden-software/patches/0003-translate-comment.patch b/srcpkgs/helden-software/patches/0003-translate-comment.patch
new file mode 100644
index 000000000000..25bd5bc05ed6
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0003-translate-comment.patch
@@ -0,0 +1,27 @@
+From 0fa64e5fa6757ce8d74ae298287bf08ca0f3e50d Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:33:17 +0200
+Subject: [PATCH 3/3] translate comment
+
+---
+ usr/share/applications/HeldenSoftware.desktop | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 4319144..09cd90d 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -3,7 +3,8 @@ Version=1.0
+ Type=Application
+ Terminal=false
+ Name=Helden-Software
+-Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
++Comment=Character generator for the Pen&Paper RPG DSA
++Comment[de]=Ein Generator für 'Das schwarze Auge' (DSA)
+ Exec=/usr/bin/helden-software
+ Icon=helden-software
+ Categories=Game
+-- 
+2.33.1
+
diff --git a/srcpkgs/helden-software/template b/srcpkgs/helden-software/template
new file mode 100644
index 000000000000..77850de45887
--- /dev/null
+++ b/srcpkgs/helden-software/template
@@ -0,0 +1,38 @@
+# Template file for 'helden-software'
+pkgname=helden-software
+version=5.5.3
+revision=1
+_ver="${version}-0_all"
+_filename="${pkgname}_${_ver}.deb"
+create_wrksrc=yes
+build_style=fetch
+depends="openjdk-jre"
+short_desc="Character generator for the Pen&Paper RPG DSA"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="custom:Proprietary"
+homepage="https://www.helden-software.de/"
+distfiles="https://online.helden-software.de/rep/pool/main/h/helden-software/${_filename}"
+checksum=4bc08118ae1e78942bea543338de1ada17c21ebdb4b7f9e108910df0ba815a04
+repository="nonfree"
+restricted="yes"
+
+post_extract() {
+	ar x "${_filename}"
+	bsdtar -xf data.tar.gz
+}
+
+do_install() {
+	vmkdir usr/lib/helden-software
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons
+	vmkdir etc/default
+
+	vlicense usr/share/doc/helden-software/copyright
+
+	vbin usr/bin/helden-software
+
+	vcopy usr/share/icons/* usr/share/icons
+	vcopy usr/lib/heldensoftware/helden5.jar usr/lib/helden-software/helden5.jar
+	vcopy etc/default/helden-software etc/default/helden-software
+	vcopy usr/share/applications/HeldenSoftware.desktop usr/share/applications/HeldenSoftware.desktop
+}

Re: New package: helden-software-5.5.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#issuecomment-1153048599

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#issuecomment-1153103565

Comment:
No, not stale, just needs a review and a merge.

Re: [PR REVIEW] New package: helden-software-5.5.3

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#discussion_r895143150

Comment:
Is this actually what you want in a system-wide installation. It looks to me, that this has two modes, "Debian" for a system installation and "local" if it can write next to its jar. Since currently launching it will give this warning:
![image](https://user-images.githubusercontent.com/7373356/173227027-523cefcc-ad2b-414f-88f8-af57efb13c29.png)

Re: [PR REVIEW] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#discussion_r895649464

Comment:
So that's what the Debian mode does, good to know. I couldn't find documentation for that parameter, so I turned it off. 

```text
void-packages on  helden-software-5.5.3_1 [$?⇕] took 13s 
❯ java -jar ~/Downloads/helden-deb/usr/lib/heldensoftware/helden5.jar --help
Der Parameter --help ist unbekannt!
Mit "/?" koennen alle moeglichen Parameter angezeigt werden.
Jun 13, 2022 2:13:05 PM helden.gui.ooOO.i:-1 o00000
WARNING: Ladezeit: 0.277081554

void-packages on  helden-software-5.5.3_1 [$?⇕] 
❯ java -jar ~/Downloads/helden-deb/usr/lib/heldensoftware/helden5.jar '/?'
---Parameterliste---
"-hsLocal"  setzt alle Pfade relative zum Jarfile, dieser Modus ist zB für USB-Sticks gedacht
"-hsLocalOff" schaltet den Localmodus wieder aus
"-ep" Durch diesen Parameter wird die Einstellungsdatei aus diesem Verzeichnis geladen.  z.B.  "-epd:\helden"
```

^ this doesn't list `-hsDebianMode` as a valid parameter anyway

In that case though, I'll remove that patch.

Re: [PR PATCH] [Updated] New package: helden-software-5.5.3

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages helden-software-5.5.3_1
https://github.com/void-linux/void-packages/pull/34073

New package: helden-software-5.5.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34073.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-helden-software-5.5.3_1-34073.patch --]
[-- Type: text/x-diff, Size: 5198 bytes --]

From 758a59e9a9e317745e59021dda33116404d691bf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sat, 25 Sep 2021 21:35:22 +0200
Subject: [PATCH] New package: helden-software-5.5.3

---
 .../patches/0001-fix-file-locations.patch     | 42 +++++++++++++++++++
 .../patches/0002-translate-comment.patch      | 27 ++++++++++++
 srcpkgs/helden-software/template              | 38 +++++++++++++++++
 3 files changed, 107 insertions(+)
 create mode 100644 srcpkgs/helden-software/patches/0001-fix-file-locations.patch
 create mode 100644 srcpkgs/helden-software/patches/0002-translate-comment.patch
 create mode 100644 srcpkgs/helden-software/template

diff --git a/srcpkgs/helden-software/patches/0001-fix-file-locations.patch b/srcpkgs/helden-software/patches/0001-fix-file-locations.patch
new file mode 100644
index 000000000000..9c29f559c652
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0001-fix-file-locations.patch
@@ -0,0 +1,42 @@
+From adc2694cabe3c84cb37bdfef3211202b3e9daf66 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:32:19 +0200
+Subject: [PATCH 1/2] fix file locations
+
+---
+ usr/{games => bin}/helden-software            | 2 +-
+ usr/share/applications/HeldenSoftware.desktop | 4 ++--
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+ rename usr/{games => bin}/helden-software (63%)
+
+diff --git a/usr/games/helden-software b/usr/bin/helden-software
+similarity index 63%
+rename from usr/games/helden-software
+rename to usr/bin/helden-software
+index 49d866b..98cdbc1 100755
+--- a/usr/games/helden-software
++++ b/usr/bin/helden-software
+@@ -4,4 +4,4 @@ HeldenArgs=-hsDebianMode
+ if [ -f /etc/default/helden-software ] ; then
+     . /etc/default/helden-software
+ fi
+-exec /usr/bin/java $JavaArgs -jar /usr/lib/heldensoftware/helden5.jar $HeldenArgs $@
+\ No newline at end of file
++exec /usr/bin/java $JavaArgs -jar /usr/lib/helden-software/helden5.jar $HeldenArgs $@
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 2c5ed8b..4319144 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -4,6 +4,6 @@ Type=Application
+ Terminal=false
+ Name=Helden-Software
+ Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
+-Exec=/usr/games/helden-software
++Exec=/usr/bin/helden-software
+ Icon=helden-software
+-Categories=Game;Java
++Categories=Game
+-- 
+2.36.1
+
diff --git a/srcpkgs/helden-software/patches/0002-translate-comment.patch b/srcpkgs/helden-software/patches/0002-translate-comment.patch
new file mode 100644
index 000000000000..c2f940ca8fd9
--- /dev/null
+++ b/srcpkgs/helden-software/patches/0002-translate-comment.patch
@@ -0,0 +1,27 @@
+From 566b29ca64c772da874b34f42da3d4e2c0605829 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
+ <jan.christian@gruenhage.xyz>
+Date: Sat, 25 Sep 2021 10:33:17 +0200
+Subject: [PATCH 2/2] translate comment
+
+---
+ usr/share/applications/HeldenSoftware.desktop | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/usr/share/applications/HeldenSoftware.desktop b/usr/share/applications/HeldenSoftware.desktop
+index 4319144..09cd90d 100644
+--- a/usr/share/applications/HeldenSoftware.desktop
++++ b/usr/share/applications/HeldenSoftware.desktop
+@@ -3,7 +3,8 @@ Version=1.0
+ Type=Application
+ Terminal=false
+ Name=Helden-Software
+-Comment=Ein Generator fuer 'Das schwarze Auge' (DSA)
++Comment=Character generator for the Pen&Paper RPG DSA
++Comment[de]=Ein Generator für 'Das schwarze Auge' (DSA)
+ Exec=/usr/bin/helden-software
+ Icon=helden-software
+ Categories=Game
+-- 
+2.36.1
+
diff --git a/srcpkgs/helden-software/template b/srcpkgs/helden-software/template
new file mode 100644
index 000000000000..77850de45887
--- /dev/null
+++ b/srcpkgs/helden-software/template
@@ -0,0 +1,38 @@
+# Template file for 'helden-software'
+pkgname=helden-software
+version=5.5.3
+revision=1
+_ver="${version}-0_all"
+_filename="${pkgname}_${_ver}.deb"
+create_wrksrc=yes
+build_style=fetch
+depends="openjdk-jre"
+short_desc="Character generator for the Pen&Paper RPG DSA"
+maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
+license="custom:Proprietary"
+homepage="https://www.helden-software.de/"
+distfiles="https://online.helden-software.de/rep/pool/main/h/helden-software/${_filename}"
+checksum=4bc08118ae1e78942bea543338de1ada17c21ebdb4b7f9e108910df0ba815a04
+repository="nonfree"
+restricted="yes"
+
+post_extract() {
+	ar x "${_filename}"
+	bsdtar -xf data.tar.gz
+}
+
+do_install() {
+	vmkdir usr/lib/helden-software
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons
+	vmkdir etc/default
+
+	vlicense usr/share/doc/helden-software/copyright
+
+	vbin usr/bin/helden-software
+
+	vcopy usr/share/icons/* usr/share/icons
+	vcopy usr/lib/heldensoftware/helden5.jar usr/lib/helden-software/helden5.jar
+	vcopy etc/default/helden-software etc/default/helden-software
+	vcopy usr/share/applications/HeldenSoftware.desktop usr/share/applications/HeldenSoftware.desktop
+}

Re: [PR REVIEW] New package: helden-software-5.5.3

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#discussion_r895783037

Comment:
Maybe -hsLocalOff would also do something similiar 🤷 

Re: New package: helden-software-5.5.3

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34073#issuecomment-1243134975

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Merged]: New package: helden-software-5.5.3

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

There's a merged pull request on the void-packages repository

New package: helden-software-5.5.3
https://github.com/void-linux/void-packages/pull/34073

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**