From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] ecl: enable tests
Date: Sat, 20 Nov 2021 23:31:41 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34175@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
There is a new pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages ecl
https://github.com/void-linux/void-packages/pull/34175
ecl: enable tests
The tests for ecl were not running as `make check` failed to find the binary (according to upstream one should install it before running tests).
OTOH, there's a bunch of tests that fail. Out of 18098 tests there are around 10 that fail on x86_64 and i686 (the number varies as some failures are kind of random. On x86_64-musl there are about 30 more failures but they all seem to be the same (something to do with acosh(-infinity))
I lack the energy to look at this and my lisp-fu is almost nil. I was hoping that everything would pass but... (what can we expect from a test suite that it's not easy to run...)
It's also the case that failures in the test suite will NOT stop make with an error, so packaging with -Q is not broken.
I'm not revbumping b/c this should not change anything at all in the installed files.
cc: @knusbaum
A patch file from https://github.com/void-linux/void-packages/pull/34175.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ecl-34175.patch --]
[-- Type: text/x-diff, Size: 1903 bytes --]
From bce8144a480e815cbb19e729bbf4afc5d802d8e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sat, 20 Nov 2021 18:57:31 -0300
Subject: [PATCH] ecl: enable tests
---
srcpkgs/ecl/patches/fix-tests.patch | 15 +++++++++++++++
srcpkgs/ecl/template | 7 +++++++
2 files changed, 22 insertions(+)
create mode 100644 srcpkgs/ecl/patches/fix-tests.patch
diff --git a/srcpkgs/ecl/patches/fix-tests.patch b/srcpkgs/ecl/patches/fix-tests.patch
new file mode 100644
index 000000000000..1705be9681d6
--- /dev/null
+++ b/srcpkgs/ecl/patches/fix-tests.patch
@@ -0,0 +1,15 @@
+The test config finds the build directory by looking for the file
+'BUILD-STAMP'. However, the build system creates 'build-stamp' instead
+so it will never be found on a case-sensitive filesystem.
+
+--- a/src/tests/config.lsp.in 2021-02-01 09:59:46.000000000 -0300
++++ b/src/tests/config.lsp.in 2021-11-20 18:12:39.318173405 -0300
+@@ -41,7 +41,7 @@
+ (loop with root = (si::get-library-pathname)
+ with lib-name = (format nil "../lib/ecl-~A/" (lisp-implementation-version))
+ for base in (list root (merge-pathnames lib-name root))
+- when (or (probe-file (merge-pathnames "./BUILD-STAMP" base))
++ when (or (probe-file (merge-pathnames "./build-stamp" base))
+ (probe-file (merge-pathnames "./COPYING" base)))
+ do (return base)))
+
diff --git a/srcpkgs/ecl/template b/srcpkgs/ecl/template
index 2f13da4003f4..220a97da6c8c 100644
--- a/srcpkgs/ecl/template
+++ b/srcpkgs/ecl/template
@@ -20,3 +20,10 @@ if [ "$CROSS_BUILD" ]; then
hostmakedepends+=" ecl"
configure_args+=" --with-cross-config=${XBPS_SRCPKGDIR}/ecl/files/cross_config"
fi
+
+pre_check() {
+ export ECLDIR=$wrksrc/build/
+ export LD_LIBRARY_PATH=$wrksrc/build/
+ export TEST_IMAGE=$wrksrc/build/bin/ecl
+ make_check_args="ECL=$TEST_IMAGE"
+}
next reply other threads:[~2021-11-20 22:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-20 22:31 tornaria [this message]
2021-11-21 4:36 ` ericonr
2021-11-21 4:37 ` ericonr
2021-11-21 12:45 ` [PR PATCH] [Updated] " tornaria
2021-11-21 17:50 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34175@inbox.vuxu.org \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).