Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance
@ 2021-11-22 20:34 TrueTechie
  2021-11-28  5:41 ` rtl88x2bu-dkms: Fix Module Compilation Error and Consistency ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: TrueTechie @ 2021-11-22 20:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1613 bytes --]

There is a new pull request by TrueTechie against master on the void-packages repository

https://github.com/TrueTechie/void-packages master
https://github.com/void-linux/void-packages/pull/34207

rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture: x86_64

In order to resolve #34190, i changed the package base from https://github.com/EntropicEffect/rtl8822bu to https://github.com/morrownr/88x2bu-20210702 which provides both a working and newer module than the previous distfile source. I also changed the package name so that it fits with both the range of support of the driver and the upstream repo itself.

I'm new to packaging for Void so if I made any mistakes please feel free to let me know.

A patch file from https://github.com/void-linux/void-packages/pull/34207.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-34207.patch --]
[-- Type: text/x-diff, Size: 4709 bytes --]

From 0aa8de77a024c3409f445327ce23f9586df826c3 Mon Sep 17 00:00:00 2001
From: TrueTechie <TrueTechie@mailo.com>
Date: Mon, 22 Nov 2021 15:01:08 -0500
Subject: [PATCH] change package distfiles and name for rtl88x2bu-dkms

---
 srcpkgs/rtl88x2bu-dkms/files/dkms.conf        | 11 +++++
 ...0001-void-arch-generic-plumbing-bits.patch | 44 ++++++++++++++++++
 srcpkgs/rtl88x2bu-dkms/template               | 46 +++++++++++++++++++
 3 files changed, 101 insertions(+)
 create mode 100644 srcpkgs/rtl88x2bu-dkms/files/dkms.conf
 create mode 100644 srcpkgs/rtl88x2bu-dkms/patches/0001-void-arch-generic-plumbing-bits.patch
 create mode 100644 srcpkgs/rtl88x2bu-dkms/template

diff --git a/srcpkgs/rtl88x2bu-dkms/files/dkms.conf b/srcpkgs/rtl88x2bu-dkms/files/dkms.conf
new file mode 100644
index 000000000000..3156be8132bc
--- /dev/null
+++ b/srcpkgs/rtl88x2bu-dkms/files/dkms.conf
@@ -0,0 +1,11 @@
+PACKAGE_NAME="rtl8822bu"
+PACKAGE_VERSION="@VERSION@"
+BUILT_MODULE_NAME="88x2bu"
+PROCS_NUM=$(nproc)
+[ $PROCS_NUM -gt 16 ] && PROCS_NUM=16
+MAKE="'make' -j$PROCS_NUM KVER=${kernelver} 
+KSRC=/lib/modules/${kernelver}/build"
+CLEAN="make clean"
+DEST_MODULE_LOCATION="/kernel/drivers/net/wireless"
+AUTOINSTALL="yes"
+REMAKE_INITRD=no
diff --git a/srcpkgs/rtl88x2bu-dkms/patches/0001-void-arch-generic-plumbing-bits.patch b/srcpkgs/rtl88x2bu-dkms/patches/0001-void-arch-generic-plumbing-bits.patch
new file mode 100644
index 000000000000..5d11ea074fd7
--- /dev/null
+++ b/srcpkgs/rtl88x2bu-dkms/patches/0001-void-arch-generic-plumbing-bits.patch
@@ -0,0 +1,44 @@
+From 9cecd7211e1c41ce0716f923961cc07b119be573 Mon Sep 17 00:00:00 2001
+From: Daniel Kolesa <daniel@octaforge.org>
+Date: Sat, 12 Dec 2020 05:03:29 +0100
+Subject: [PATCH] void arch-generic plumbing bits
+
+---
+ Makefile | 14 +++++++++++++-
+ 1 file changed, 13 insertions(+), 1 deletion(-)
+
+diff --git Makefile Makefile
+index 29da0bf..d58bc95 100644
+--- a/Makefile
++++ b/Makefile
+@@ -97,7 +97,8 @@ CONFIG_RTW_SDIO_PM_KEEP_POWER = y
+ ###################### MP HW TX MODE FOR VHT #######################
+ CONFIG_MP_VHT_HW_TX_MODE = n
+ ###################### Platform Related #######################
+-CONFIG_PLATFORM_I386_PC = y
++CONFIG_PLATFORM_VOID_NATIVE = y
++CONFIG_PLATFORM_I386_PC = n
+ CONFIG_PLATFORM_ARM_RPI = n
+ CONFIG_PLATFORM_ANDROID_X86 = n
+ CONFIG_PLATFORM_ANDROID_INTEL_X86 = n
+@@ -1030,6 +1031,17 @@ endif
+ 
+ EXTRA_CFLAGS += -DDM_ODM_SUPPORT_TYPE=0x04
+ 
++ifeq ($(CONFIG_PLATFORM_VOID_NATIVE), y)
++EXTRA_CFLAGS += -DCONFIG_@@VOID_ENDIAN@@_ENDIAN
++EXTRA_CFLAGS += -DCONFIG_IOCTL_CFG80211 -DRTW_USE_CFG80211_STA_EVENT
++ARCH := @@VOID_ARCH@@
++KVER := $(shell uname -r)
++KSRC := /usr/lib/modules/$(KVER)/build
++MODDESTDIR := /usr/lib/modules/$(KVER)/kernel/drivers/net/wireless/
++INSTALL_PREFIX :=
++STAGINGMODDIR := /usr/lib/modules/$(KVER)/kernel/drivers/staging
++endif
++
+ ifeq ($(CONFIG_PLATFORM_I386_PC), y)
+ EXTRA_CFLAGS += -DCONFIG_LITTLE_ENDIAN
+ EXTRA_CFLAGS += -DCONFIG_IOCTL_CFG80211 -DRTW_USE_CFG80211_STA_EVENT
+-- 
+2.29.2
+
diff --git a/srcpkgs/rtl88x2bu-dkms/template b/srcpkgs/rtl88x2bu-dkms/template
new file mode 100644
index 000000000000..2c89aa701464
--- /dev/null
+++ b/srcpkgs/rtl88x2bu-dkms/template
@@ -0,0 +1,46 @@
+# Template file for 'rtl88x2bu-dkms'
+pkgname=rtl88x2bu-dkms
+version=20210702
+revision=1
+_gitrev=f033b6fa139103a49c17cccee298593fb849f8c1
+wrksrc="88x2bu-${version}-${_gitrev}"
+depends="dkms"
+short_desc="Realtek 8822BU USB WiFi driver (DKMS)"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="GPL-2.0-only"
+homepage="https://www.tp-link.com"
+distfiles="https://github.com/morrownr/88x2bu-20210702/archive/${_gitrev}.tar.gz"
+checksum=7f7a9405e68591c3c9ad205b862bc3891c02cca2f19ba25763a2ca9bdb0f170b
+dkms_modules="88x2bu ${version}"
+replaces=rtl8822bu-dkms
+
+case "$XBPS_TARGET_MACHINE" in
+	x86_64*) _karch="x86_64";;
+	i686*) _karch="i386";;
+	aarch64*) _karch="arm64";;
+	arm*) _karch="arm";;
+	ppc*) _karch="powerpc";;
+	mips*) _karch="mips";;
+	*) broken="kernel arch not defined";;
+esac
+
+post_patch() {
+	if [ "$XBPS_TARGET_ENDIAN" = "be" ]; then
+		vsed -i 's,@@VOID_ENDIAN@@,BIG,g' Makefile
+	else
+		vsed -i 's,@@VOID_ENDIAN@@,LITTLE,g' Makefile
+	fi
+	vsed -i "s,@@VOID_ARCH@@,${_karch},g" Makefile
+}
+
+do_install() {
+	vmkdir /usr/src/88x2bu-${version}
+	vcopy "*" usr/src/88x2bu-${version}
+	vinstall ${FILESDIR}/dkms.conf 644 usr/src/88x2bu-${version}
+	sed -i -e "s/@VERSION@/${version}-${revision}/" ${PKGDESTDIR}/usr/src/88x2bu-${version}/dkms.conf
+
+	# modules-load.d(5) file.
+	vmkdir usr/lib/modules-load.d
+	echo "88x2bu" > ${DESTDIR}/usr/lib/modules-load.d/88x2bu.conf
+	chmod 644 ${DESTDIR}/usr/lib/modules-load.d/88x2bu.conf
+}

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: rtl88x2bu-dkms: Fix Module Compilation Error and Consistency
  2021-11-22 20:34 [PR PATCH] rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance TrueTechie
@ 2021-11-28  5:41 ` ericonr
  2021-11-28  5:42 ` ericonr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-11-28  5:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34207#issuecomment-980843834

Comment:
This is creating an entirely new package, which means any users of the old package won't receive the new one.

It also isn't following the correct commit formatting.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: rtl88x2bu-dkms: Fix Module Compilation Error and Consistency
  2021-11-22 20:34 [PR PATCH] rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance TrueTechie
  2021-11-28  5:41 ` rtl88x2bu-dkms: Fix Module Compilation Error and Consistency ericonr
@ 2021-11-28  5:42 ` ericonr
  2022-06-16  2:14 ` github-actions
  2022-07-01  2:14 ` [PR PATCH] [Closed]: " github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-11-28  5:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34207#issuecomment-980843834

Comment:
This is creating an entirely new package, which means any users of the old package won't receive the new one.

It also isn't following the correct commit formatting.

Please see the `CONTRIBUTING.md` file for the commit formatting.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: rtl88x2bu-dkms: Fix Module Compilation Error and Consistency
  2021-11-22 20:34 [PR PATCH] rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance TrueTechie
  2021-11-28  5:41 ` rtl88x2bu-dkms: Fix Module Compilation Error and Consistency ericonr
  2021-11-28  5:42 ` ericonr
@ 2022-06-16  2:14 ` github-actions
  2022-07-01  2:14 ` [PR PATCH] [Closed]: " github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2022-06-16  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34207#issuecomment-1157155516

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: rtl88x2bu-dkms: Fix Module Compilation Error and Consistency
  2021-11-22 20:34 [PR PATCH] rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance TrueTechie
                   ` (2 preceding siblings ...)
  2022-06-16  2:14 ` github-actions
@ 2022-07-01  2:14 ` github-actions
  3 siblings, 0 replies; 5+ messages in thread
From: github-actions @ 2022-07-01  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

There's a closed pull request on the void-packages repository

rtl88x2bu-dkms: Fix Module Compilation Error and Consistency
https://github.com/void-linux/void-packages/pull/34207

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture: x86_64

In order to resolve #34190, i changed the package base from https://github.com/EntropicEffect/rtl8822bu to https://github.com/morrownr/88x2bu-20210702 which provides both a working and newer module than the previous distfile source. I also changed the package name so that it fits with both the range of support of the driver and the upstream repo itself.

I'm new to packaging for Void so if I made any mistakes please feel free to let me know.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-07-01  2:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-22 20:34 [PR PATCH] rtl88x2bu-dkms: update driver and change package distfile source and name to fix module compilation error and consistance TrueTechie
2021-11-28  5:41 ` rtl88x2bu-dkms: Fix Module Compilation Error and Consistency ericonr
2021-11-28  5:42 ` ericonr
2022-06-16  2:14 ` github-actions
2022-07-01  2:14 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).