Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] notes-up: update to 2.0.5, orphan.
@ 2021-11-28 11:14 not-chicken
  2021-11-28 12:28 ` [PR REVIEW] " paper42
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: not-chicken @ 2021-11-28 11:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages nu
https://github.com/void-linux/void-packages/pull/34283

notes-up: update to 2.0.5, orphan.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34283.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nu-34283.patch --]
[-- Type: text/x-diff, Size: 2705 bytes --]

From 0d2987fa6ef48eb205b412906bba331c0394cda1 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sun, 28 Nov 2021 16:37:40 +0530
Subject: [PATCH] notes-up: update to 2.0.5, orphan.

---
 srcpkgs/notes-up/patches/vala-0.50.patch | 18 ------------------
 srcpkgs/notes-up/template                | 18 +++++++-----------
 2 files changed, 7 insertions(+), 29 deletions(-)
 delete mode 100644 srcpkgs/notes-up/patches/vala-0.50.patch

diff --git a/srcpkgs/notes-up/patches/vala-0.50.patch b/srcpkgs/notes-up/patches/vala-0.50.patch
deleted file mode 100644
index 2d6bfb9ee459..000000000000
--- a/srcpkgs/notes-up/patches/vala-0.50.patch
+++ /dev/null
@@ -1,18 +0,0 @@
---- a/vapi/libmarkdown.vapi	2020-11-21 13:32:35.540125253 +0700
-+++ b/vapi/libmarkdown.vapi	2020-11-21 13:40:04.961780640 +0700
-@@ -41,7 +41,7 @@
- 	public void initialize ();
- 	public void with_html5_tags ();
- 	public void shlib_destructor ();
--	public char markdown_version[];
-+	public string markdown_version;
- 
- 	[Compact]
- 	[CCode (cname = "MMIOT", cprefix = "mkd_", free_function = "mkd_cleanup")]
-@@ -125,4 +125,4 @@
- 		NOSTYLE,
- 		EMBED
- 	}
--}
-\ No newline at end of file
-+}
diff --git a/srcpkgs/notes-up/template b/srcpkgs/notes-up/template
index 8fcacc6f4d99..e61b06efb666 100644
--- a/srcpkgs/notes-up/template
+++ b/srcpkgs/notes-up/template
@@ -1,25 +1,21 @@
 # Template file for 'notes-up'
 pkgname=notes-up
-version=2.0.2
+version=2.0.5
 revision=1
 wrksrc=Notes-up-${version}
-build_style=cmake
-configure_args="-Dnoele=$(vopt_if pantheon false true)"
+build_style=meson
 hostmakedepends="pkg-config intltool vala glib-devel"
 makedepends="libgee08-devel discount-devel webkit2gtk-devel granite-devel
-gtksourceview-devel gtkspell3-devel"
-depends="hicolor-icon-theme $(vopt_if pantheon contractor)"
+gtksourceview4-devel gtkspell3-devel"
+depends="hicolor-icon-theme"
 short_desc="Markdown notes editor & manager"
-maintainer="Lorem <notloremipsum@protonmail.com>"
+maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, BSD-3-Clause"
 homepage="https://github.com/Philip-Scott/Notes-up"
 distfiles="https://github.com/Philip-Scott/Notes-up/archive/${version}.tar.gz"
-checksum=35eb1df71034a118e66e6e00f5394c68423cfba7ceac035bde156d77da933b17
-build_options="pantheon"
-desc_option_pantheon="build with Contractor support"
+checksum=56ddf5ab3468c3bbb806106c41b485b020ade3c7f48d271bda1e78ddce5e1664
 
 post_install() {
-	ln -s com.github.philip-scott.notes-up ${DESTDIR}/usr/bin/notes-up
+	ln -s com.github.philip_scott.notes-up ${DESTDIR}/usr/bin/notes-up
 	vlicense data/assets/highlightjs/highlight.LICENSE
-	rm  ${DESTDIR}/usr/share/notes-up/highlight.LICENSE
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] notes-up: update to 2.0.5, orphan.
  2021-11-28 11:14 [PR PATCH] notes-up: update to 2.0.5, orphan not-chicken
@ 2021-11-28 12:28 ` paper42
  2021-11-28 12:35 ` not-chicken
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2021-11-28 12:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34283#discussion_r757889405

Comment:
Is intltool still required?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] notes-up: update to 2.0.5, orphan.
  2021-11-28 11:14 [PR PATCH] notes-up: update to 2.0.5, orphan not-chicken
  2021-11-28 12:28 ` [PR REVIEW] " paper42
@ 2021-11-28 12:35 ` not-chicken
  2021-11-28 12:36 ` [PR PATCH] [Updated] " not-chicken
  2021-11-28 14:29 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: not-chicken @ 2021-11-28 12:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New review comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/34283#discussion_r757890337

Comment:
`gettext` alone seems enough now.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] notes-up: update to 2.0.5, orphan.
  2021-11-28 11:14 [PR PATCH] notes-up: update to 2.0.5, orphan not-chicken
  2021-11-28 12:28 ` [PR REVIEW] " paper42
  2021-11-28 12:35 ` not-chicken
@ 2021-11-28 12:36 ` not-chicken
  2021-11-28 14:29 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: not-chicken @ 2021-11-28 12:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages nu
https://github.com/void-linux/void-packages/pull/34283

notes-up: update to 2.0.5, orphan.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34283.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nu-34283.patch --]
[-- Type: text/x-diff, Size: 2761 bytes --]

From 1112955b6f8b25aab09ca76fe2fa9df49cfd8ab5 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sun, 28 Nov 2021 16:37:40 +0530
Subject: [PATCH] notes-up: update to 2.0.5, orphan.

---
 srcpkgs/notes-up/patches/vala-0.50.patch | 18 ------------------
 srcpkgs/notes-up/template                | 20 ++++++++------------
 2 files changed, 8 insertions(+), 30 deletions(-)
 delete mode 100644 srcpkgs/notes-up/patches/vala-0.50.patch

diff --git a/srcpkgs/notes-up/patches/vala-0.50.patch b/srcpkgs/notes-up/patches/vala-0.50.patch
deleted file mode 100644
index 2d6bfb9ee459..000000000000
--- a/srcpkgs/notes-up/patches/vala-0.50.patch
+++ /dev/null
@@ -1,18 +0,0 @@
---- a/vapi/libmarkdown.vapi	2020-11-21 13:32:35.540125253 +0700
-+++ b/vapi/libmarkdown.vapi	2020-11-21 13:40:04.961780640 +0700
-@@ -41,7 +41,7 @@
- 	public void initialize ();
- 	public void with_html5_tags ();
- 	public void shlib_destructor ();
--	public char markdown_version[];
-+	public string markdown_version;
- 
- 	[Compact]
- 	[CCode (cname = "MMIOT", cprefix = "mkd_", free_function = "mkd_cleanup")]
-@@ -125,4 +125,4 @@
- 		NOSTYLE,
- 		EMBED
- 	}
--}
-\ No newline at end of file
-+}
diff --git a/srcpkgs/notes-up/template b/srcpkgs/notes-up/template
index 8fcacc6f4d99..481a214cfbc2 100644
--- a/srcpkgs/notes-up/template
+++ b/srcpkgs/notes-up/template
@@ -1,25 +1,21 @@
 # Template file for 'notes-up'
 pkgname=notes-up
-version=2.0.2
+version=2.0.5
 revision=1
 wrksrc=Notes-up-${version}
-build_style=cmake
-configure_args="-Dnoele=$(vopt_if pantheon false true)"
-hostmakedepends="pkg-config intltool vala glib-devel"
+build_style=meson
+hostmakedepends="pkg-config vala gettext glib-devel"
 makedepends="libgee08-devel discount-devel webkit2gtk-devel granite-devel
-gtksourceview-devel gtkspell3-devel"
-depends="hicolor-icon-theme $(vopt_if pantheon contractor)"
+gtksourceview4-devel gtkspell3-devel"
+depends="hicolor-icon-theme"
 short_desc="Markdown notes editor & manager"
-maintainer="Lorem <notloremipsum@protonmail.com>"
+maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, BSD-3-Clause"
 homepage="https://github.com/Philip-Scott/Notes-up"
 distfiles="https://github.com/Philip-Scott/Notes-up/archive/${version}.tar.gz"
-checksum=35eb1df71034a118e66e6e00f5394c68423cfba7ceac035bde156d77da933b17
-build_options="pantheon"
-desc_option_pantheon="build with Contractor support"
+checksum=56ddf5ab3468c3bbb806106c41b485b020ade3c7f48d271bda1e78ddce5e1664
 
 post_install() {
-	ln -s com.github.philip-scott.notes-up ${DESTDIR}/usr/bin/notes-up
+	ln -s com.github.philip_scott.notes-up ${DESTDIR}/usr/bin/notes-up
 	vlicense data/assets/highlightjs/highlight.LICENSE
-	rm  ${DESTDIR}/usr/share/notes-up/highlight.LICENSE
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: notes-up: update to 2.0.5, orphan.
  2021-11-28 11:14 [PR PATCH] notes-up: update to 2.0.5, orphan not-chicken
                   ` (2 preceding siblings ...)
  2021-11-28 12:36 ` [PR PATCH] [Updated] " not-chicken
@ 2021-11-28 14:29 ` paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2021-11-28 14:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

There's a merged pull request on the void-packages repository

notes-up: update to 2.0.5, orphan.
https://github.com/void-linux/void-packages/pull/34283

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-28 14:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-28 11:14 [PR PATCH] notes-up: update to 2.0.5, orphan not-chicken
2021-11-28 12:28 ` [PR REVIEW] " paper42
2021-11-28 12:35 ` not-chicken
2021-11-28 12:36 ` [PR PATCH] [Updated] " not-chicken
2021-11-28 14:29 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).