[-- Attachment #1: Type: text/plain, Size: 1208 bytes --] There is a new pull request by cinerea0 against master on the void-packages repository https://github.com/cinerea0/void-packages delta https://github.com/void-linux/void-packages/pull/34291 delta: update to 0.10.2 <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES** <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/34291.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-delta-34291.patch --] [-- Type: text/x-diff, Size: 948 bytes --] From 153789be1ce6366aa10483e2082689c4b0b0afb1 Mon Sep 17 00:00:00 2001 From: cinerea0 <cinerea0@disroot.org> Date: Sun, 28 Nov 2021 23:40:14 -0500 Subject: [PATCH] delta: update to 0.10.2 --- srcpkgs/delta/template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/srcpkgs/delta/template b/srcpkgs/delta/template index 15481ba9a01b..b399e9fe73d4 100644 --- a/srcpkgs/delta/template +++ b/srcpkgs/delta/template @@ -1,6 +1,6 @@ # Template file for 'delta' pkgname=delta -version=0.9.2 +version=0.10.2 revision=1 build_style=cargo checkdepends="git" @@ -9,7 +9,7 @@ maintainer="Andrew Benson <abenson+void@gmail.com>" license="MIT" homepage="https://github.com/dandavison/delta" distfiles="${homepage}/archive/${version}.tar.gz" -checksum=f002a94119cd5b6fd9deede7f344667358baf5015d0051e055fec6334ee0653f +checksum=e0f71d72eca543478941401bd96fefc5fa3f70e7860a9f858f63bfecf8fd77a5 post_install() { vlicense LICENSE
[-- Attachment #1: Type: text/plain, Size: 1675 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/34291#issuecomment-981296209 Comment: ``` Compiling git-delta v0.10.2 (/builddir/delta-0.10.2) error[E0277]: the trait bound `std::collections::HashSet<std::string::String>: From<[_; 0]>` is not satisfied --> src/utils/process.rs:689:46 | 689 | Some(CallingProcess::GitGrep(([].into(), [].into()))) | ^^^^ the trait `From<[_; 0]>` is not implemented for `std::collections::HashSet<std::string::String>` | = note: required because of the requirements on the impl of `Into<std::collections::HashSet<std::string::String>>` for `[_; 0]` error[E0277]: the trait bound `std::collections::HashSet<std::string::String>: From<[_; 0]>` is not satisfied --> src/utils/process.rs:689:42 | 689 | Some(CallingProcess::GitGrep(([].into(), [].into()))) | ^^^^^^^^^^^^^^^^^^^^^^ the trait `From<[_; 0]>` is not implemented for `std::collections::HashSet<std::string::String>` | = note: required because of the requirements on the impl of `Into<std::collections::HashSet<std::string::String>>` for `[_; 0]` error: aborting due to 2 previous errors For more information about this error, try `rustc --explain E0277`. error: could not compile `git-delta` To learn more, run the command again with --verbose. => ERROR: delta-0.10.2_1: do_check: '${make_cmd} test --release --target ${RUST_TARGET} ${configure_args} ``` tests fail to compile, do you think they are depending on new Rust features we don't have?
[-- Attachment #1: Type: text/plain, Size: 356 bytes --] New comment by cinerea0 on void-packages repository https://github.com/void-linux/void-packages/pull/34291#issuecomment-981298183 Comment: I swear, this happens every time I forget to run `xbps-src check` locally. Yes, this looks like a guarantee that could be proven by a newer version of the rust compiler. Would you prefer I close this or set to WIP?
[-- Attachment #1: Type: text/plain, Size: 232 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/34291#issuecomment-981298628 Comment: It's only check, IMO you can set `make_check=no` with an appropriate `# TODO/FIXME` comment
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --] There is an updated pull request by cinerea0 against master on the void-packages repository https://github.com/cinerea0/void-packages delta https://github.com/void-linux/void-packages/pull/34291 delta: update to 0.10.2 <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES** <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/34291.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-delta-34291.patch --] [-- Type: text/x-diff, Size: 1014 bytes --] From d785196774f5e46de0ba7104980a9156d478540f Mon Sep 17 00:00:00 2001 From: cinerea0 <cinerea0@disroot.org> Date: Mon, 29 Nov 2021 00:49:50 -0500 Subject: [PATCH] delta: update to 0.10.2 --- srcpkgs/delta/template | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/srcpkgs/delta/template b/srcpkgs/delta/template index 15481ba9a01b..14c922099a17 100644 --- a/srcpkgs/delta/template +++ b/srcpkgs/delta/template @@ -1,6 +1,6 @@ # Template file for 'delta' pkgname=delta -version=0.9.2 +version=0.10.2 revision=1 build_style=cargo checkdepends="git" @@ -9,7 +9,9 @@ maintainer="Andrew Benson <abenson+void@gmail.com>" license="MIT" homepage="https://github.com/dandavison/delta" distfiles="${homepage}/archive/${version}.tar.gz" -checksum=f002a94119cd5b6fd9deede7f344667358baf5015d0051e055fec6334ee0653f +checksum=e0f71d72eca543478941401bd96fefc5fa3f70e7860a9f858f63bfecf8fd77a5 +# TODO: Re-enable checks when Rust gets updated +make_check=no post_install() { vlicense LICENSE
[-- Attachment #1: Type: text/plain, Size: 290 bytes --] New review comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/34291#discussion_r758058808 Comment: ```suggestion make_check=no # TODO: Re-enable checks when Rust gets updated ``` So `grep make_check=no` gives you the justification too :)
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --] There is an updated pull request by cinerea0 against master on the void-packages repository https://github.com/cinerea0/void-packages delta https://github.com/void-linux/void-packages/pull/34291 delta: update to 0.10.2 <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES** <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/34291.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-delta-34291.patch --] [-- Type: text/x-diff, Size: 1013 bytes --] From 8f93bb8d396a9286cc0bb0d14b1d33b575ab7924 Mon Sep 17 00:00:00 2001 From: cinerea0 <cinerea0@disroot.org> Date: Mon, 29 Nov 2021 01:08:42 -0500 Subject: [PATCH] delta: update to 0.10.2 --- srcpkgs/delta/template | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/srcpkgs/delta/template b/srcpkgs/delta/template index 15481ba9a01b..bd5040d70709 100644 --- a/srcpkgs/delta/template +++ b/srcpkgs/delta/template @@ -1,6 +1,6 @@ # Template file for 'delta' pkgname=delta -version=0.9.2 +version=0.10.2 revision=1 build_style=cargo checkdepends="git" @@ -9,7 +9,8 @@ maintainer="Andrew Benson <abenson+void@gmail.com>" license="MIT" homepage="https://github.com/dandavison/delta" distfiles="${homepage}/archive/${version}.tar.gz" -checksum=f002a94119cd5b6fd9deede7f344667358baf5015d0051e055fec6334ee0653f +checksum=e0f71d72eca543478941401bd96fefc5fa3f70e7860a9f858f63bfecf8fd77a5 +make_check=no # TODO: Re-enable checks when Rust gets updated post_install() { vlicense LICENSE
[-- Attachment #1: Type: text/plain, Size: 190 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/34291#issuecomment-981368261 Comment: Leave a link so I see the mention on my PR #32555
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --] There's a merged pull request on the void-packages repository delta: update to 0.10.2 https://github.com/void-linux/void-packages/pull/34291 Description: <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES** <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl -->