[PR PATCH] [wip] new package: firewalld-1.0.1

[PR PATCH] [wip] new package: firewalld-1.0.1

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

There is a new pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.1
Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1728 bytes --]

From ba3a24fe8f06ebda29a954a5e8c035c731d05db4 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.1

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..62f228bf1b4f
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,20 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.1

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.1
Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1754 bytes --]

From 395bb3aa9fa3577d6710efa362b98c4eda49b7f5 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.1

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..c81b75a726d6
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,21 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables"
+checkdepends="nftables"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.1

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.1
Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1758 bytes --]

From 212ece0fa25eb73fdf1e289d487d30f7c010b636 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.1

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..35e0c0a7e353
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,24 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+do_check() {
+	true
+}
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.1

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.1
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1755 bytes --]

From 8ee4b4ea62fe742df392b3062fa96ada90376a48 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.1

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..0bdf64fe5893
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,24 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+do_check() {
+	:
+}
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.1

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.1
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1755 bytes --]

From 1e91be15d2d385a1dd29e88bc6a9dfce38b52efe Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..0bdf64fe5893
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,24 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+do_check() {
+	:
+}
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1761 bytes --]

From 619d3224df9f53dd082da6a9cc8dea0d5559511b Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..5db1597eb543
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,24 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+
+do_check() {
+	:
+}
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR REVIEW] [wip] new package: firewalld-1.0.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#discussion_r767748304

Comment:
To skip checks, just set `make_check=no` rather than overriding `do_check`.

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1750 bytes --]

From 78d20128ebee2bd98782c29cb8ba0fed922e3d97 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..6a3d4b33d548
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,21 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1750 bytes --]

From 0d4871f9ae7a4a584d79beaf431eb83f9d9c19c4 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..61b78ca59721
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork > /dev/null 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..6a3d4b33d548
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,21 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 697 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#issuecomment-993127606

Comment:
> What kind of output does `firewalld` produce? If there is useful output, you might want to skip redirecting to the bit bucket and add a log service (see, _e.g._, the service provided by `duiadns`) to capture the text.

When you enable rejection logging that happens through the kernel logs. The only output from firewalld is like:

```
Starting firewalld - dynamic firewall daemon....
Started firewalld - dynamic firewall daemon.
```

Plus some warnings if backends are not available (the nftables backend alone is enough for it to work though)

Re: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#issuecomment-993127606

Comment:
> What kind of output does `firewalld` produce? If there is useful output, you might want to skip redirecting to the bit bucket and add a log service (see, _e.g._, the service provided by `duiadns`) to capture the text.

When you enable rejection logging that happens through the kernel logs. The only output from firewalld is like:

```
Starting firewalld - dynamic firewall daemon....
Started firewalld - dynamic firewall daemon.
```

Plus some warnings if backends are not available (the nftables backend alone is enough for it to work though)

EDIT: I'm not really familiar with runit logging conventions. Should I not redirect the output and let it display on the console?

Re: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#issuecomment-993127606

Comment:
> What kind of output does `firewalld` produce? If there is useful output, you might want to skip redirecting to the bit bucket and add a log service (see, _e.g._, the service provided by `duiadns`) to capture the text.

When you enable rejection logging that happens through the kernel logs. The only output from firewalld is like:

```
Starting firewalld - dynamic firewall daemon....
Started firewalld - dynamic firewall daemon.
```

Plus some warnings if backends are not available (the nftables backend alone is enough for it to work though)

EDIT: I'm not really familiar with runit logging conventions. Should I not redirect the output and let it display on the console?

EDIT: I see the vlogger setup. Would it be normal to spawn a log collector in this case on void?

Re: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#issuecomment-993127606

Comment:
> What kind of output does `firewalld` produce? If there is useful output, you might want to skip redirecting to the bit bucket and add a log service (see, _e.g._, the service provided by `duiadns`) to capture the text.

When you enable rejection logging that happens through the kernel logs. The only output from firewalld is like:

```
Starting firewalld - dynamic firewall daemon....
Started firewalld - dynamic firewall daemon.
```

Plus some warnings if backends are not available (the nftables backend alone is enough for it to work though)

EDIT: I'm not really familiar with runit logging conventions. Should I not redirect the output and let it display on the console?

EDIT: I see the vlogger setup. Would it be normal to spawn a log collector in this case on void? The daemon does not output anything aside from the startup messages.

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 1733 bytes --]

From 981220d2890a209eae4d53a19bf49fbf6be0c1fe Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/run |  3 +++
 srcpkgs/firewalld/template            | 21 +++++++++++++++++++++
 2 files changed, 24 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..0fd36799570a
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..6a3d4b33d548
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,21 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 2131 bytes --]

From 44776e29e7f2e6dfbfa48f44f34cfd2c9f62d6c5 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] new package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/log/run |  3 +++
 srcpkgs/firewalld/files/firewalld/run     |  3 +++
 srcpkgs/firewalld/template                | 21 +++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 000000000000..7b49eedfdf09
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..91629b75552c
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..6a3d4b33d548
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,21 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/${pkgname}/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#issuecomment-994818850

Comment:
I added a logger to the service. I think I am happy with the packaging.

I have been using this on my main laptop and a couple vms around the apartment and it works great for basic port blocking. I am leaving this marked WIP until I have time to setup a lab environment and test more advanced features before I commit to maintaining and supporting this package.

Re: [PR REVIEW] [wip] new package: firewalld-1.0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#discussion_r770128593

Comment:
wrap at 80 columns

Re: [PR REVIEW] [wip] new package: firewalld-1.0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#discussion_r770129184

Comment:
We require make_check=no to have a comment.

Re: [PR REVIEW] [wip] new package: firewalld-1.0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#discussion_r770128771

Comment:
```suggestion
distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.gz"
```

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 2197 bytes --]

From ad4188e01a216df3270822428d71cb1fb9d79b1b Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] New package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/log/run |  3 +++
 srcpkgs/firewalld/files/firewalld/run     |  3 +++
 srcpkgs/firewalld/template                | 23 +++++++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 000000000000..7b49eedfdf09
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..91629b75552c
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..43a8779d144c
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,23 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+	python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -rf ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [PR REVIEW] [wip] new package: firewalld-1.0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#discussion_r770429022

Comment:
```suggestion
 python3 docbook-xsl glib-devel"
```
replace the tab with one space

Re: [PR REVIEW] [wip] new package: firewalld-1.0.2

[paper42]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#discussion_r770428938

Comment:
```suggestion
	rm -r ${DESTDIR}/etc/sysconfig
```
This way, we can detect if this line is still necessary

Re: [PR PATCH] [Updated] [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages firewalld
https://github.com/void-linux/void-packages/pull/34378

[wip] new package: firewalld-1.0.2
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl



A patch file from https://github.com/void-linux/void-packages/pull/34378.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-34378.patch --]
[-- Type: text/x-diff, Size: 2196 bytes --]

From 3520248631293bef37229a780ed12c983fbec651 Mon Sep 17 00:00:00 2001
From: robert <Robert Lowry>
Date: Fri, 3 Dec 2021 02:41:20 -0600
Subject: [PATCH] New package: firewalld-1.0.2

---
 srcpkgs/firewalld/files/firewalld/log/run |  3 +++
 srcpkgs/firewalld/files/firewalld/run     |  3 +++
 srcpkgs/firewalld/template                | 23 +++++++++++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 000000000000..7b49eedfdf09
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 000000000000..91629b75552c
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork 2>&1
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 000000000000..1000fc3be98b
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,23 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=1.0.2
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Robert Lowry <bobertlo@gmail.com>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.gz"
+checksum=42d95d9649526dd47e5835b4577230e8a33cbad4bfe9dae6b016bb1777b9c736
+conf_files="/etc/firewalld/*"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	rm -r ${DESTDIR}/etc/sysconfig
+	vsv ${pkgname}
+}

Re: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34378#issuecomment-1031915465

Comment:
This has been working fine FYI, but the package would need a maintainer.

Re: [PR PATCH] [Closed]: [wip] new package: firewalld-1.0.2

[bobertlo]

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

There's a closed pull request on the void-packages repository

[wip] new package: firewalld-1.0.2
https://github.com/void-linux/void-packages/pull/34378

Description:
EDIT: set do_check to dummy since the test will not run without root. I could not find any documentation on this and any guidance is appreciated.

Hey all, this is a WIP but *functional* so far. I would appreciate any review/feedback since haven't packaged any services before and I've been mostly grepping around srcpkgs for examples. I have built this and tested briefly (running, functioning, logging) on `x86_64` and `x86_64-musl` as well as cross compiling for some arm archs (it's python and dbus FWIW)

There seems to be some play required in restarting dbus after the initial install and sv link to get it to run but it comes up fine after reboots after that so far. I am wondering if there is anything to be done about networkmanager in the startup and will be experimenting with that interaction.

Now that things are apparently working though I am going to port/test my ansible roles and try to test all the features I can think of. I use this package heavily on other distros and would like to bring it with me while using void.

#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64, x86_64-musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64
  - aarch64-musl