Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Aws 2112
@ 2021-12-12  3:35 bobertlo
  2021-12-12  5:17 ` aws-cli: update to 1.22.23 (with deps) uhohspaghetios
                   ` (15 more replies)
  0 siblings, 16 replies; 17+ messages in thread
From: bobertlo @ 2021-12-12  3:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

There is a new pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages aws-2112
https://github.com/void-linux/void-packages/pull/34490

Aws 2112
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: yes

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/34490.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aws-2112-34490.patch --]
[-- Type: text/x-diff, Size: 3676 bytes --]

From 6f0c073e56cf83cb86d5850c185e85d4b8869fd2 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:27:22 -0600
Subject: [PATCH 1/3] python3-botocore: update to 1.23.23

---
 srcpkgs/python3-botocore/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-botocore/template b/srcpkgs/python3-botocore/template
index 6b2c6f07ac35..353dabb518fb 100644
--- a/srcpkgs/python3-botocore/template
+++ b/srcpkgs/python3-botocore/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-botocore'
 pkgname=python3-botocore
-version=1.17.28
-revision=4
+version=1.23.23
+revision=1
 wrksrc="botocore-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -11,4 +11,6 @@ maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/botocore"
 distfiles="https://github.com/boto/botocore/archive/${version}.tar.gz"
-checksum=c9a4b4ffedeff89848a899bd4634be46a21a190690b505c2050888c0a5447936
+checksum=6b23a1e91387c1a461f10b17bde9ace15b3c128ed385646ab058644dfedd2c47
+# pytest marked deprecated, suggests using tox (which does not test against system packages)
+make_check=no

From 3f9f4d30bb63f1b461438dc19e4445906392af36 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:30:56 -0600
Subject: [PATCH 2/3] python3-s3transfer: update to 0.5.0

---
 srcpkgs/python3-s3transfer/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-s3transfer/template b/srcpkgs/python3-s3transfer/template
index 525c3ad252f5..8437f352b1dc 100644
--- a/srcpkgs/python3-s3transfer/template
+++ b/srcpkgs/python3-s3transfer/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-s3transfer'
 pkgname=python3-s3transfer
-version=0.3.3
-revision=4
+version=0.5.0
+revision=1
 wrksrc="s3transfer-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -11,4 +11,6 @@ maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/s3transfer"
 distfiles="https://github.com/boto/s3transfer/archive/${version}.tar.gz"
-checksum=0c8b0f7aaf32173d1475df0a453bfdc37be8207ea15c1d8415a590ef3986fc51
+checksum=a07ff8461f1dfa081fa5f02c1e6ad3f7bb7a4f3ca424e913ba48fcf5b1c87640
+# pytest marked deprecated, suggests using tox (which does not test against system packages)
+make_check=no

From 2f27bfa57afb800ff4cedb2eab78ccc1d38bc2c2 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:33:37 -0600
Subject: [PATCH 3/3] aws-cli: update to 1.22.23

---
 srcpkgs/aws-cli/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/aws-cli/template b/srcpkgs/aws-cli/template
index 67550003bd47..5788898b9fb7 100644
--- a/srcpkgs/aws-cli/template
+++ b/srcpkgs/aws-cli/template
@@ -1,7 +1,7 @@
 # Template file for 'aws-cli'
 pkgname=aws-cli
-version=1.18.125
-revision=3
+version=1.22.23
+revision=1
 wrksrc="aws-cli-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -12,7 +12,9 @@ maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/aws/aws-cli"
 distfiles="https://github.com/aws/aws-cli/archive/${version}.tar.gz"
-checksum=97f632fb7aede8f7986a4bd381f3d460606e9c31ef91f02388f7895dd5822c27
+checksum=d5424e05c87963547d6c98440391c6729e4e4f8eb7a4c64520ff7eefeffe41f3
+# pytest marked deprecated, suggests using tox (which does not test against system packagaes)
+make_check=no
 
 post_install() {
 	vinstall bin/aws_bash_completer 644 usr/share/bash-completion/completions aws

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
@ 2021-12-12  5:17 ` uhohspaghetios
  2021-12-12  8:43 ` dotnetfox
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: uhohspaghetios @ 2021-12-12  5:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by uhohspaghetios on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991836875

Comment:
Works for me.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
  2021-12-12  5:17 ` aws-cli: update to 1.22.23 (with deps) uhohspaghetios
@ 2021-12-12  8:43 ` dotnetfox
  2021-12-12 11:33 ` paper42
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: dotnetfox @ 2021-12-12  8:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]

New comment by dotnetfox on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991856439

Comment:
@bobertlo, your particular comment in all these commits caught my interest.

```sh
# pytest marked deprecated, suggests using tox (which does not test against system packages)
```

You see, I too got entrapped with tests (PR #34489) and it seems I have to explicitly specify `python3-pytest` in `checkdepends` along with packages it uses during tests.

If `python3-pytest` is not defined, `do_check` falls back to that "deprecated testing" which you mentioned.

```sh
do_check() {
    if python3 -c 'import pytest' >/dev/null 2>&1; then
        PYTHONPATH="$(cd build/lib* && pwd)" \
            python3 -m pytest ${make_check_args} ${make_check_target}
    else
        # Fall back to deprecated setup.py test orchestration without pytest
        if [ -z "$make_check_target" ]; then
            if ! python3 setup.py --help test >/dev/null 2>&1; then
                msg_warn "No command 'test' defined by setup.py.\n"
                return 0
            fi
        fi

        : ${make_check_target:=test}
        python3 setup.py ${make_check_target} ${make_check_args}
    fi
}
```

To be certain, the `python3-module` build style does not append `python3-pytest` to anywhere.

As you can see above, it is mentioned only within `do_check`.

Hope this information will be useful for you.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
  2021-12-12  5:17 ` aws-cli: update to 1.22.23 (with deps) uhohspaghetios
  2021-12-12  8:43 ` dotnetfox
@ 2021-12-12 11:33 ` paper42
  2021-12-12 12:49 ` bobertlo
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 11:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991881021

Comment:
> ```
> # pytest marked deprecated, suggests using tox (which does not test against system packages)
> ```

Where exactly is this comment from? They migrated to pytest in september, so I would assume it's not already deprecated.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (2 preceding siblings ...)
  2021-12-12 11:33 ` paper42
@ 2021-12-12 12:49 ` bobertlo
  2021-12-12 13:44 ` paper42
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: bobertlo @ 2021-12-12 12:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991892684

Comment:
> > ```
> > # pytest marked deprecated, suggests using tox (which does not test against system packages)
> > ```
> 
> Where exactly is this comment from? They migrated to pytest in september, so I would assume it's not already deprecated.

When I got the tests running with their deps installed and pytest it still says:

```
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox
```

The Tox tests install their own python3-venv and download package dependencies with pip.

@dotnetfox the tests will run but give that warning message and I did find that code you mentioned as well as figure out all the dependencies. I think they have some proprietary secret sauce going on with these tests. I got the test failures down to like 300-ish (out of ~30,000) and they were all saying invalid AWS credentials.

I spent a decent chunk of time on two different nights trying to get these tests to run.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (3 preceding siblings ...)
  2021-12-12 12:49 ` bobertlo
@ 2021-12-12 13:44 ` paper42
  2021-12-12 13:46 ` paper42
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 13:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991901287

Comment:
> When I got the tests running with their deps installed and pytest it still says:
> 
> ```
> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox
> ```

That's a message from `setup.py test` which is deprecated. We should use pytest if possible:
```sh
checkdepends="python3-pytest $depends"
```
But it seems like there is a lot of tests and we will need to skip some of them or skip them anyway. Even if you decide it's not worth fixing them (which I think might be ok in this case), the reason for this should be modified.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (4 preceding siblings ...)
  2021-12-12 13:44 ` paper42
@ 2021-12-12 13:46 ` paper42
  2021-12-12 13:54 ` paper42
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 13:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991901287

Comment:
> When I got the tests running with their deps installed and pytest it still says:
> 
> ```
> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox
> ```

That's a message from `setup.py test` which is deprecated, you are not using pytest if you are getting this message. We should use pytest if possible:
```sh
checkdepends="python3-pytest $depends"
```
But it seems like there is a lot of tests and we will need to skip some of them or skip them anyway. Even if you decide it's not worth fixing them (which I think might be ok in this case), the reason for this should be modified.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (5 preceding siblings ...)
  2021-12-12 13:46 ` paper42
@ 2021-12-12 13:54 ` paper42
  2021-12-12 13:54 ` paper42
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 13:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991901287

Comment:
> When I got the tests running with their deps installed and pytest it still says:
> 
> ```
> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox
> ```

That's a message from `setup.py test` which is deprecated, you are not using pytest if you are getting this message. We should use pytest if possible:
```sh
checkdepends="python3-pytest $depends"
```

setup.py test is deprecated and produces this message. xbps-src tries to use setup.py test if pytest is not installed, so installing python3-pytest will fix this.

But it seems like there is a lot of tests and we will need to skip some of them or skip them anyway. Even if you decide it's not worth fixing them (which I think might be ok in this case), the reason for this should be modified.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (6 preceding siblings ...)
  2021-12-12 13:54 ` paper42
@ 2021-12-12 13:54 ` paper42
  2021-12-12 18:02 ` [PR PATCH] [Updated] " bobertlo
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 13:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991901287

Comment:
> When I got the tests running with their deps installed and pytest it still says:
> 
> ```
> WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox
> ```

That's a message from `setup.py test` which is deprecated, you are not using pytest if you are getting this message. We should use pytest if possible:
```sh
checkdepends="python3-pytest $depends"
```

`setup.py test` is deprecated and produces this message. `xbps-src` tries to use `setup.py test` if pytest is not installed, so installing python3-pytest will fix this.

But it seems like there is a lot of tests and we will need to skip some of them or skip them anyway. Even if you decide it's not worth fixing them (which I think might be ok in this case), the reason for this should be modified.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (7 preceding siblings ...)
  2021-12-12 13:54 ` paper42
@ 2021-12-12 18:02 ` bobertlo
  2021-12-12 18:08 ` bobertlo
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: bobertlo @ 2021-12-12 18:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages aws-2112
https://github.com/void-linux/void-packages/pull/34490

aws-cli: update to 1.22.23 (with deps)
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: yes

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/34490.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aws-2112-34490.patch --]
[-- Type: text/x-diff, Size: 4502 bytes --]

From 19367033eaa9eaa1fc45af25ce53b8cdbb097353 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:27:22 -0600
Subject: [PATCH 1/3] python3-botocore: update to 1.23.23

---
 srcpkgs/python3-botocore/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-botocore/template b/srcpkgs/python3-botocore/template
index 6b2c6f07ac35..a96867d6130a 100644
--- a/srcpkgs/python3-botocore/template
+++ b/srcpkgs/python3-botocore/template
@@ -1,14 +1,21 @@
 # Template file for 'python3-botocore'
 pkgname=python3-botocore
-version=1.17.28
-revision=4
+version=1.23.23
+revision=1
 wrksrc="botocore-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-dateutil python3-docutils python3-jmespath python3-urllib3"
+checkdepends="python3-dateutil python3-docutils python3-jmespath python3-urllib3 python3-pytest python3-jsonschema"
 short_desc="Core functionality library of boto 3 (Python3)"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/botocore"
 distfiles="https://github.com/boto/botocore/archive/${version}.tar.gz"
-checksum=c9a4b4ffedeff89848a899bd4634be46a21a190690b505c2050888c0a5447936
+checksum=6b23a1e91387c1a461f10b17bde9ace15b3c128ed385646ab058644dfedd2c47
+
+do_check() {
+	# integration tests want aws credentials
+	rm -r tests/functional/leak # these 6 tests fail, probably fixable
+	pytest tests/functional tests/unit
+}

From 20ce910ece5d781327867800f6fdf21a54d81a98 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:30:56 -0600
Subject: [PATCH 2/3] python3-s3transfer: update to 0.5.0

---
 srcpkgs/python3-s3transfer/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-s3transfer/template b/srcpkgs/python3-s3transfer/template
index 525c3ad252f5..e1ddcd43cddc 100644
--- a/srcpkgs/python3-s3transfer/template
+++ b/srcpkgs/python3-s3transfer/template
@@ -1,14 +1,20 @@
 # Template file for 'python3-s3transfer'
 pkgname=python3-s3transfer
-version=0.3.3
-revision=4
+version=0.5.0
+revision=1
 wrksrc="s3transfer-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-botocore"
+checkdepends="python3-botocore python3-pytest python3-mock"
 short_desc="Amazon S3 Transfer Manager (Python3)"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/s3transfer"
 distfiles="https://github.com/boto/s3transfer/archive/${version}.tar.gz"
-checksum=0c8b0f7aaf32173d1475df0a453bfdc37be8207ea15c1d8415a590ef3986fc51
+checksum=a07ff8461f1dfa081fa5f02c1e6ad3f7bb7a4f3ca424e913ba48fcf5b1c87640
+
+do_check() {
+	# integration tests want aws credentials
+	python3 -m pytest tests/unit tests/functional
+}

From 770ba287ae466748875b3b6ace7b8057f46ce97d Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:33:37 -0600
Subject: [PATCH 3/3] aws-cli: update to 1.22.23

---
 srcpkgs/aws-cli/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/aws-cli/template b/srcpkgs/aws-cli/template
index 67550003bd47..04111aee935d 100644
--- a/srcpkgs/aws-cli/template
+++ b/srcpkgs/aws-cli/template
@@ -1,18 +1,25 @@
 # Template file for 'aws-cli'
 pkgname=aws-cli
-version=1.18.125
-revision=3
+version=1.22.23
+revision=1
 wrksrc="aws-cli-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="groff python3-botocore python3-s3transfer python3-colorama
  python3-rsa python3-yaml python3-docutils"
+checkdepends="groff python3-botocore python3-s3transfer python3-colorama
+ python3-rsa python3-yaml python3-docutils python3-pytest"
 short_desc="Universal Command Line Interface for Amazon Web Services"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/aws/aws-cli"
 distfiles="https://github.com/aws/aws-cli/archive/${version}.tar.gz"
-checksum=97f632fb7aede8f7986a4bd381f3d460606e9c31ef91f02388f7895dd5822c27
+checksum=d5424e05c87963547d6c98440391c6729e4e4f8eb7a4c64520ff7eefeffe41f3
+
+do_check() {
+	# integration tests want aws credentials, have some other issues not worth fixing
+	PATH=$PWD/bin:$PATH PYTHONPATH=$PWD python3 -m pytest tests/unit tests/functional
+}
 
 post_install() {
 	vinstall bin/aws_bash_completer 644 usr/share/bash-completion/completions aws

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (8 preceding siblings ...)
  2021-12-12 18:02 ` [PR PATCH] [Updated] " bobertlo
@ 2021-12-12 18:08 ` bobertlo
  2021-12-12 20:50 ` [PR REVIEW] " paper42
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: bobertlo @ 2021-12-12 18:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

New comment by bobertlo on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#issuecomment-991944426

Comment:
@paper42 oops I guess I misunderstood that. sorry!

I had to disable all the intergration tests. They seem to want aws credentials and have other issues apparently related to the build environment.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (9 preceding siblings ...)
  2021-12-12 18:08 ` bobertlo
@ 2021-12-12 20:50 ` paper42
  2021-12-12 20:50 ` paper42
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 20:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#discussion_r767325494

Comment:
```suggestion
checkdepends="$depends python3-pytest python3-jsonschema"
```

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (11 preceding siblings ...)
  2021-12-12 20:50 ` paper42
@ 2021-12-12 20:50 ` paper42
  2021-12-12 23:14 ` [PR PATCH] [Updated] " bobertlo
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 20:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#discussion_r767326029

Comment:
```suggestion
# integration tests want aws credentials
make_check_target="tests/functional tests/unit"

pre_check() {
	rm -r tests/functional/leak # these 6 tests fail, probably fixable
}
```

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (10 preceding siblings ...)
  2021-12-12 20:50 ` [PR REVIEW] " paper42
@ 2021-12-12 20:50 ` paper42
  2021-12-12 20:50 ` paper42
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 20:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34490#discussion_r767325869

Comment:
https://github.com/boto/botocore/blob/23ee17f5446c78167ff442302471f9928c3b4b7c/.changes/1.18.0.json#L32

```json
  {
    "category": "dependency", 
    "description": "botocore has removed docutils as a required dependency", 
    "type": "feature"
  }
```

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (12 preceding siblings ...)
  2021-12-12 20:50 ` paper42
@ 2021-12-12 23:14 ` bobertlo
  2021-12-12 23:21 ` bobertlo
  2021-12-12 23:45 ` [PR PATCH] [Merged]: " paper42
  15 siblings, 0 replies; 17+ messages in thread
From: bobertlo @ 2021-12-12 23:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages aws-2112
https://github.com/void-linux/void-packages/pull/34490

aws-cli: update to 1.22.23 (with deps)
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: yes

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/34490.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aws-2112-34490.patch --]
[-- Type: text/x-diff, Size: 4400 bytes --]

From afca6db806cef5b83e5f007121156070456a3920 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:27:22 -0600
Subject: [PATCH 1/3] python3-botocore: update to 1.23.23

---
 srcpkgs/python3-botocore/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-botocore/template b/srcpkgs/python3-botocore/template
index 6b2c6f07ac35..995f9f257354 100644
--- a/srcpkgs/python3-botocore/template
+++ b/srcpkgs/python3-botocore/template
@@ -1,14 +1,21 @@
 # Template file for 'python3-botocore'
 pkgname=python3-botocore
-version=1.17.28
-revision=4
+version=1.23.23
+revision=1
 wrksrc="botocore-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-dateutil python3-docutils python3-jmespath python3-urllib3"
+depends="python3-dateutil python3-jmespath python3-urllib3"
+checkdepends="$depends python3-pytest python3-jsonschema"
 short_desc="Core functionality library of boto 3 (Python3)"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/botocore"
 distfiles="https://github.com/boto/botocore/archive/${version}.tar.gz"
-checksum=c9a4b4ffedeff89848a899bd4634be46a21a190690b505c2050888c0a5447936
+checksum=6b23a1e91387c1a461f10b17bde9ace15b3c128ed385646ab058644dfedd2c47
+# integration tests want aws credentials
+make_check_target="tests/functional tests/unit"
+
+pre_check() {
+	rm -r tests/functional/leak # these 6 tests fail, probably fixable
+}

From 20c6e8243bd56170801a305b619d3f4ff410e545 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:30:56 -0600
Subject: [PATCH 2/3] python3-s3transfer: update to 0.5.0

---
 srcpkgs/python3-s3transfer/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-s3transfer/template b/srcpkgs/python3-s3transfer/template
index 525c3ad252f5..54e1de67890c 100644
--- a/srcpkgs/python3-s3transfer/template
+++ b/srcpkgs/python3-s3transfer/template
@@ -1,14 +1,17 @@
 # Template file for 'python3-s3transfer'
 pkgname=python3-s3transfer
-version=0.3.3
-revision=4
+version=0.5.0
+revision=1
 wrksrc="s3transfer-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-botocore"
+checkdepends="python3-botocore python3-pytest python3-mock"
 short_desc="Amazon S3 Transfer Manager (Python3)"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/s3transfer"
 distfiles="https://github.com/boto/s3transfer/archive/${version}.tar.gz"
-checksum=0c8b0f7aaf32173d1475df0a453bfdc37be8207ea15c1d8415a590ef3986fc51
+checksum=a07ff8461f1dfa081fa5f02c1e6ad3f7bb7a4f3ca424e913ba48fcf5b1c87640
+# integration tests want aws credentials
+make_check_target="tests/unit tests/functional"

From c56ab481828500b679b6dc230564f202f20f4da7 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:33:37 -0600
Subject: [PATCH 3/3] aws-cli: update to 1.22.23

---
 srcpkgs/aws-cli/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/aws-cli/template b/srcpkgs/aws-cli/template
index 67550003bd47..0448d39f5a61 100644
--- a/srcpkgs/aws-cli/template
+++ b/srcpkgs/aws-cli/template
@@ -1,18 +1,24 @@
 # Template file for 'aws-cli'
 pkgname=aws-cli
-version=1.18.125
-revision=3
+version=1.22.23
+revision=1
 wrksrc="aws-cli-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="groff python3-botocore python3-s3transfer python3-colorama
  python3-rsa python3-yaml python3-docutils"
+checkdepends="$depends python3-pytest"
 short_desc="Universal Command Line Interface for Amazon Web Services"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/aws/aws-cli"
 distfiles="https://github.com/aws/aws-cli/archive/${version}.tar.gz"
-checksum=97f632fb7aede8f7986a4bd381f3d460606e9c31ef91f02388f7895dd5822c27
+checksum=d5424e05c87963547d6c98440391c6729e4e4f8eb7a4c64520ff7eefeffe41f3
+
+do_check() {
+	# integration tests want aws credentials, have some other issues not worth fixing
+	PATH=$PWD/bin:$PATH PYTHONPATH=$PWD python3 -m pytest tests/unit tests/functional
+}
 
 post_install() {
 	vinstall bin/aws_bash_completer 644 usr/share/bash-completion/completions aws

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (13 preceding siblings ...)
  2021-12-12 23:14 ` [PR PATCH] [Updated] " bobertlo
@ 2021-12-12 23:21 ` bobertlo
  2021-12-12 23:45 ` [PR PATCH] [Merged]: " paper42
  15 siblings, 0 replies; 17+ messages in thread
From: bobertlo @ 2021-12-12 23:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

There is an updated pull request by bobertlo against master on the void-packages repository

https://github.com/bobertlo/void-packages aws-2112
https://github.com/void-linux/void-packages/pull/34490

aws-cli: update to 1.22.23 (with deps)
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: yes

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/34490.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aws-2112-34490.patch --]
[-- Type: text/x-diff, Size: 4400 bytes --]

From 9fdb8b5c1b164546ba1e6a2b8e05da0fa2415405 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:27:22 -0600
Subject: [PATCH 1/3] python3-botocore: update to 1.23.23

---
 srcpkgs/python3-botocore/template | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-botocore/template b/srcpkgs/python3-botocore/template
index 6b2c6f07ac35..0271e9204c19 100644
--- a/srcpkgs/python3-botocore/template
+++ b/srcpkgs/python3-botocore/template
@@ -1,14 +1,21 @@
 # Template file for 'python3-botocore'
 pkgname=python3-botocore
-version=1.17.28
-revision=4
+version=1.23.23
+revision=1
 wrksrc="botocore-${version}"
 build_style=python3-module
+# integration tests want aws credentials
+make_check_target="tests/functional tests/unit"
 hostmakedepends="python3-setuptools"
-depends="python3-dateutil python3-docutils python3-jmespath python3-urllib3"
+depends="python3-dateutil python3-jmespath python3-urllib3"
+checkdepends="$depends python3-pytest python3-jsonschema"
 short_desc="Core functionality library of boto 3 (Python3)"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/botocore"
 distfiles="https://github.com/boto/botocore/archive/${version}.tar.gz"
-checksum=c9a4b4ffedeff89848a899bd4634be46a21a190690b505c2050888c0a5447936
+checksum=6b23a1e91387c1a461f10b17bde9ace15b3c128ed385646ab058644dfedd2c47
+
+pre_check() {
+	rm -r tests/functional/leak # these 6 tests fail, probably fixable
+}

From d0b274453f274a6aeda93f9e59a8587029bfc8f0 Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:30:56 -0600
Subject: [PATCH 2/3] python3-s3transfer: update to 0.5.0

---
 srcpkgs/python3-s3transfer/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-s3transfer/template b/srcpkgs/python3-s3transfer/template
index 525c3ad252f5..a848c12ccf27 100644
--- a/srcpkgs/python3-s3transfer/template
+++ b/srcpkgs/python3-s3transfer/template
@@ -1,14 +1,17 @@
 # Template file for 'python3-s3transfer'
 pkgname=python3-s3transfer
-version=0.3.3
-revision=4
+version=0.5.0
+revision=1
 wrksrc="s3transfer-${version}"
 build_style=python3-module
+# integration tests want aws credentials
+make_check_target="tests/unit tests/functional"
 hostmakedepends="python3-setuptools"
 depends="python3-botocore"
+checkdepends="python3-botocore python3-pytest python3-mock"
 short_desc="Amazon S3 Transfer Manager (Python3)"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/boto/s3transfer"
 distfiles="https://github.com/boto/s3transfer/archive/${version}.tar.gz"
-checksum=0c8b0f7aaf32173d1475df0a453bfdc37be8207ea15c1d8415a590ef3986fc51
+checksum=a07ff8461f1dfa081fa5f02c1e6ad3f7bb7a4f3ca424e913ba48fcf5b1c87640

From b2d446182cbe7807842286c646a074cc801d1b8d Mon Sep 17 00:00:00 2001
From: Robert Lowry <bobertlo@gmail.com>
Date: Sat, 11 Dec 2021 19:33:37 -0600
Subject: [PATCH 3/3] aws-cli: update to 1.22.23

---
 srcpkgs/aws-cli/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/aws-cli/template b/srcpkgs/aws-cli/template
index 67550003bd47..0448d39f5a61 100644
--- a/srcpkgs/aws-cli/template
+++ b/srcpkgs/aws-cli/template
@@ -1,18 +1,24 @@
 # Template file for 'aws-cli'
 pkgname=aws-cli
-version=1.18.125
-revision=3
+version=1.22.23
+revision=1
 wrksrc="aws-cli-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="groff python3-botocore python3-s3transfer python3-colorama
  python3-rsa python3-yaml python3-docutils"
+checkdepends="$depends python3-pytest"
 short_desc="Universal Command Line Interface for Amazon Web Services"
 maintainer="Robert Lowry <bobertlo@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/aws/aws-cli"
 distfiles="https://github.com/aws/aws-cli/archive/${version}.tar.gz"
-checksum=97f632fb7aede8f7986a4bd381f3d460606e9c31ef91f02388f7895dd5822c27
+checksum=d5424e05c87963547d6c98440391c6729e4e4f8eb7a4c64520ff7eefeffe41f3
+
+do_check() {
+	# integration tests want aws credentials, have some other issues not worth fixing
+	PATH=$PWD/bin:$PATH PYTHONPATH=$PWD python3 -m pytest tests/unit tests/functional
+}
 
 post_install() {
 	vinstall bin/aws_bash_completer 644 usr/share/bash-completion/completions aws

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Merged]: aws-cli: update to 1.22.23 (with deps)
  2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
                   ` (14 preceding siblings ...)
  2021-12-12 23:21 ` bobertlo
@ 2021-12-12 23:45 ` paper42
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-12 23:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

There's a merged pull request on the void-packages repository

aws-cli: update to 1.22.23 (with deps)
https://github.com/void-linux/void-packages/pull/34490

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: yes

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-12-12 23:45 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-12  3:35 [PR PATCH] Aws 2112 bobertlo
2021-12-12  5:17 ` aws-cli: update to 1.22.23 (with deps) uhohspaghetios
2021-12-12  8:43 ` dotnetfox
2021-12-12 11:33 ` paper42
2021-12-12 12:49 ` bobertlo
2021-12-12 13:44 ` paper42
2021-12-12 13:46 ` paper42
2021-12-12 13:54 ` paper42
2021-12-12 13:54 ` paper42
2021-12-12 18:02 ` [PR PATCH] [Updated] " bobertlo
2021-12-12 18:08 ` bobertlo
2021-12-12 20:50 ` [PR REVIEW] " paper42
2021-12-12 20:50 ` paper42
2021-12-12 20:50 ` paper42
2021-12-12 23:14 ` [PR PATCH] [Updated] " bobertlo
2021-12-12 23:21 ` bobertlo
2021-12-12 23:45 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).