Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] GNS3 2.2.28
@ 2021-12-15 13:55 tsndqst
  2021-12-15 22:18 ` [PR REVIEW] " paper42
                   ` (15 more replies)
  0 siblings, 16 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 13:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1193 bytes --]

There is a new pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages gns3-2.2.28
https://github.com/void-linux/void-packages/pull/34556

GNS3 2.2.28
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/34556.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gns3-2.2.28-34556.patch --]
[-- Type: text/x-diff, Size: 3208 bytes --]

From bed5cbcc7e9381453dbb6c297521b30a66235c38 Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:41 -0600
Subject: [PATCH 1/2] gns3-server: update to 2.2.28.

---
 srcpkgs/gns3-server/patches/requirements.patch | 3 ++-
 srcpkgs/gns3-server/template                   | 6 ++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gns3-server/patches/requirements.patch b/srcpkgs/gns3-server/patches/requirements.patch
index bf1fea9499b7..c6928da140e7 100644
--- a/srcpkgs/gns3-server/patches/requirements.patch
+++ b/srcpkgs/gns3-server/patches/requirements.patch
@@ -7,7 +7,8 @@ diff --git a/requirements.txt b/requirements.txt
 -aiohttp==3.7.4.post0
 +aiohttp>=3.7.4
  aiohttp-cors==0.7.0
- aiofiles==0.7.0
+-aiofiles==0.7.0
++aiofiles==0.8.0
 -Jinja2==3.0.1
 +Jinja2>=3.0.1
 -sentry-sdk==1.3.1
diff --git a/srcpkgs/gns3-server/template b/srcpkgs/gns3-server/template
index ada70f593a86..bbeb199f7bb1 100644
--- a/srcpkgs/gns3-server/template
+++ b/srcpkgs/gns3-server/template
@@ -1,10 +1,8 @@
 # Template file for 'gns3-server'
 pkgname=gns3-server
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
-# Skip tests/compute/docker/test_docker_vm.py::test_stop test that wasn't updated with the code https://github.com/GNS3/gns3-server/commit/b1a62dfd
-make_check_args="-k-test_stop"
 hostmakedepends="python3-setuptools"
 depends="python3-setuptools python3-jsonschema python3-aiohttp-cors python3-yarl
  python3-Jinja2 python3-psutil python3-aiofiles
@@ -15,7 +13,7 @@ maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
 distfiles="https://github.com/GNS3/gns3-server/archive/v${version}.tar.gz"
-checksum=ed45ab788ee976474289e9e73c5bbe78cab26ebfcdcc5d2eee086908d14d0c9f
+checksum=bd37601f2924fc00a9a1690478896566911e466699d68af0abadd097dd1e314b
 
 # The source archive contains statically linked artifacts for x86_64
 # glibc, since this is the only architecture supported by upstream, we

From 7dba3df475aaa36da1b26ffe51270cb7d32158bb Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:51 -0600
Subject: [PATCH 2/2] gns3-gui: update to 2.2.28.

---
 srcpkgs/gns3-gui/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gns3-gui/template b/srcpkgs/gns3-gui/template
index fb0b5d198308..91e5055ffa1d 100644
--- a/srcpkgs/gns3-gui/template
+++ b/srcpkgs/gns3-gui/template
@@ -1,6 +1,6 @@
 # Template file for 'gns3-gui'
 pkgname=gns3-gui
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
 # Skip tests/test_link.py::test_create_link test that wasn't updated with the code https://github.com/GNS3/gns3-gui/commit/545a9f53
@@ -15,7 +15,7 @@ maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
 distfiles="https://github.com/GNS3/${pkgname}/archive/v${version}.tar.gz"
-checksum=c5afadd2932703c38fb6d479be6966af65787ddc6abcb3f9b7c0b3f5722e0fd5
+checksum=8b6e5df17ae472bf3525e1adbb1a0d2c6f170df270f802163c00c02d75cc4ced
 
 post_install() {
 	vinstall gns3-gui.desktop 644 usr/share/applications

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
@ 2021-12-15 22:18 ` paper42
  2021-12-15 22:20 ` paper42
                   ` (14 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-15 22:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770081814

Comment:
What would you think about making this `>=`?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
  2021-12-15 22:18 ` [PR REVIEW] " paper42
@ 2021-12-15 22:20 ` paper42
  2021-12-15 22:20 ` paper42
                   ` (13 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-15 22:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770082804

Comment:
```suggestion
homepage="https://gns3.com"
changelog="https://raw.githubusercontent.com/GNS3/gns3-gui/master/CHANGELOG"
distfiles="https://github.com/GNS3/${pkgname}/archive/v${version}.tar.gz"
```

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
  2021-12-15 22:18 ` [PR REVIEW] " paper42
  2021-12-15 22:20 ` paper42
@ 2021-12-15 22:20 ` paper42
  2021-12-15 22:22 ` [PR PATCH] [Updated] " tsndqst
                   ` (12 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-15 22:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770083018

Comment:
This should be fixed now

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (2 preceding siblings ...)
  2021-12-15 22:20 ` paper42
@ 2021-12-15 22:22 ` tsndqst
  2021-12-15 22:23 ` [PR REVIEW] " tsndqst
                   ` (11 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 22:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

There is an updated pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages gns3-2.2.28
https://github.com/void-linux/void-packages/pull/34556

GNS3 2.2.28
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/34556.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gns3-2.2.28-34556.patch --]
[-- Type: text/x-diff, Size: 3208 bytes --]

From 20438f12c4bcd706d59606b38fb92b39de55b79a Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:41 -0600
Subject: [PATCH 1/2] gns3-server: update to 2.2.28.

---
 srcpkgs/gns3-server/patches/requirements.patch | 3 ++-
 srcpkgs/gns3-server/template                   | 6 ++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gns3-server/patches/requirements.patch b/srcpkgs/gns3-server/patches/requirements.patch
index bf1fea9499b7..0f108f5d4b8b 100644
--- a/srcpkgs/gns3-server/patches/requirements.patch
+++ b/srcpkgs/gns3-server/patches/requirements.patch
@@ -7,7 +7,8 @@ diff --git a/requirements.txt b/requirements.txt
 -aiohttp==3.7.4.post0
 +aiohttp>=3.7.4
  aiohttp-cors==0.7.0
- aiofiles==0.7.0
+-aiofiles==0.7.0
++aiofiles>=0.8.0
 -Jinja2==3.0.1
 +Jinja2>=3.0.1
 -sentry-sdk==1.3.1
diff --git a/srcpkgs/gns3-server/template b/srcpkgs/gns3-server/template
index ada70f593a86..bbeb199f7bb1 100644
--- a/srcpkgs/gns3-server/template
+++ b/srcpkgs/gns3-server/template
@@ -1,10 +1,8 @@
 # Template file for 'gns3-server'
 pkgname=gns3-server
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
-# Skip tests/compute/docker/test_docker_vm.py::test_stop test that wasn't updated with the code https://github.com/GNS3/gns3-server/commit/b1a62dfd
-make_check_args="-k-test_stop"
 hostmakedepends="python3-setuptools"
 depends="python3-setuptools python3-jsonschema python3-aiohttp-cors python3-yarl
  python3-Jinja2 python3-psutil python3-aiofiles
@@ -15,7 +13,7 @@ maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
 distfiles="https://github.com/GNS3/gns3-server/archive/v${version}.tar.gz"
-checksum=ed45ab788ee976474289e9e73c5bbe78cab26ebfcdcc5d2eee086908d14d0c9f
+checksum=bd37601f2924fc00a9a1690478896566911e466699d68af0abadd097dd1e314b
 
 # The source archive contains statically linked artifacts for x86_64
 # glibc, since this is the only architecture supported by upstream, we

From 849819cfde1624dda0f8f4541f389c738068f47c Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:51 -0600
Subject: [PATCH 2/2] gns3-gui: update to 2.2.28.

---
 srcpkgs/gns3-gui/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gns3-gui/template b/srcpkgs/gns3-gui/template
index fb0b5d198308..91e5055ffa1d 100644
--- a/srcpkgs/gns3-gui/template
+++ b/srcpkgs/gns3-gui/template
@@ -1,6 +1,6 @@
 # Template file for 'gns3-gui'
 pkgname=gns3-gui
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
 # Skip tests/test_link.py::test_create_link test that wasn't updated with the code https://github.com/GNS3/gns3-gui/commit/545a9f53
@@ -15,7 +15,7 @@ maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
 distfiles="https://github.com/GNS3/${pkgname}/archive/v${version}.tar.gz"
-checksum=c5afadd2932703c38fb6d479be6966af65787ddc6abcb3f9b7c0b3f5722e0fd5
+checksum=8b6e5df17ae472bf3525e1adbb1a0d2c6f170df270f802163c00c02d75cc4ced
 
 post_install() {
 	vinstall gns3-gui.desktop 644 usr/share/applications

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (3 preceding siblings ...)
  2021-12-15 22:22 ` [PR PATCH] [Updated] " tsndqst
@ 2021-12-15 22:23 ` tsndqst
  2021-12-15 22:31 ` tsndqst
                   ` (10 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 22:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770084538

Comment:
I thought about doing that originally.  I pushed a change to use `>=`.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (4 preceding siblings ...)
  2021-12-15 22:23 ` [PR REVIEW] " tsndqst
@ 2021-12-15 22:31 ` tsndqst
  2021-12-15 22:33 ` [PR PATCH] [Updated] " tsndqst
                   ` (9 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 22:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770088471

Comment:
I enabled the test and it failed again.  I don't see any changes to gns3-gui related to those lines in the commit I highlighted.  I should raise an issue upstream.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (5 preceding siblings ...)
  2021-12-15 22:31 ` tsndqst
@ 2021-12-15 22:33 ` tsndqst
  2021-12-15 22:33 ` [PR REVIEW] " tsndqst
                   ` (8 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 22:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

There is an updated pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages gns3-2.2.28
https://github.com/void-linux/void-packages/pull/34556

GNS3 2.2.28
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/34556.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gns3-2.2.28-34556.patch --]
[-- Type: text/x-diff, Size: 3466 bytes --]

From 9882918c12a2bcbc19e74f54f67fb8ddaeb5a9ff Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:41 -0600
Subject: [PATCH 1/2] gns3-server: update to 2.2.28.

---
 srcpkgs/gns3-server/patches/requirements.patch | 3 ++-
 srcpkgs/gns3-server/template                   | 7 +++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gns3-server/patches/requirements.patch b/srcpkgs/gns3-server/patches/requirements.patch
index bf1fea9499b7..0f108f5d4b8b 100644
--- a/srcpkgs/gns3-server/patches/requirements.patch
+++ b/srcpkgs/gns3-server/patches/requirements.patch
@@ -7,7 +7,8 @@ diff --git a/requirements.txt b/requirements.txt
 -aiohttp==3.7.4.post0
 +aiohttp>=3.7.4
  aiohttp-cors==0.7.0
- aiofiles==0.7.0
+-aiofiles==0.7.0
++aiofiles>=0.8.0
 -Jinja2==3.0.1
 +Jinja2>=3.0.1
 -sentry-sdk==1.3.1
diff --git a/srcpkgs/gns3-server/template b/srcpkgs/gns3-server/template
index ada70f593a86..d404f9486f2a 100644
--- a/srcpkgs/gns3-server/template
+++ b/srcpkgs/gns3-server/template
@@ -1,10 +1,8 @@
 # Template file for 'gns3-server'
 pkgname=gns3-server
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
-# Skip tests/compute/docker/test_docker_vm.py::test_stop test that wasn't updated with the code https://github.com/GNS3/gns3-server/commit/b1a62dfd
-make_check_args="-k-test_stop"
 hostmakedepends="python3-setuptools"
 depends="python3-setuptools python3-jsonschema python3-aiohttp-cors python3-yarl
  python3-Jinja2 python3-psutil python3-aiofiles
@@ -14,8 +12,9 @@ short_desc="Graphical Network Simulator 3 - Server"
 maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
+changelog="https://raw.githubusercontent.com/GNS3/gns3-server/2.2/CHANGELOG"
 distfiles="https://github.com/GNS3/gns3-server/archive/v${version}.tar.gz"
-checksum=ed45ab788ee976474289e9e73c5bbe78cab26ebfcdcc5d2eee086908d14d0c9f
+checksum=bd37601f2924fc00a9a1690478896566911e466699d68af0abadd097dd1e314b
 
 # The source archive contains statically linked artifacts for x86_64
 # glibc, since this is the only architecture supported by upstream, we

From 392ad04fab9752a7cf704309847692a12444e046 Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:51 -0600
Subject: [PATCH 2/2] gns3-gui: update to 2.2.28.

---
 srcpkgs/gns3-gui/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gns3-gui/template b/srcpkgs/gns3-gui/template
index fb0b5d198308..1828d909dcad 100644
--- a/srcpkgs/gns3-gui/template
+++ b/srcpkgs/gns3-gui/template
@@ -1,6 +1,6 @@
 # Template file for 'gns3-gui'
 pkgname=gns3-gui
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
 # Skip tests/test_link.py::test_create_link test that wasn't updated with the code https://github.com/GNS3/gns3-gui/commit/545a9f53
@@ -14,8 +14,9 @@ short_desc="Graphical Network Simulator 3 - GUI"
 maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
+changelog="https://raw.githubusercontent.com/GNS3/gns3-gui/2.2/CHANGELOG"
 distfiles="https://github.com/GNS3/${pkgname}/archive/v${version}.tar.gz"
-checksum=c5afadd2932703c38fb6d479be6966af65787ddc6abcb3f9b7c0b3f5722e0fd5
+checksum=8b6e5df17ae472bf3525e1adbb1a0d2c6f170df270f802163c00c02d75cc4ced
 
 post_install() {
 	vinstall gns3-gui.desktop 644 usr/share/applications

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (6 preceding siblings ...)
  2021-12-15 22:33 ` [PR PATCH] [Updated] " tsndqst
@ 2021-12-15 22:33 ` tsndqst
  2021-12-15 22:34 ` tsndqst
                   ` (7 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 22:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770090015

Comment:
I added changelogs from the 2.2 branches of gns3-gui and gns3-server.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (7 preceding siblings ...)
  2021-12-15 22:33 ` [PR REVIEW] " tsndqst
@ 2021-12-15 22:34 ` tsndqst
  2021-12-15 23:03 ` paper42
                   ` (6 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-15 22:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770090015

Comment:
I added changelogs from the 2.2 branches of gns3-gui and gns3-server.  Thanks for the suggestion.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (8 preceding siblings ...)
  2021-12-15 22:34 ` tsndqst
@ 2021-12-15 23:03 ` paper42
  2021-12-16  1:05 ` tsndqst
                   ` (5 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-15 23:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770104268

Comment:
We should stay with master if possible, because when we update to 2.3/3.0, it will be one less line to change. Is there a reason you chose to go with the 2.2 branch?

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (9 preceding siblings ...)
  2021-12-15 23:03 ` paper42
@ 2021-12-16  1:05 ` tsndqst
  2021-12-16  1:08 ` [PR PATCH] [Updated] " tsndqst
                   ` (4 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-16  1:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770150808

Comment:
I thought there were changes in master that weren't in 2.2 but it looks like I was wrong.  I can change it to master.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Updated] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (10 preceding siblings ...)
  2021-12-16  1:05 ` tsndqst
@ 2021-12-16  1:08 ` tsndqst
  2021-12-16  5:03 ` [PR REVIEW] " tsndqst
                   ` (3 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-16  1:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

There is an updated pull request by tsndqst against master on the void-packages repository

https://github.com/tsndqst/void-packages gns3-2.2.28
https://github.com/void-linux/void-packages/pull/34556

GNS3 2.2.28
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/34556.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gns3-2.2.28-34556.patch --]
[-- Type: text/x-diff, Size: 3472 bytes --]

From 8fa33b2bcb2c92be1dec5943882630c146a31cf7 Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:41 -0600
Subject: [PATCH 1/2] gns3-server: update to 2.2.28.

---
 srcpkgs/gns3-server/patches/requirements.patch | 3 ++-
 srcpkgs/gns3-server/template                   | 7 +++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/gns3-server/patches/requirements.patch b/srcpkgs/gns3-server/patches/requirements.patch
index bf1fea9499b7..0f108f5d4b8b 100644
--- a/srcpkgs/gns3-server/patches/requirements.patch
+++ b/srcpkgs/gns3-server/patches/requirements.patch
@@ -7,7 +7,8 @@ diff --git a/requirements.txt b/requirements.txt
 -aiohttp==3.7.4.post0
 +aiohttp>=3.7.4
  aiohttp-cors==0.7.0
- aiofiles==0.7.0
+-aiofiles==0.7.0
++aiofiles>=0.8.0
 -Jinja2==3.0.1
 +Jinja2>=3.0.1
 -sentry-sdk==1.3.1
diff --git a/srcpkgs/gns3-server/template b/srcpkgs/gns3-server/template
index ada70f593a86..a129019d74ee 100644
--- a/srcpkgs/gns3-server/template
+++ b/srcpkgs/gns3-server/template
@@ -1,10 +1,8 @@
 # Template file for 'gns3-server'
 pkgname=gns3-server
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
-# Skip tests/compute/docker/test_docker_vm.py::test_stop test that wasn't updated with the code https://github.com/GNS3/gns3-server/commit/b1a62dfd
-make_check_args="-k-test_stop"
 hostmakedepends="python3-setuptools"
 depends="python3-setuptools python3-jsonschema python3-aiohttp-cors python3-yarl
  python3-Jinja2 python3-psutil python3-aiofiles
@@ -14,8 +12,9 @@ short_desc="Graphical Network Simulator 3 - Server"
 maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
+changelog="https://raw.githubusercontent.com/GNS3/gns3-server/master/CHANGELOG"
 distfiles="https://github.com/GNS3/gns3-server/archive/v${version}.tar.gz"
-checksum=ed45ab788ee976474289e9e73c5bbe78cab26ebfcdcc5d2eee086908d14d0c9f
+checksum=bd37601f2924fc00a9a1690478896566911e466699d68af0abadd097dd1e314b
 
 # The source archive contains statically linked artifacts for x86_64
 # glibc, since this is the only architecture supported by upstream, we

From b5a6e4188c9d0af936b3060a0daee31665e7d7b8 Mon Sep 17 00:00:00 2001
From: Tim Sandquist <tim.sandquist@gmail.com>
Date: Wed, 15 Dec 2021 07:51:51 -0600
Subject: [PATCH 2/2] gns3-gui: update to 2.2.28.

---
 srcpkgs/gns3-gui/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gns3-gui/template b/srcpkgs/gns3-gui/template
index fb0b5d198308..09e7adabbed2 100644
--- a/srcpkgs/gns3-gui/template
+++ b/srcpkgs/gns3-gui/template
@@ -1,6 +1,6 @@
 # Template file for 'gns3-gui'
 pkgname=gns3-gui
-version=2.2.27
+version=2.2.28
 revision=1
 build_style=python3-module
 # Skip tests/test_link.py::test_create_link test that wasn't updated with the code https://github.com/GNS3/gns3-gui/commit/545a9f53
@@ -14,8 +14,9 @@ short_desc="Graphical Network Simulator 3 - GUI"
 maintainer="Tim Sandquist <tim.sandquist@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://gns3.com"
+changelog="https://raw.githubusercontent.com/GNS3/gns3-gui/master/CHANGELOG"
 distfiles="https://github.com/GNS3/${pkgname}/archive/v${version}.tar.gz"
-checksum=c5afadd2932703c38fb6d479be6966af65787ddc6abcb3f9b7c0b3f5722e0fd5
+checksum=8b6e5df17ae472bf3525e1adbb1a0d2c6f170df270f802163c00c02d75cc4ced
 
 post_install() {
 	vinstall gns3-gui.desktop 644 usr/share/applications

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (11 preceding siblings ...)
  2021-12-16  1:08 ` [PR PATCH] [Updated] " tsndqst
@ 2021-12-16  5:03 ` tsndqst
  2021-12-16 10:46 ` paper42
                   ` (2 subsequent siblings)
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-16  5:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770226666

Comment:
https://github.com/GNS3/gns3-gui/pull/3273 and it's already merged! I should have made that PR a while ago.

I'm debating whether to replicate the change in a patch or continue to skip the test until 2.2.29.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (12 preceding siblings ...)
  2021-12-16  5:03 ` [PR REVIEW] " tsndqst
@ 2021-12-16 10:46 ` paper42
  2021-12-16 12:39 ` tsndqst
  2021-12-16 22:15 ` [PR PATCH] [Merged]: " paper42
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-16 10:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770423857

Comment:
Thanks, that's entirely up to you, both solutions sound great.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR REVIEW] GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (13 preceding siblings ...)
  2021-12-16 10:46 ` paper42
@ 2021-12-16 12:39 ` tsndqst
  2021-12-16 22:15 ` [PR PATCH] [Merged]: " paper42
  15 siblings, 0 replies; 17+ messages in thread
From: tsndqst @ 2021-12-16 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by tsndqst on void-packages repository

https://github.com/void-linux/void-packages/pull/34556#discussion_r770502801

Comment:
I'll leave it the way it is.  I'll remove the `make_check_args` once the fix is in a released version.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [PR PATCH] [Merged]: GNS3 2.2.28
  2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
                   ` (14 preceding siblings ...)
  2021-12-16 12:39 ` tsndqst
@ 2021-12-16 22:15 ` paper42
  15 siblings, 0 replies; 17+ messages in thread
From: paper42 @ 2021-12-16 22:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

There's a merged pull request on the void-packages repository

GNS3 2.2.28
https://github.com/void-linux/void-packages/pull/34556

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-12-16 22:15 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 13:55 [PR PATCH] GNS3 2.2.28 tsndqst
2021-12-15 22:18 ` [PR REVIEW] " paper42
2021-12-15 22:20 ` paper42
2021-12-15 22:20 ` paper42
2021-12-15 22:22 ` [PR PATCH] [Updated] " tsndqst
2021-12-15 22:23 ` [PR REVIEW] " tsndqst
2021-12-15 22:31 ` tsndqst
2021-12-15 22:33 ` [PR PATCH] [Updated] " tsndqst
2021-12-15 22:33 ` [PR REVIEW] " tsndqst
2021-12-15 22:34 ` tsndqst
2021-12-15 23:03 ` paper42
2021-12-16  1:05 ` tsndqst
2021-12-16  1:08 ` [PR PATCH] [Updated] " tsndqst
2021-12-16  5:03 ` [PR REVIEW] " tsndqst
2021-12-16 10:46 ` paper42
2021-12-16 12:39 ` tsndqst
2021-12-16 22:15 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).