Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] plasma-workspace: make krunner use the proper cwd
@ 2022-02-10  4:29 classabbyamp
  2022-02-10 15:50 ` Vistaus
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: classabbyamp @ 2022-02-10  4:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1512 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages krunner-cwd
https://github.com/void-linux/void-packages/pull/35500

plasma-workspace: make krunner use the proper cwd
see:
- https://bugs.kde.org/show_bug.cgi?id=432975
- https://bugs.gentoo.org/767478
- https://gitweb.gentoo.org/proj/kde.git/tree/kde-plasma/plasma-workspace/files/plasma-workspace-5.22.5-krunner-cwd-at-home.patch?id=fdf904d0dbe13b7f91cb00d9720bc53e4b0f53fc

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35500.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-krunner-cwd-35500.patch --]
[-- Type: text/x-diff, Size: 2266 bytes --]

From 4b7b3ec15c5c754065e15d7f3bb63614993d450b Mon Sep 17 00:00:00 2001
From: classabbyamp <dev@kb6.ee>
Date: Wed, 9 Feb 2022 23:27:08 -0500
Subject: [PATCH] plasma-workspace: make krunner use the proper cwd

see:
- https://bugs.kde.org/show_bug.cgi?id=432975
- https://bugs.gentoo.org/767478
- https://gitweb.gentoo.org/proj/kde.git/tree/kde-plasma/plasma-workspace/files/plasma-workspace-5.22.5-krunner-cwd-at-home.patch?id=fdf904d0dbe13b7f91cb00d9720bc53e4b0f53fc
---
 .../patches/fix-krunner-cwd.patch             | 31 +++++++++++++++++++
 srcpkgs/plasma-workspace/template             |  2 +-
 2 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/plasma-workspace/patches/fix-krunner-cwd.patch

diff --git a/srcpkgs/plasma-workspace/patches/fix-krunner-cwd.patch b/srcpkgs/plasma-workspace/patches/fix-krunner-cwd.patch
new file mode 100644
index 000000000000..82c010859b01
--- /dev/null
+++ b/srcpkgs/plasma-workspace/patches/fix-krunner-cwd.patch
@@ -0,0 +1,31 @@
+Commit 7ca34e0baa7fa65efc929eee5b6b0c3d2104db8e already reverted one
+change that caused the cwd of all apps spawned by krunner to
+erroneously be set to the root dir.
+
+That regressions is back so it's more robust to fix in within krunner.
+
+Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
+---
+ krunner/main.cpp | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/krunner/main.cpp b/krunner/main.cpp
+index 4593687ca..fa4a62ac4 100644
+--- a/krunner/main.cpp
++++ b/krunner/main.cpp
+@@ -12,6 +12,7 @@
+ #include <QDBusConnection>
+ #include <QDBusMessage>
+ #include <QDebug>
++#include <QDir>
+ #include <QQuickWindow>
+ #include <QSessionManager>
+ #include <QUrl>
+@@ -112,5 +113,6 @@ int main(int argc, char **argv)
+         }
+     });
+ 
++    QDir::setCurrent(QDir::homePath());
+     return app.exec();
+ }
+
diff --git a/srcpkgs/plasma-workspace/template b/srcpkgs/plasma-workspace/template
index 373f0e7f5ee3..aa0f67743bea 100644
--- a/srcpkgs/plasma-workspace/template
+++ b/srcpkgs/plasma-workspace/template
@@ -1,7 +1,7 @@
 # Template file for 'plasma-workspace'
 pkgname=plasma-workspace
 version=5.23.5
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF
  -DWaylandScanner_EXECUTABLE=/usr/bin/wayland-scanner

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: plasma-workspace: make krunner use the proper cwd
  2022-02-10  4:29 [PR PATCH] plasma-workspace: make krunner use the proper cwd classabbyamp
@ 2022-02-10 15:50 ` Vistaus
  2022-02-10 15:51 ` Vistaus
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Vistaus @ 2022-02-10 15:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by Vistaus on void-packages repository

https://github.com/void-linux/void-packages/pull/35500#issuecomment-1035081307

Comment:
Isn't it better to include this alongside a Plasma 5.24 PR now that 5.24 is officially released? Makes more sense to do the full upgrade including this fix, rather than patching the now slightly outdated 5.23 package. IMHO.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: plasma-workspace: make krunner use the proper cwd
  2022-02-10  4:29 [PR PATCH] plasma-workspace: make krunner use the proper cwd classabbyamp
  2022-02-10 15:50 ` Vistaus
@ 2022-02-10 15:51 ` Vistaus
  2022-02-10 20:23 ` classabbyamp
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Vistaus @ 2022-02-10 15:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by Vistaus on void-packages repository

https://github.com/void-linux/void-packages/pull/35500#issuecomment-1035081307

Comment:
Isn't it better to include this in a Plasma 5.24 PR now that 5.24 is officially released? Makes more sense to do the full upgrade including this fix, rather than patching the now slightly outdated 5.23 package. IMHO.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: plasma-workspace: make krunner use the proper cwd
  2022-02-10  4:29 [PR PATCH] plasma-workspace: make krunner use the proper cwd classabbyamp
  2022-02-10 15:50 ` Vistaus
  2022-02-10 15:51 ` Vistaus
@ 2022-02-10 20:23 ` classabbyamp
  2022-02-10 21:33 ` Johnnynator
  2022-02-15 20:48 ` [PR PATCH] [Closed]: " Johnnynator
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-02-10 20:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/35500#issuecomment-1035464183

Comment:
No one has done a plasma 5.24 PR yet and I am not the maintainer, so I did one based on the current package.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: plasma-workspace: make krunner use the proper cwd
  2022-02-10  4:29 [PR PATCH] plasma-workspace: make krunner use the proper cwd classabbyamp
                   ` (2 preceding siblings ...)
  2022-02-10 20:23 ` classabbyamp
@ 2022-02-10 21:33 ` Johnnynator
  2022-02-15 20:48 ` [PR PATCH] [Closed]: " Johnnynator
  4 siblings, 0 replies; 6+ messages in thread
From: Johnnynator @ 2022-02-10 21:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/35500#issuecomment-1035542669

Comment:
I will merge this together with plasma 5.24 this weekended.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: plasma-workspace: make krunner use the proper cwd
  2022-02-10  4:29 [PR PATCH] plasma-workspace: make krunner use the proper cwd classabbyamp
                   ` (3 preceding siblings ...)
  2022-02-10 21:33 ` Johnnynator
@ 2022-02-15 20:48 ` Johnnynator
  4 siblings, 0 replies; 6+ messages in thread
From: Johnnynator @ 2022-02-15 20:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

There's a closed pull request on the void-packages repository

plasma-workspace: make krunner use the proper cwd
https://github.com/void-linux/void-packages/pull/35500

Description:
see:
- https://bugs.kde.org/show_bug.cgi?id=432975
- https://bugs.gentoo.org/767478
- https://gitweb.gentoo.org/proj/kde.git/tree/kde-plasma/plasma-workspace/files/plasma-workspace-5.22.5-krunner-cwd-at-home.patch?id=fdf904d0dbe13b7f91cb00d9720bc53e4b0f53fc

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-15 20:48 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10  4:29 [PR PATCH] plasma-workspace: make krunner use the proper cwd classabbyamp
2022-02-10 15:50 ` Vistaus
2022-02-10 15:51 ` Vistaus
2022-02-10 20:23 ` classabbyamp
2022-02-10 21:33 ` Johnnynator
2022-02-15 20:48 ` [PR PATCH] [Closed]: " Johnnynator

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).