[PR PATCH] immortal: update to 0.24.4.

[PR PATCH] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages immortal
https://github.com/void-linux/void-packages/pull/35651

immortal: update to 0.24.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-immortal-35651.patch --]
[-- Type: text/x-diff, Size: 1024 bytes --]

From 1d2b2c5cbd64ddc4d5edb9aba9a3ab3b341e0ee3 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Wed, 16 Feb 2022 16:20:51 +0100
Subject: [PATCH] immortal: update to 0.24.4.

---
 srcpkgs/immortal/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/immortal/template b/srcpkgs/immortal/template
index 0e97e1abef88..88e9f265c083 100644
--- a/srcpkgs/immortal/template
+++ b/srcpkgs/immortal/template
@@ -1,6 +1,6 @@
 # Template file for 'immortal'
 pkgname=immortal
-version=0.24.3
+version=0.24.4
 revision=1
 build_style=go
 go_import_path=github.com/immortal/immortal
@@ -13,7 +13,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/immortal/immortal"
 distfiles="https://github.com/immortal/immortal/archive/${version}.tar.gz"
-checksum=e31d5afb9028fb5047b5a2cc5f96c844f6480d600643a12075550f497e65f5cb
+checksum=a343581dbe58fb0faa1c65b233a067820d8d5ecefc9726da5ad3ef979a2a0b08
 
 do_check() {
 	go test -v

Re: [PR PATCH] [Updated] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages immortal
https://github.com/void-linux/void-packages/pull/35651

immortal: update to 0.24.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-immortal-35651.patch --]
[-- Type: text/x-diff, Size: 1066 bytes --]

From 157da99e91da87486bb14925c5f360c52da9c51e Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Wed, 16 Feb 2022 16:20:51 +0100
Subject: [PATCH] immortal: update to 0.24.4.

---
 srcpkgs/immortal/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/immortal/template b/srcpkgs/immortal/template
index 0e97e1abef88..de9724b5ed13 100644
--- a/srcpkgs/immortal/template
+++ b/srcpkgs/immortal/template
@@ -1,6 +1,6 @@
 # Template file for 'immortal'
 pkgname=immortal
-version=0.24.3
+version=0.24.4
 revision=1
 build_style=go
 go_import_path=github.com/immortal/immortal
@@ -13,7 +13,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/immortal/immortal"
 distfiles="https://github.com/immortal/immortal/archive/${version}.tar.gz"
-checksum=e31d5afb9028fb5047b5a2cc5f96c844f6480d600643a12075550f497e65f5cb
+checksum=a343581dbe58fb0faa1c65b233a067820d8d5ecefc9726da5ad3ef979a2a0b08
+make_check=ci-skip # tests pass locally
 
 do_check() {
 	go test -v

Re: [PR REVIEW] immortal: update to 0.24.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35651#discussion_r810550277

Comment:
That's not a reason, ci-skip already tells us that the tests pass locally.

Re: [PR PATCH] [Updated] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages immortal
https://github.com/void-linux/void-packages/pull/35651

immortal: update to 0.24.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-immortal-35651.patch --]
[-- Type: text/x-diff, Size: 1045 bytes --]

From 02db7f2d14399fafecfff5783a4573c1ec026c19 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Wed, 16 Feb 2022 16:20:51 +0100
Subject: [PATCH] immortal: update to 0.24.4.

---
 srcpkgs/immortal/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/immortal/template b/srcpkgs/immortal/template
index 0e97e1abef88..4a7214ff9593 100644
--- a/srcpkgs/immortal/template
+++ b/srcpkgs/immortal/template
@@ -1,6 +1,6 @@
 # Template file for 'immortal'
 pkgname=immortal
-version=0.24.3
+version=0.24.4
 revision=1
 build_style=go
 go_import_path=github.com/immortal/immortal
@@ -13,7 +13,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/immortal/immortal"
 distfiles="https://github.com/immortal/immortal/archive/${version}.tar.gz"
-checksum=e31d5afb9028fb5047b5a2cc5f96c844f6480d600643a12075550f497e65f5cb
+checksum=a343581dbe58fb0faa1c65b233a067820d8d5ecefc9726da5ad3ef979a2a0b08
+make_check=ci-skip
 
 do_check() {
 	go test -v

Re: [PR PATCH] [Updated] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages immortal
https://github.com/void-linux/void-packages/pull/35651

immortal: update to 0.24.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-immortal-35651.patch --]
[-- Type: text/x-diff, Size: 1046 bytes --]

From ace671a81c43cabd36c27906b1fb4a5f4f12042d Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Wed, 16 Feb 2022 16:20:51 +0100
Subject: [PATCH] immortal: update to 0.24.4.

---
 srcpkgs/immortal/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/immortal/template b/srcpkgs/immortal/template
index 0e97e1abef88..e9528cb1681a 100644
--- a/srcpkgs/immortal/template
+++ b/srcpkgs/immortal/template
@@ -1,6 +1,6 @@
 # Template file for 'immortal'
 pkgname=immortal
-version=0.24.3
+version=0.24.4
 revision=1
 build_style=go
 go_import_path=github.com/immortal/immortal
@@ -13,7 +13,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/immortal/immortal"
 distfiles="https://github.com/immortal/immortal/archive/${version}.tar.gz"
-checksum=e31d5afb9028fb5047b5a2cc5f96c844f6480d600643a12075550f497e65f5cb
+checksum=a343581dbe58fb0faa1c65b233a067820d8d5ecefc9726da5ad3ef979a2a0b08
+#make_check=ci-skip
 
 do_check() {
 	go test -v

Re: [PR REVIEW] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/35651#discussion_r810551892

Comment:
Oh thats right... I've enabled them now. How would you describe this?

Re: [PR REVIEW] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/35651#discussion_r810552388

Comment:
or should i just `make_check=ci-skip` without a comment?

Re: [PR PATCH] [Updated] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is an updated pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages immortal
https://github.com/void-linux/void-packages/pull/35651

immortal: update to 0.24.4.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35651.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-immortal-35651.patch --]
[-- Type: text/x-diff, Size: 1084 bytes --]

From f9b4e03f5784d4e5190f68921316ddfda38ad7b0 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Wed, 16 Feb 2022 16:20:51 +0100
Subject: [PATCH] immortal: update to 0.24.4.

---
 srcpkgs/immortal/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/immortal/template b/srcpkgs/immortal/template
index 0e97e1abef88..76c1d8c6dabd 100644
--- a/srcpkgs/immortal/template
+++ b/srcpkgs/immortal/template
@@ -1,6 +1,6 @@
 # Template file for 'immortal'
 pkgname=immortal
-version=0.24.3
+version=0.24.4
 revision=1
 build_style=go
 go_import_path=github.com/immortal/immortal
@@ -13,7 +13,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://github.com/immortal/immortal"
 distfiles="https://github.com/immortal/immortal/archive/${version}.tar.gz"
-checksum=e31d5afb9028fb5047b5a2cc5f96c844f6480d600643a12075550f497e65f5cb
+checksum=a343581dbe58fb0faa1c65b233a067820d8d5ecefc9726da5ad3ef979a2a0b08
+make_check=ci-skip # some tests fail when running as root
 
 do_check() {
 	go test -v

Re: [PR REVIEW] immortal: update to 0.24.4.

[tibequadorian]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/pull/35651#discussion_r811487205

Comment:
Updated it now :)

Re: [PR REVIEW] immortal: update to 0.24.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35651#discussion_r813396605

Comment:
Tests also fail locally for me, so it shouldn't be ci-skip and it's not caused by being root.

Re: [PR REVIEW] immortal: update to 0.24.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35651#discussion_r813403935

Comment:
And now they pass after a clean.

Re: [PR PATCH] [Merged]: immortal: update to 0.24.4.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

There's a merged pull request on the void-packages repository

immortal: update to 0.24.4.
https://github.com/void-linux/void-packages/pull/35651

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->