[PR PATCH] gstreamer1, gstreamer1-devel: clean up (make)depends

[PR PATCH] gstreamer1, gstreamer1-devel: clean up (make)depends

[ftrvxmtrx]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

There is a new pull request by ftrvxmtrx against master on the void-packages repository

https://github.com/ftrvxmtrx/void-packages gstreamer1-bash-incompletion
https://github.com/void-linux/void-packages/pull/35781

gstreamer1, gstreamer1-devel: clean up (make)depends
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (aarch64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/35781.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gstreamer1-bash-incompletion-35781.patch --]
[-- Type: text/x-diff, Size: 1545 bytes --]

From 949996b211ab22f0c6e184084218ca3ef239aef8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sigrid=20Solveig=20Hafl=C3=ADnud=C3=B3ttir?=
 <ftrvxmtrx@gmail.com>
Date: Tue, 22 Feb 2022 16:49:10 +0100
Subject: [PATCH] gstreamer1, gstreamer1-devel: clean up (make)depends

---
 srcpkgs/gstreamer1/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gstreamer1/template b/srcpkgs/gstreamer1/template
index 9c3f8bbde9bb..cc540feaf0b7 100644
--- a/srcpkgs/gstreamer1/template
+++ b/srcpkgs/gstreamer1/template
@@ -1,7 +1,7 @@
 # Template file for 'gstreamer1'
 pkgname=gstreamer1
 version=1.18.5
-revision=1
+revision=2
 wrksrc="gstreamer-${version}"
 build_style=meson
 build_helper="gir"
@@ -10,8 +10,7 @@ configure_args="-Dptp-helper-permissions=capabilities
  -Dintrospection=$(vopt_if gir enabled disabled)"
 hostmakedepends="gettext pkg-config flex python3 docbook-xsl glib-devel
  libcap-progs"
-makedepends="libxml2-devel libglib-devel gtk+3-devel libcap-devel
- bash-completion"
+makedepends="libxml2-devel libglib-devel libcap-devel bash-completion"
 checkdepends="gsl-devel gmp-devel valgrind-devel"
 short_desc="Core GStreamer libraries and elements (1.x)"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -33,7 +32,7 @@ build_options="gir"
 build_options_default="gir"
 
 gstreamer1-devel_package() {
-	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	depends="libglib-devel ${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: gstreamer1, gstreamer1-devel: clean up (make)depends

[paper42]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35781#issuecomment-1049340732

Comment:
We usually don't mention subpackages in the commit message, so it should be something like `gstreamer1: clean up (build)deps`

Re: [PR PATCH] [Updated] gstreamer1, gstreamer1-devel: clean up (make)depends

[ftrvxmtrx]

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

There is an updated pull request by ftrvxmtrx against master on the void-packages repository

https://github.com/ftrvxmtrx/void-packages gstreamer1-bash-incompletion
https://github.com/void-linux/void-packages/pull/35781

gstreamer1, gstreamer1-devel: clean up (make)depends
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (aarch64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/35781.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gstreamer1-bash-incompletion-35781.patch --]
[-- Type: text/x-diff, Size: 1527 bytes --]

From eaad25a3a85df552ed4aec8a24e85a67e9b1daca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sigrid=20Solveig=20Hafl=C3=ADnud=C3=B3ttir?=
 <ftrvxmtrx@gmail.com>
Date: Tue, 22 Feb 2022 16:49:10 +0100
Subject: [PATCH] gstreamer1: clean up (make)depends

---
 srcpkgs/gstreamer1/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gstreamer1/template b/srcpkgs/gstreamer1/template
index 9c3f8bbde9bb..cc540feaf0b7 100644
--- a/srcpkgs/gstreamer1/template
+++ b/srcpkgs/gstreamer1/template
@@ -1,7 +1,7 @@
 # Template file for 'gstreamer1'
 pkgname=gstreamer1
 version=1.18.5
-revision=1
+revision=2
 wrksrc="gstreamer-${version}"
 build_style=meson
 build_helper="gir"
@@ -10,8 +10,7 @@ configure_args="-Dptp-helper-permissions=capabilities
  -Dintrospection=$(vopt_if gir enabled disabled)"
 hostmakedepends="gettext pkg-config flex python3 docbook-xsl glib-devel
  libcap-progs"
-makedepends="libxml2-devel libglib-devel gtk+3-devel libcap-devel
- bash-completion"
+makedepends="libxml2-devel libglib-devel libcap-devel bash-completion"
 checkdepends="gsl-devel gmp-devel valgrind-devel"
 short_desc="Core GStreamer libraries and elements (1.x)"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -33,7 +32,7 @@ build_options="gir"
 build_options_default="gir"
 
 gstreamer1-devel_package() {
-	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
+	depends="libglib-devel ${sourcepkg}>=${version}_${revision}"
 	short_desc+=" - development files"
 	pkg_install() {
 		vmove usr/include

Re: [PR PATCH] [Merged]: gstreamer1: clean up (make)depends

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There's a merged pull request on the void-packages repository

gstreamer1: clean up (make)depends
https://github.com/void-linux/void-packages/pull/35781

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (aarch64-musl)