Github messages for voidlinux
 help / color / mirror / Atom feed
From: jbenden <jbenden@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] nyxt: remove runtime deps on *-devel
Date: Sun, 27 Feb 2022 18:23:09 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35877@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 707 bytes --]

There is a new pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages nyxt-fixup
https://github.com/void-linux/void-packages/pull/35877

nyxt: remove runtime deps on *-devel
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

#### About

The current package requires shared libraries referenced inside development packages (`*-devel` because the libraries are referred to by `libXYZ.so` filenames).

This patch fixes this small defect.

A patch file from https://github.com/void-linux/void-packages/pull/35877.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nyxt-fixup-35877.patch --]
[-- Type: text/x-diff, Size: 2890 bytes --]

From ec45269a9d9ec97c17b17f2f739f8ea040cdf3c0 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Sun, 27 Feb 2022 10:15:07 -0700
Subject: [PATCH] nyxt: remove runtime deps on *-devel

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/nyxt/patches/001-libfixposix.patch | 12 ++++++++++++
 srcpkgs/nyxt/patches/002-webkit2gtk.patch  | 14 ++++++++++++++
 srcpkgs/nyxt/template                      |  4 ++--
 3 files changed, 28 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/nyxt/patches/001-libfixposix.patch
 create mode 100644 srcpkgs/nyxt/patches/002-webkit2gtk.patch

diff --git a/srcpkgs/nyxt/patches/001-libfixposix.patch b/srcpkgs/nyxt/patches/001-libfixposix.patch
new file mode 100644
index 000000000000..23ef9da26442
--- /dev/null
+++ b/srcpkgs/nyxt/patches/001-libfixposix.patch
@@ -0,0 +1,12 @@
+--- a/_build/iolib/src/syscalls/ffi-functions-unix.lisp.orig	2022-02-27 09:44:00.327307802 -0700
++++ b/_build/iolib/src/syscalls/ffi-functions-unix.lisp	2022-02-27 09:48:30.875539336 -0700
+@@ -12,7 +12,8 @@
+ (eval-when (:compile-toplevel :load-toplevel :execute)
+   (define-foreign-library
+       (libfixposix :canary "lfp_buildinfo")
+-    (t (:default "libfixposix")))
++    (:unix "libfixposix.so.3")
++    (t (:default "libfixposix")))
+   (load-foreign-library 'libfixposix))
+ \f
+ 
diff --git a/srcpkgs/nyxt/patches/002-webkit2gtk.patch b/srcpkgs/nyxt/patches/002-webkit2gtk.patch
new file mode 100644
index 000000000000..5a0fe2e923d3
--- /dev/null
+++ b/srcpkgs/nyxt/patches/002-webkit2gtk.patch
@@ -0,0 +1,14 @@
+--- a/_build/cl-webkit/webkit2/webkit2.init.lisp	2022-01-14 03:22:05.000000000 -0700
++++ b/_build/cl-webkit/webkit2/webkit2.init.lisp	2022-02-27 09:59:29.175938024 -0700
+@@ -18,9 +18,9 @@
+               "libwebkit2gtk-4.0.37.dylib"
+               "libwebkit2gtk-4.0.dylib"))
+     (:unix (:or "libwebkit2gtk-4.1.so"
+-                "libwebkit2gtk-4.0.so"
+                 ;; Fedora only has this one?
+-                "libwebkit2gtk-4.0.so.37")))
++                "libwebkit2gtk-4.0.so.37"
++                "libwebkit2gtk-4.0.so")))
+   (use-foreign-library libwebkit2))
+ 
+ (defcfun "webkit_get_major_version" :int)
diff --git a/srcpkgs/nyxt/template b/srcpkgs/nyxt/template
index 8332e1286d2c..9801137e4bad 100644
--- a/srcpkgs/nyxt/template
+++ b/srcpkgs/nyxt/template
@@ -6,8 +6,8 @@ create_wrksrc=yes
 build_style=gnu-makefile
 make_build_target=all
 hostmakedepends="sbcl git"
-makedepends="webkit2gtk-devel libfixposix-devel libgirepository-devel"
-depends="dbus xclip enchant2 webkit2gtk-devel libfixposix-devel libgirepository-devel"
+makedepends="webkit2gtk libfixposix-devel libgirepository-devel"
+depends="dbus xclip enchant2 webkit2gtk libfixposix libgirepository"
 short_desc="Keyboard-oriented, extensible web-browser"
 maintainer="0x0f0f0f <sudo-woodo3@protonmail.com>"
 license="BSD-3-Clause"

             reply	other threads:[~2022-02-27 17:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-27 17:23 jbenden [this message]
2022-03-17 15:52 ` [PR REVIEW] " sgn
2022-03-17 15:52 ` sgn
2022-03-17 18:40 ` [PR PATCH] [Updated] " jbenden
2022-03-17 21:06 ` [PR REVIEW] " jbenden
2022-03-18  0:28 ` sgn
2022-03-18  0:30 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35877@inbox.vuxu.org \
    --to=jbenden@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).