From: kawaiiamber <kawaiiamber@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] xbps-src: consistent source style
Date: Sun, 27 Feb 2022 19:05:51 +0100 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35878@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
There is a new pull request by kawaiiamber against master on the void-packages repository
https://github.com/kawaiiamber/void-packages xbps-src
https://github.com/void-linux/void-packages/pull/35878
xbps-src: consistent source style
On lines: 442, 458, 700, 849, and 873 - the `. FILE` style is used to source in a file. As far as I can tell, `. FILE` and `source FILE` is exactly the same. If `.` is used everywhere else, then it seems `source` should be changed to `.` for consistency unless there is a difference I'm not aware of.
A patch file from https://github.com/void-linux/void-packages/pull/35878.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xbps-src-35878.patch --]
[-- Type: text/x-diff, Size: 997 bytes --]
From 805a6dfb0cbe55d9d4dd82e0391edba0e0664d8e Mon Sep 17 00:00:00 2001
From: KawaiiAmber <japaneselearning101@gmail.com>
Date: Sun, 27 Feb 2022 11:07:07 -0700
Subject: [PATCH] xbps-src: consistent source style
---
xbps-src | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xbps-src b/xbps-src
index ff249015ed02..4184997bbfa2 100755
--- a/xbps-src
+++ b/xbps-src
@@ -938,12 +938,12 @@ case "$XBPS_TARGET" in
;;
show-var)
for f in ${XBPS_COMMONDIR}/environment/setup/*.sh; do
- source $f
+ . $f
done
if [ "$XBPS_CROSS_BUILD" ]; then
- source ${XBPS_COMMONDIR}/cross-profiles/${XBPS_CROSS_BUILD}.sh
+ . ${XBPS_COMMONDIR}/cross-profiles/${XBPS_CROSS_BUILD}.sh
else
- source ${XBPS_COMMONDIR}/build-profiles/${XBPS_MACHINE}.sh
+ . ${XBPS_COMMONDIR}/build-profiles/${XBPS_MACHINE}.sh
fi
eval value="\${$XBPS_TARGET_PKG}"
echo $value
next reply other threads:[~2022-02-27 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 18:05 kawaiiamber [this message]
2022-02-27 18:06 ` [PR PATCH] [Updated] " kawaiiamber
2022-06-26 2:17 ` github-actions
2022-06-26 10:04 ` kawaiiamber
2022-09-26 2:15 ` github-actions
2022-10-11 2:14 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35878@inbox.vuxu.org \
--to=kawaiiamber@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).