Github messages for voidlinux
 help / color / mirror / Atom feed
From: ninewise <ninewise@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] spotify-qt: add qt5-svg dependency
Date: Tue, 01 Mar 2022 23:44:46 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35911@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

There is a new pull request by ninewise against master on the void-packages repository

https://github.com/ninewise/void-packages-1 fix/spotify-qt
https://github.com/void-linux/void-packages/pull/35911

spotify-qt: add qt5-svg dependency
While the application does run without this dependency, a GUI client without icons is barely usable.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)

A patch file from https://github.com/void-linux/void-packages/pull/35911.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix/spotify-qt-35911.patch --]
[-- Type: text/x-diff, Size: 844 bytes --]

From dac1f440790f75606107b3ea95ffedc4300bd57d Mon Sep 17 00:00:00 2001
From: Felix Van der Jeugt <felix.vanderjeugt@posteo.net>
Date: Tue, 1 Mar 2022 23:35:30 +0100
Subject: [PATCH] spotify-qt: add qt5-svg dependency

---
 srcpkgs/spotify-qt/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/spotify-qt/template b/srcpkgs/spotify-qt/template
index 0fb27d690f5d..aa30046a8778 100644
--- a/srcpkgs/spotify-qt/template
+++ b/srcpkgs/spotify-qt/template
@@ -1,10 +1,11 @@
 # Template file for 'spotify-qt'
 pkgname=spotify-qt
 version=3.8
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="pkg-config qt5-devel"
 makedepends="qt5-devel qt5-svg-devel"
+depends="qt5-svg"
 short_desc="Lightweight Spotify client using Qt"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="GPL-3.0-or-later"

             reply	other threads:[~2022-03-01 22:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 22:44 ninewise [this message]
2022-03-01 23:43 ` tibequadorian
2022-03-02  0:11 ` tibequadorian
2022-03-02  7:02 ` [PR PATCH] [Updated] " ninewise
2022-03-03 22:24 ` paper42
2022-03-03 22:31 ` [PR PATCH] [Merged]: " abenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35911@inbox.vuxu.org \
    --to=ninewise@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).