* [PR PATCH] google-chrome: add dependency to gtk+3
@ 2022-03-02 11:31 atk
2022-03-02 11:46 ` paper42
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: atk @ 2022-03-02 11:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
There is a new pull request by atk against master on the void-packages repository
https://github.com/atk/void-packages google-chrome-depends-update
https://github.com/void-linux/void-packages/pull/35918
google-chrome: add dependency to gtk+3
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35918.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-google-chrome-depends-update-35918.patch --]
[-- Type: text/x-diff, Size: 896 bytes --]
From 0f04d5169878209517406db678934ba3da0b1783 Mon Sep 17 00:00:00 2001
From: Alex Lohr <alex.lohr@logmein.com>
Date: Wed, 2 Mar 2022 12:32:03 +0100
Subject: [PATCH] google-chrome: add dependency to gtk+3
---
srcpkgs/google-chrome/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/google-chrome/template b/srcpkgs/google-chrome/template
index 51462abfebda..f50d9caa3464 100644
--- a/srcpkgs/google-chrome/template
+++ b/srcpkgs/google-chrome/template
@@ -1,10 +1,11 @@
# Template file for 'google-chrome'
pkgname=google-chrome
version=99.0.4844.51
-revision=1
+revision=2
_channel=stable
archs="x86_64"
hostmakedepends="curl tar xz python3 python3-html2text python3-setuptools"
+depends="gtk+3"
short_desc="Attempt at creating a safer, faster, and more stable browser"
maintainer="Michael Aldridge <maldridge@voidlinux.org>"
license="custom:chrome"
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: google-chrome: add dependency to gtk+3
2022-03-02 11:31 [PR PATCH] google-chrome: add dependency to gtk+3 atk
@ 2022-03-02 11:46 ` paper42
2022-03-02 12:35 ` [PR PATCH] [Closed]: " atk
2022-03-02 12:35 ` atk
2 siblings, 0 replies; 4+ messages in thread
From: paper42 @ 2022-03-02 11:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35918#issuecomment-1056838679
Comment:
I would prefer to merge #35916 from @yiz, so the commit can be attributed to the correct person.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Closed]: google-chrome: add dependency to gtk+3
2022-03-02 11:31 [PR PATCH] google-chrome: add dependency to gtk+3 atk
2022-03-02 11:46 ` paper42
@ 2022-03-02 12:35 ` atk
2022-03-02 12:35 ` atk
2 siblings, 0 replies; 4+ messages in thread
From: atk @ 2022-03-02 12:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
There's a closed pull request on the void-packages repository
google-chrome: add dependency to gtk+3
https://github.com/void-linux/void-packages/pull/35918
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: google-chrome: add dependency to gtk+3
2022-03-02 11:31 [PR PATCH] google-chrome: add dependency to gtk+3 atk
2022-03-02 11:46 ` paper42
2022-03-02 12:35 ` [PR PATCH] [Closed]: " atk
@ 2022-03-02 12:35 ` atk
2 siblings, 0 replies; 4+ messages in thread
From: atk @ 2022-03-02 12:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by atk on void-packages repository
https://github.com/void-linux/void-packages/pull/35918#issuecomment-1056881840
Comment:
Mistook his PR for an issue. Sorry, my fault.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-02 12:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 11:31 [PR PATCH] google-chrome: add dependency to gtk+3 atk
2022-03-02 11:46 ` paper42
2022-03-02 12:35 ` [PR PATCH] [Closed]: " atk
2022-03-02 12:35 ` atk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).