Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] podman: add runit service
@ 2022-03-11 21:43 lemmi
  2022-03-11 23:15 ` [PR REVIEW] " CameronNemo
                   ` (14 more replies)
  0 siblings, 15 replies; 16+ messages in thread
From: lemmi @ 2022-03-11 21:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

There is a new pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages podman
https://github.com/void-linux/void-packages/pull/36102

podman: add runit service
[Upstream Systemd service](https://github.com/containers/podman/blob/v4.0.2/contrib/systemd/system/podman.service.in) doesn't do anything special. `--time=0 unix:///var/run/docker.sock` is required, since we don't have socket activation.

A patch file from https://github.com/void-linux/void-packages/pull/36102.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-podman-36102.patch --]
[-- Type: text/x-diff, Size: 1660 bytes --]

From d3427f8b1003f7162d334b0df0ae82a06018890d Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Fri, 11 Mar 2022 22:37:26 +0100
Subject: [PATCH] podman: add runit service

---
 srcpkgs/podman/files/podman/log/run | 1 +
 srcpkgs/podman/files/podman/run     | 3 +++
 srcpkgs/podman/template             | 3 ++-
 3 files changed, 6 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/podman/files/podman/log/run
 create mode 100644 srcpkgs/podman/files/podman/run

diff --git a/srcpkgs/podman/files/podman/log/run b/srcpkgs/podman/files/podman/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/podman/files/podman/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/podman/files/podman/run b/srcpkgs/podman/files/podman/run
new file mode 100644
index 000000000000..c98a70437f84
--- /dev/null
+++ b/srcpkgs/podman/files/podman/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec podman --log-level info system service --time=0 unix:///var/run/docker.sock
diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index c719e4ca6057..b202bb9823d6 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -1,7 +1,7 @@
 # Template file for 'podman'
 pkgname=podman
 version=4.0.2
-revision=2
+revision=3
 build_style=go
 go_import_path="github.com/containers/podman/v4"
 go_package="${go_import_path}/cmd/podman ${go_import_path}/cmd/rootlessport"
@@ -34,4 +34,5 @@ post_install() {
 		vendor/github.com/containers/common/pkg/config/containers.conf \
 		>containers.cgfs.conf
 	vinstall containers.cgfs.conf 644 usr/share/containers containers.conf
+	vsv podman
 }

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR REVIEW] podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
@ 2022-03-11 23:15 ` CameronNemo
  2022-03-12 11:47 ` lemmi
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: CameronNemo @ 2022-03-11 23:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#discussion_r825186056

Comment:
why not leave the default socket location then add a conf file with OPTS?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
  2022-03-11 23:15 ` [PR REVIEW] " CameronNemo
@ 2022-03-12 11:47 ` lemmi
  2022-03-13  0:52 ` CameronNemo
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-12 11:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1065868620

Comment:
Oh, I thought the main point of the service **is** to replace docker. I never thought about starting the service for anything else. What would one use it for, if not for a docker replacement? 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
  2022-03-11 23:15 ` [PR REVIEW] " CameronNemo
  2022-03-12 11:47 ` lemmi
@ 2022-03-13  0:52 ` CameronNemo
  2022-03-13  0:58 ` lemmi
                   ` (11 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: CameronNemo @ 2022-03-13  0:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1065994668

Comment:
Hmm. Perhaps defaulting to the docker socket makes sense then. But having it configurable is good in my opinion. E.g. for those that want remote access. Also the log level could be configurable too.

So my recommendation is `OPTS="--log-level info unix:///var/run/docker.sock"` in a conf file then `exec podman system service --time=0 $OPTS` in the service.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (2 preceding siblings ...)
  2022-03-13  0:52 ` CameronNemo
@ 2022-03-13  0:58 ` lemmi
  2022-03-14 15:58 ` leahneukirchen
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-13  0:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1065995228

Comment:
I can live with that. I'd still love to hear from @leahneukirchen, what they think about it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (3 preceding siblings ...)
  2022-03-13  0:58 ` lemmi
@ 2022-03-14 15:58 ` leahneukirchen
  2022-03-16  3:58 ` the-maldridge
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: leahneukirchen @ 2022-03-14 15:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1066990917

Comment:
Imo the service should be used with `sudo podman --remote`, which defaults to `/run/podman/podman.sock`.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (4 preceding siblings ...)
  2022-03-14 15:58 ` leahneukirchen
@ 2022-03-16  3:58 ` the-maldridge
  2022-03-16  4:14 ` lemmi
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: the-maldridge @ 2022-03-16  3:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1068705848

Comment:
Hmm, perhaps we should have two services, because my intent was to use this to replace docker completely.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (5 preceding siblings ...)
  2022-03-16  3:58 ` the-maldridge
@ 2022-03-16  4:14 ` lemmi
  2022-03-16 14:38 ` leahneukirchen
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-16  4:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1068713331

Comment:
@the-maldridge yeah, I was thinking the same. 
I also had another look around. Seems like upstream suggests [this solution](https://github.com/containers/podman/blob/main/contrib/systemd/system/podman-docker.conf). They start `podman` with the default location, but provide a systemd config that creates a symlink from the `docker` default socket path to the `podman` socket path.
Maybe we could mimick that by providing a `podman` service with default options and optional config and a `podman-docker` service, that adds the symlink.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (6 preceding siblings ...)
  2022-03-16  4:14 ` lemmi
@ 2022-03-16 14:38 ` leahneukirchen
  2022-03-20 23:39 ` [PR PATCH] [Updated] " lemmi
                   ` (6 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: leahneukirchen @ 2022-03-16 14:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1069191506

Comment:
Note that podman starts the socket with hard-coded 0700 permissions, so it's only usable by root by default anyway.

If you want to "replace docker completely", I don't see the problem here as just using podman instead of docker (or even aliasing it) will work. From personal experience, I'd recommend not using the docker client to speak to a podman server if you can avoid it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Updated] podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (7 preceding siblings ...)
  2022-03-16 14:38 ` leahneukirchen
@ 2022-03-20 23:39 ` lemmi
  2022-03-20 23:40 ` lemmi
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-20 23:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

There is an updated pull request by lemmi against master on the void-packages repository

https://github.com/lemmi/void-packages podman
https://github.com/void-linux/void-packages/pull/36102

podman: add runit service
[Upstream Systemd service](https://github.com/containers/podman/blob/v4.0.2/contrib/systemd/system/podman.service.in) doesn't do anything special. `--time=0 unix:///var/run/docker.sock` is required, since we don't have socket activation.

A patch file from https://github.com/void-linux/void-packages/pull/36102.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-podman-36102.patch --]
[-- Type: text/x-diff, Size: 2588 bytes --]

From 57606372d0cda4cf4c68b3a4a3c2465dde8e611b Mon Sep 17 00:00:00 2001
From: lemmi <lemmi@nerd2nerd.org>
Date: Fri, 11 Mar 2022 22:37:26 +0100
Subject: [PATCH] podman: add runit service

---
 srcpkgs/podman/files/podman-docker/finish | 3 +++
 srcpkgs/podman/files/podman-docker/run    | 4 ++++
 srcpkgs/podman/files/podman/log/run       | 1 +
 srcpkgs/podman/files/podman/run           | 4 ++++
 srcpkgs/podman/template                   | 4 +++-
 5 files changed, 15 insertions(+), 1 deletion(-)
 create mode 100755 srcpkgs/podman/files/podman-docker/finish
 create mode 100755 srcpkgs/podman/files/podman-docker/run
 create mode 120000 srcpkgs/podman/files/podman/log/run
 create mode 100755 srcpkgs/podman/files/podman/run

diff --git a/srcpkgs/podman/files/podman-docker/finish b/srcpkgs/podman/files/podman-docker/finish
new file mode 100755
index 000000000000..884b37f53b63
--- /dev/null
+++ b/srcpkgs/podman/files/podman-docker/finish
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+[ "$(realpath /run/docker.sock)" = "/run/podman/podman.sock" ] && rm /run/docker.sock
diff --git a/srcpkgs/podman/files/podman-docker/run b/srcpkgs/podman/files/podman-docker/run
new file mode 100755
index 000000000000..3125a4f89ed9
--- /dev/null
+++ b/srcpkgs/podman/files/podman-docker/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+ln -sf /run/podman/podman.sock /run/docker.sock
+exec chpst -b podman-docker pause
diff --git a/srcpkgs/podman/files/podman/log/run b/srcpkgs/podman/files/podman/log/run
new file mode 120000
index 000000000000..3a5b4a586051
--- /dev/null
+++ b/srcpkgs/podman/files/podman/log/run
@@ -0,0 +1 @@
+/usr/bin/vlogger
\ No newline at end of file
diff --git a/srcpkgs/podman/files/podman/run b/srcpkgs/podman/files/podman/run
new file mode 100755
index 000000000000..8eb8f41752e4
--- /dev/null
+++ b/srcpkgs/podman/files/podman/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+
+[ -r ./conf ] && . ./conf
+exec podman --log-level info system service ${OPTS:---time=0} 2>&1
diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index c719e4ca6057..95e0531abad8 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -1,7 +1,7 @@
 # Template file for 'podman'
 pkgname=podman
 version=4.0.2
-revision=2
+revision=3
 build_style=go
 go_import_path="github.com/containers/podman/v4"
 go_package="${go_import_path}/cmd/podman ${go_import_path}/cmd/rootlessport"
@@ -34,4 +34,6 @@ post_install() {
 		vendor/github.com/containers/common/pkg/config/containers.conf \
 		>containers.cgfs.conf
 	vinstall containers.cgfs.conf 644 usr/share/containers containers.conf
+	vsv podman
+	vsv podman-docker
 }

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (8 preceding siblings ...)
  2022-03-20 23:39 ` [PR PATCH] [Updated] " lemmi
@ 2022-03-20 23:40 ` lemmi
  2022-03-27 23:16 ` the-maldridge
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-20 23:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1073374781

Comment:
As promised, I added the `podman` and `podman-docker` services. Tell me if that works for you this way.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (9 preceding siblings ...)
  2022-03-20 23:40 ` lemmi
@ 2022-03-27 23:16 ` the-maldridge
  2022-03-27 23:26 ` CameronNemo
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: the-maldridge @ 2022-03-27 23:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1080040767

Comment:
@leahneukirchen @CameronNemo I am happy with the changes in this PR, do you have any concerns before I merge this?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (10 preceding siblings ...)
  2022-03-27 23:16 ` the-maldridge
@ 2022-03-27 23:26 ` CameronNemo
  2022-03-28  0:11 ` Duncaen
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 16+ messages in thread
From: CameronNemo @ 2022-03-27 23:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1080043312

Comment:
LGTM

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (11 preceding siblings ...)
  2022-03-27 23:26 ` CameronNemo
@ 2022-03-28  0:11 ` Duncaen
  2022-03-28 14:36 ` [PR PATCH] [Merged]: " lemmi
  2022-03-28 14:36 ` lemmi
  14 siblings, 0 replies; 16+ messages in thread
From: Duncaen @ 2022-03-28  0:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1080052249

Comment:
I don't think the fake service for the symlink is necessary or required, why not just add that to the normal service?

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PR PATCH] [Merged]: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (12 preceding siblings ...)
  2022-03-28  0:11 ` Duncaen
@ 2022-03-28 14:36 ` lemmi
  2022-03-28 14:36 ` lemmi
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-28 14:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

There's a merged pull request on the void-packages repository

podman: add runit service
https://github.com/void-linux/void-packages/pull/36102

Description:
[Upstream Systemd service](https://github.com/containers/podman/blob/v4.0.2/contrib/systemd/system/podman.service.in) doesn't do anything special. `--time=0 unix:///var/run/docker.sock` is required, since we don't have socket activation.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: podman: add runit service
  2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
                   ` (13 preceding siblings ...)
  2022-03-28 14:36 ` [PR PATCH] [Merged]: " lemmi
@ 2022-03-28 14:36 ` lemmi
  14 siblings, 0 replies; 16+ messages in thread
From: lemmi @ 2022-03-28 14:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/36102#issuecomment-1080736334

Comment:
@Duncaen that was my first suggestion, but we decided against it.

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-03-28 14:36 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 21:43 [PR PATCH] podman: add runit service lemmi
2022-03-11 23:15 ` [PR REVIEW] " CameronNemo
2022-03-12 11:47 ` lemmi
2022-03-13  0:52 ` CameronNemo
2022-03-13  0:58 ` lemmi
2022-03-14 15:58 ` leahneukirchen
2022-03-16  3:58 ` the-maldridge
2022-03-16  4:14 ` lemmi
2022-03-16 14:38 ` leahneukirchen
2022-03-20 23:39 ` [PR PATCH] [Updated] " lemmi
2022-03-20 23:40 ` lemmi
2022-03-27 23:16 ` the-maldridge
2022-03-27 23:26 ` CameronNemo
2022-03-28  0:11 ` Duncaen
2022-03-28 14:36 ` [PR PATCH] [Merged]: " lemmi
2022-03-28 14:36 ` lemmi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).