[PR PATCH] kaffeine: plugins are not detected shlibs

[PR PATCH] kaffeine: plugins are not detected shlibs

[abenson]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

There is a new pull request by abenson against master on the void-packages repository

https://github.com/abenson/void-packages kaffeine_fix_shlibs
https://github.com/void-linux/void-packages/pull/36147

kaffeine: plugins are not detected shlibs
- I tested the changes in this PR: **briefly**

A patch file from https://github.com/void-linux/void-packages/pull/36147.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-kaffeine_fix_shlibs-36147.patch --]
[-- Type: text/x-diff, Size: 1129 bytes --]

From b4eb1924f844ce8791322650c669fc5f2e5267ec Mon Sep 17 00:00:00 2001
From: Andrew Benson <abenson+void@gmail.com>
Date: Mon, 14 Mar 2022 21:18:11 -0500
Subject: [PATCH] kaffeine: plugins are not detected shlibs

---
 srcpkgs/kaffeine/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kaffeine/template b/srcpkgs/kaffeine/template
index 6b9f2ac96c99..e0356c9ad552 100644
--- a/srcpkgs/kaffeine/template
+++ b/srcpkgs/kaffeine/template
@@ -1,7 +1,7 @@
 # Template file for 'kaffeine'
 pkgname=kaffeine
 version=2.0.18
-revision=2
+revision=3
 build_style=cmake
 configure_args="-DBUILD_TESTING=OFF"
 hostmakedepends="extra-cmake-modules gettext pkg-config kcoreaddons"
@@ -9,6 +9,8 @@ makedepends="kidletime-devel kio-devel ksolid-devel vlc-devel
  qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
  qt5-plugin-sqlite qt5-plugin-tds
  $(vopt_if dvb 'v4l-utils-devel eudev-libudev-devel')"
+depends="qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
+ qt5-plugin-sqlite qt5-plugin-tds"
 short_desc="KDE media player"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"

Re: [PR REVIEW] kaffeine: plugins are not detected shlibs

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New review comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/pull/36147#discussion_r826988636

Comment:
Just wondering, if certain dependencies are in `depends`, is there any reason to have them in `makedepends` too (as is the case here), or is it always redundant to do so?

Re: [PR REVIEW] kaffeine: plugins are not detected shlibs

[abenson]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/36147#discussion_r827108469

Comment:
`depends` are only added at runtime.  `makedepends` is added at compile-time.  `xbps-src` will detect if a package links to a package and will ensure its added to the runtime, but in the case of the plugins, it's likely not linked but uses them via `dlopen`.

Re: [PR PATCH] [Merged]: kaffeine: plugins are not detected shlibs

[abenson]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

There's a merged pull request on the void-packages repository

kaffeine: plugins are not detected shlibs
https://github.com/void-linux/void-packages/pull/36147

Description:
- I tested the changes in this PR: **briefly**