Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mosh: update to 20220318
@ 2022-03-18 19:30 jbenden
  2022-03-18 19:40 ` [PR REVIEW] " classabbyamp
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: jbenden @ 2022-03-18 19:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

There is a new pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages mosh-git
https://github.com/void-linux/void-packages/pull/36211

mosh: update to 20220318
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64`-`glibc`)

#### Notes
The upstream maintainer has seemingly vanished; therefore, a new release seems unlikely. As a workaround for the time being, switch to the git development branch.


A patch file from https://github.com/void-linux/void-packages/pull/36211.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mosh-git-36211.patch --]
[-- Type: text/x-diff, Size: 3369 bytes --]

From cb9d60339fcc57b984ca67c4300b4c67573a069d Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Fri, 18 Mar 2022 11:38:26 -0700
Subject: [PATCH] mosh: update to 20220318

Signed-off-by: Joseph Benden <joe@benden.us>
---
 .../fix-memory-blowup-on-large-paste.patch    | 35 -------------------
 srcpkgs/mosh/template                         | 15 +++++---
 2 files changed, 10 insertions(+), 40 deletions(-)
 delete mode 100644 srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch

diff --git a/srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch b/srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch
deleted file mode 100644
index efe3fd806969..000000000000
--- a/srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch
+++ /dev/null
@@ -1,35 +0,0 @@
-From 91de8901f5da04bc2abba3242164b0a330764d49 Mon Sep 17 00:00:00 2001
-From: John Hood <cgull@glup.org>
-Date: Sat, 6 May 2017 23:28:29 -0400
-Subject: [PATCH] Don't do prediction on large pastes into mosh-client.
-
-Fixes #482, memory use blowup on large pastes.  mosh is still pretty slow
-about copying pastes through, though.
----
- src/frontend/stmclient.cc | 10 +++++++++-
- 1 file changed, 9 insertions(+), 1 deletion(-)
-
-diff --git src/frontend/stmclient.cc src/frontend/stmclient.cc
-index 7eff0af3..450d068a 100644
---- a/src/frontend/stmclient.cc
-+++ b/src/frontend/stmclient.cc
-@@ -318,10 +318,18 @@ bool STMClient::process_user_input( int fd )
-   if ( !network->shutdown_in_progress() ) {
-     overlays.get_prediction_engine().set_local_frame_sent( network->get_sent_state_last() );
- 
-+    /* Don't predict for bulk data. */
-+    bool paste = bytes_read > 100;
-+    if ( paste ) {
-+      overlays.get_prediction_engine().reset();
-+    }
-+
-     for ( int i = 0; i < bytes_read; i++ ) {
-       char the_byte = buf[ i ];
- 
--      overlays.get_prediction_engine().new_user_byte( the_byte, local_framebuffer );
-+      if ( !paste ) {
-+	overlays.get_prediction_engine().new_user_byte( the_byte, local_framebuffer );
-+      }
- 
-       if ( quit_sequence_started ) {
- 	if ( the_byte == '.' ) { /* Quit sequence is Ctrl-^ . */
diff --git a/srcpkgs/mosh/template b/srcpkgs/mosh/template
index 3ff5d593ea64..f1b9a2fe3f47 100644
--- a/srcpkgs/mosh/template
+++ b/srcpkgs/mosh/template
@@ -1,19 +1,24 @@
 # Template file for 'mosh'
 pkgname=mosh
-version=1.3.2
-revision=24
+version=20220318
+revision=1
+_commit=dbe419d0e069df3fedc212d456449f64d0280c76
+_repo="https://github.com/mobile-shell/mosh"
+wrksrc="mosh-${_commit}"
 build_style=gnu-configure
-hostmakedepends="pkg-config protobuf"
+hostmakedepends="automake pkg-config protobuf"
 makedepends="ncurses-devel protobuf-devel libutempter-devel openssl-devel"
 depends="perl-IO-Tty"
 short_desc="Mobile shell, remote terminal application that allows roaming"
 maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://mosh.org/"
-distfiles="https://mosh.org/mosh-${version}.tar.gz"
-checksum=da600573dfa827d88ce114e0fed30210689381bbdcff543c931e4d6a2e851216
+distfiles="${_repo}/archive/${_commit}.tar.gz"
+checksum=49268ce1a81b251dffdd117dbc687d86cb80b18e3028019af5fddfa5c04ac1a9
 
 pre_configure() {
 	# make local.test always succeed. It fails due to missing X server in chroot.
 	printf "%s\n" "#!/bin/sh" ":" > src/tests/local.test
+
+	autoreconf -fi
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
@ 2022-03-18 19:40 ` classabbyamp
  2022-03-18 19:47 ` leahneukirchen
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: classabbyamp @ 2022-03-18 19:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36211#discussion_r830303401

Comment:
maybe a version like `1.3.2+20220318` or adding the commit hash or something would be better? If mosh gets another release in the future, I think that will break version comparison, as `20220318` is larger than `1`.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
  2022-03-18 19:40 ` [PR REVIEW] " classabbyamp
@ 2022-03-18 19:47 ` leahneukirchen
  2022-03-18 20:17 ` [PR PATCH] [Updated] " jbenden
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: leahneukirchen @ 2022-03-18 19:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/36211#issuecomment-1072748965

Comment:
This is not true, the original maintainer is easily available but doesn't have time to make a new release (nor is there an urgent reason to). Someone else stepped up and is preparing for a 1.4 afaiu: https://mailman.mit.edu/pipermail/mosh-devel/2022-February/001598.html

In any way, the version should be kept such that an upstream 1.4 release can supersede this, but I don't see a compelling reason to switch to a Git snapshot currently.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Updated] mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
  2022-03-18 19:40 ` [PR REVIEW] " classabbyamp
  2022-03-18 19:47 ` leahneukirchen
@ 2022-03-18 20:17 ` jbenden
  2022-03-18 20:18 ` [PR REVIEW] " jbenden
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jbenden @ 2022-03-18 20:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages mosh-git
https://github.com/void-linux/void-packages/pull/36211

mosh: update to 20220318
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64`-`glibc`)

#### Notes
The upstream maintainer has seemingly vanished; therefore, a new release seems unlikely. As a workaround for the time being, switch to the git development branch.


A patch file from https://github.com/void-linux/void-packages/pull/36211.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mosh-git-36211.patch --]
[-- Type: text/x-diff, Size: 3381 bytes --]

From 2c92091280d8192f99dd233152cdcc5716b0d9d1 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Fri, 18 Mar 2022 11:38:26 -0700
Subject: [PATCH] mosh: update to 1.3.2+20220318

Signed-off-by: Joseph Benden <joe@benden.us>
---
 .../fix-memory-blowup-on-large-paste.patch    | 35 -------------------
 srcpkgs/mosh/template                         | 15 +++++---
 2 files changed, 10 insertions(+), 40 deletions(-)
 delete mode 100644 srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch

diff --git a/srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch b/srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch
deleted file mode 100644
index efe3fd806969..000000000000
--- a/srcpkgs/mosh/patches/fix-memory-blowup-on-large-paste.patch
+++ /dev/null
@@ -1,35 +0,0 @@
-From 91de8901f5da04bc2abba3242164b0a330764d49 Mon Sep 17 00:00:00 2001
-From: John Hood <cgull@glup.org>
-Date: Sat, 6 May 2017 23:28:29 -0400
-Subject: [PATCH] Don't do prediction on large pastes into mosh-client.
-
-Fixes #482, memory use blowup on large pastes.  mosh is still pretty slow
-about copying pastes through, though.
----
- src/frontend/stmclient.cc | 10 +++++++++-
- 1 file changed, 9 insertions(+), 1 deletion(-)
-
-diff --git src/frontend/stmclient.cc src/frontend/stmclient.cc
-index 7eff0af3..450d068a 100644
---- a/src/frontend/stmclient.cc
-+++ b/src/frontend/stmclient.cc
-@@ -318,10 +318,18 @@ bool STMClient::process_user_input( int fd )
-   if ( !network->shutdown_in_progress() ) {
-     overlays.get_prediction_engine().set_local_frame_sent( network->get_sent_state_last() );
- 
-+    /* Don't predict for bulk data. */
-+    bool paste = bytes_read > 100;
-+    if ( paste ) {
-+      overlays.get_prediction_engine().reset();
-+    }
-+
-     for ( int i = 0; i < bytes_read; i++ ) {
-       char the_byte = buf[ i ];
- 
--      overlays.get_prediction_engine().new_user_byte( the_byte, local_framebuffer );
-+      if ( !paste ) {
-+	overlays.get_prediction_engine().new_user_byte( the_byte, local_framebuffer );
-+      }
- 
-       if ( quit_sequence_started ) {
- 	if ( the_byte == '.' ) { /* Quit sequence is Ctrl-^ . */
diff --git a/srcpkgs/mosh/template b/srcpkgs/mosh/template
index 3ff5d593ea64..69b55f9de3ed 100644
--- a/srcpkgs/mosh/template
+++ b/srcpkgs/mosh/template
@@ -1,19 +1,24 @@
 # Template file for 'mosh'
 pkgname=mosh
-version=1.3.2
-revision=24
+version=1.3.2+20220318
+revision=1
+_commit=dbe419d0e069df3fedc212d456449f64d0280c76
+_repo="https://github.com/mobile-shell/mosh"
+wrksrc="mosh-${_commit}"
 build_style=gnu-configure
-hostmakedepends="pkg-config protobuf"
+hostmakedepends="automake pkg-config protobuf"
 makedepends="ncurses-devel protobuf-devel libutempter-devel openssl-devel"
 depends="perl-IO-Tty"
 short_desc="Mobile shell, remote terminal application that allows roaming"
 maintainer="Nathan Owens <ndowens04@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://mosh.org/"
-distfiles="https://mosh.org/mosh-${version}.tar.gz"
-checksum=da600573dfa827d88ce114e0fed30210689381bbdcff543c931e4d6a2e851216
+distfiles="${_repo}/archive/${_commit}.tar.gz"
+checksum=49268ce1a81b251dffdd117dbc687d86cb80b18e3028019af5fddfa5c04ac1a9
 
 pre_configure() {
 	# make local.test always succeed. It fails due to missing X server in chroot.
 	printf "%s\n" "#!/bin/sh" ":" > src/tests/local.test
+
+	autoreconf -fi
 }

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
                   ` (2 preceding siblings ...)
  2022-03-18 20:17 ` [PR PATCH] [Updated] " jbenden
@ 2022-03-18 20:18 ` jbenden
  2022-03-18 20:21 ` jbenden
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jbenden @ 2022-03-18 20:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/36211#discussion_r830324592

Comment:
Sounds good!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
                   ` (3 preceding siblings ...)
  2022-03-18 20:18 ` [PR REVIEW] " jbenden
@ 2022-03-18 20:21 ` jbenden
  2022-06-29  2:15 ` github-actions
  2022-07-13  2:15 ` [PR PATCH] [Closed]: " github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: jbenden @ 2022-03-18 20:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/36211#issuecomment-1072769830

Comment:
I understand the defensive stance; however, but it's been years since the last release and a few good patches lay in the source. :)

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
                   ` (4 preceding siblings ...)
  2022-03-18 20:21 ` jbenden
@ 2022-06-29  2:15 ` github-actions
  2022-07-13  2:15 ` [PR PATCH] [Closed]: " github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-06-29  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36211#issuecomment-1169458497

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: mosh: update to 20220318
  2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
                   ` (5 preceding siblings ...)
  2022-06-29  2:15 ` github-actions
@ 2022-07-13  2:15 ` github-actions
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-07-13  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

There's a closed pull request on the void-packages repository

mosh: update to 20220318
https://github.com/void-linux/void-packages/pull/36211

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64`-`glibc`)

#### Notes
The upstream maintainer has seemingly vanished; therefore, a new release seems unlikely. As a workaround for the time being, switch to the git development branch.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-07-13  2:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 19:30 [PR PATCH] mosh: update to 20220318 jbenden
2022-03-18 19:40 ` [PR REVIEW] " classabbyamp
2022-03-18 19:47 ` leahneukirchen
2022-03-18 20:17 ` [PR PATCH] [Updated] " jbenden
2022-03-18 20:18 ` [PR REVIEW] " jbenden
2022-03-18 20:21 ` jbenden
2022-06-29  2:15 ` github-actions
2022-07-13  2:15 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).