[PR PATCH] rclone: update to 1.58.0, install completions

[PR PATCH] rclone: update to 1.58.0, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is a new pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages rclone
https://github.com/void-linux/void-packages/pull/36240

rclone: update to 1.58.0, install completions
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36240.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-36240.patch --]
[-- Type: text/x-diff, Size: 1522 bytes --]

From 9b5780b55ddefbc759031a4311b0968407171bea Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sat, 19 Mar 2022 11:40:42 +0100
Subject: [PATCH] rclone: update to 1.58.0, install completions

---
 srcpkgs/rclone/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index a16eb3bd5e5b..ab4097b83dda 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,9 +1,10 @@
 # Template file for 'rclone'
 pkgname=rclone
-version=1.57.0
+version=1.58.0
 revision=1
 wrksrc="rclone-v${version}"
 build_style=go
+build_helper=qemu
 go_import_path=github.com/rclone/rclone
 go_build_tags="noselfupdate"
 go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
@@ -13,7 +14,7 @@ license="MIT"
 homepage="https://rclone.org/"
 changelog="https://rclone.org/changelog/"
 distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
-checksum=3a762c02c202a9142c2d5c1a3927563a556d1683abadd25d2f695e237e4ea693
+checksum=8e0c49fad69525d1219415d2f0651fd243ddf02291fd95e91d2b074d4858c31f
 
 pre_build() {
 	if [ "$CROSS_BUILD" ] && [ "$XBPS_TARGET_LIBC" = musl ]; then
@@ -35,4 +36,9 @@ post_install() {
 	ln -sf rclone ${DESTDIR}/usr/bin/mount.rclone
 	vlicense COPYING
 	vman rclone.1
+
+	for shell in bash zsh fish; do
+		vtargetrun $GOPATH/bin/rclone genautocomplete $shell completion.$shell
+		vcompletion completion.$shell $shell
+	done
 }

Re: [PR REVIEW] rclone: update to 1.58.0, install completions

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#discussion_r833758964

Comment:
```suggestion
		vtargetrun ${DESTDIR}/usr/bin/rclone genautocomplete $shell completion.$shell
```

Re: rclone: update to 1.58.0, install completions

[anddam]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#issuecomment-1086830957

Comment:
Any blocker on this?

Re: [PR PATCH] [Updated] rclone: update to 1.58.0, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages rclone
https://github.com/void-linux/void-packages/pull/36240

rclone: update to 1.58.0, install completions
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36240.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-36240.patch --]
[-- Type: text/x-diff, Size: 1529 bytes --]

From 813d351e4b330654bcc1d6ffe17754d7715c1a9c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sat, 19 Mar 2022 11:40:42 +0100
Subject: [PATCH] rclone: update to 1.58.0, install completions

---
 srcpkgs/rclone/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index a16eb3bd5e5b..8716c827713b 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,9 +1,10 @@
 # Template file for 'rclone'
 pkgname=rclone
-version=1.57.0
+version=1.58.0
 revision=1
 wrksrc="rclone-v${version}"
 build_style=go
+build_helper=qemu
 go_import_path=github.com/rclone/rclone
 go_build_tags="noselfupdate"
 go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
@@ -13,7 +14,7 @@ license="MIT"
 homepage="https://rclone.org/"
 changelog="https://rclone.org/changelog/"
 distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
-checksum=3a762c02c202a9142c2d5c1a3927563a556d1683abadd25d2f695e237e4ea693
+checksum=8e0c49fad69525d1219415d2f0651fd243ddf02291fd95e91d2b074d4858c31f
 
 pre_build() {
 	if [ "$CROSS_BUILD" ] && [ "$XBPS_TARGET_LIBC" = musl ]; then
@@ -35,4 +36,9 @@ post_install() {
 	ln -sf rclone ${DESTDIR}/usr/bin/mount.rclone
 	vlicense COPYING
 	vman rclone.1
+
+	for shell in bash zsh fish; do
+		vtargetrun ${DESTDIR}/usr/bin/rclone genautocomplete $shell completion.$shell
+		vcompletion completion.$shell $shell
+	done
 }

Re: [PR REVIEW] rclone: update to 1.58.0, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#discussion_r841203656

Comment:
Added your suggestion, thanks!

Re: [PR REVIEW] rclone: update to 1.58.0, install completions

[4ricci]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#discussion_r841224329

Comment:
Just one more thing:

```suggestion
	ln -s rclone ${DESTDIR}/usr/bin/mount.rclone
```

https://github.com/void-linux/void-packages/pull/33884#discussion_r744033333

Re: [PR PATCH] [Updated] rclone: update to 1.58.0, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages rclone
https://github.com/void-linux/void-packages/pull/36240

rclone: update to 1.58.0, install completions
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36240.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-36240.patch --]
[-- Type: text/x-diff, Size: 1598 bytes --]

From 26fbec709846b4ccfb068c873632503ded17363d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sat, 19 Mar 2022 11:40:42 +0100
Subject: [PATCH] rclone: update to 1.58.0, install completions

---
 srcpkgs/rclone/template | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index a16eb3bd5e5b..3240b74edab4 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,9 +1,10 @@
 # Template file for 'rclone'
 pkgname=rclone
-version=1.57.0
+version=1.58.0
 revision=1
 wrksrc="rclone-v${version}"
 build_style=go
+build_helper=qemu
 go_import_path=github.com/rclone/rclone
 go_build_tags="noselfupdate"
 go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
@@ -13,7 +14,7 @@ license="MIT"
 homepage="https://rclone.org/"
 changelog="https://rclone.org/changelog/"
 distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
-checksum=3a762c02c202a9142c2d5c1a3927563a556d1683abadd25d2f695e237e4ea693
+checksum=8e0c49fad69525d1219415d2f0651fd243ddf02291fd95e91d2b074d4858c31f
 
 pre_build() {
 	if [ "$CROSS_BUILD" ] && [ "$XBPS_TARGET_LIBC" = musl ]; then
@@ -32,7 +33,12 @@ do_check() {
 }
 
 post_install() {
-	ln -sf rclone ${DESTDIR}/usr/bin/mount.rclone
+	ln -s rclone ${DESTDIR}/usr/bin/mount.rclone
 	vlicense COPYING
 	vman rclone.1
+
+	for shell in bash zsh fish; do
+		vtargetrun ${DESTDIR}/usr/bin/rclone genautocomplete $shell completion.$shell
+		vcompletion completion.$shell $shell
+	done
 }

Re: [PR REVIEW] rclone: update to 1.58.0, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

New review comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#discussion_r841283173

Comment:
done, thanks

Re: [PR REVIEW] rclone: update to 1.58.0, install completions

[paper42]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#discussion_r841672594

Comment:
-sf is actually correct, we sometimes want to run one step twice and without -f, it would fail

Re: [PR PATCH] [Updated] rclone: update to 1.58.0, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

There is an updated pull request by daniel-eys against master on the void-packages repository

https://github.com/daniel-eys/void-packages rclone
https://github.com/void-linux/void-packages/pull/36240

rclone: update to 1.58.0, install completions
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36240.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclone-36240.patch --]
[-- Type: text/x-diff, Size: 1529 bytes --]

From 967eaa4c4e86b238694317c997075ad57aa48d0c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Ey=C3=9Fer?= <daniel.eysser@gmail.com>
Date: Sat, 19 Mar 2022 11:40:42 +0100
Subject: [PATCH] rclone: update to 1.58.1, install completions

---
 srcpkgs/rclone/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/rclone/template b/srcpkgs/rclone/template
index a16eb3bd5e5b..52ab3f44059c 100644
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -1,9 +1,10 @@
 # Template file for 'rclone'
 pkgname=rclone
-version=1.57.0
+version=1.58.1
 revision=1
 wrksrc="rclone-v${version}"
 build_style=go
+build_helper=qemu
 go_import_path=github.com/rclone/rclone
 go_build_tags="noselfupdate"
 go_ldflags="-extldflags=-fuse-ld=bfd -X github.com/rclone/rclone/fs.Version=v${version}"
@@ -13,7 +14,7 @@ license="MIT"
 homepage="https://rclone.org/"
 changelog="https://rclone.org/changelog/"
 distfiles="https://downloads.rclone.org/v${version}/rclone-v${version}.tar.gz"
-checksum=3a762c02c202a9142c2d5c1a3927563a556d1683abadd25d2f695e237e4ea693
+checksum=4d1d50a5b4888aa8eca10624073759ab8376c8b1acb38a238831d40074792524
 
 pre_build() {
 	if [ "$CROSS_BUILD" ] && [ "$XBPS_TARGET_LIBC" = musl ]; then
@@ -35,4 +36,9 @@ post_install() {
 	ln -sf rclone ${DESTDIR}/usr/bin/mount.rclone
 	vlicense COPYING
 	vman rclone.1
+
+	for shell in bash zsh fish; do
+		vtargetrun ${DESTDIR}/usr/bin/rclone genautocomplete $shell completion.$shell
+		vcompletion completion.$shell $shell
+	done
 }

Re: rclone: update to 1.58.1, install completions

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#issuecomment-1172534719

Comment:
The test failing on i686 should be disabled.

```diff
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -28,6 +28,10 @@ pre_build() {
 do_check() {
 	rm cmd/serve/docker/docker_test.go
 
+	# could time out on i686, and it's deprecated
+	# https://github.com/rclone/rclone/issues/5784#issuecomment-961520934
+	rm backend/cache/cache_test.go
+
 	# equivalent to quicktest target of Makefile
 	RCLONE_CONFIG="/notfound" go test -tags "$go_build_tags" ./...
 }

```

Re: rclone: update to 1.58.1, install completions

[r-ricci]

[-- Attachment #1: Type: text/plain, Size: 632 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#issuecomment-1172534719

Comment:
The test failing on i686 should be disabled.

```diff
--- a/srcpkgs/rclone/template
+++ b/srcpkgs/rclone/template
@@ -28,6 +28,10 @@ pre_build() {
 do_check() {
 	rm cmd/serve/docker/docker_test.go
 
+	# could time out on i686 and it's deprecated
+	# https://github.com/rclone/rclone/issues/5784#issuecomment-961520934
+	rm backend/cache/cache_test.go
+
 	# equivalent to quicktest target of Makefile
 	RCLONE_CONFIG="/notfound" go test -tags "$go_build_tags" ./...
 }

```

Re: rclone: update to 1.58.1, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/36240#issuecomment-1180905915

Comment:
closing, superseded by #37991

Re: [PR PATCH] [Closed]: rclone: update to 1.58.1, install completions

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

There's a closed pull request on the void-packages repository

rclone: update to 1.58.1, install completions
https://github.com/void-linux/void-packages/pull/36240

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->