Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] taglib: update URLs and configure_args, adopt
@ 2022-04-04 15:28 subnut
  2022-04-05  8:40 ` [PR REVIEW] " sgn
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: subnut @ 2022-04-04 15:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

There is a new pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages taglib
https://github.com/void-linux/void-packages/pull/36518

taglib: update URLs and configure_args, adopt
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36518.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-taglib-36518.patch --]
[-- Type: text/x-diff, Size: 1341 bytes --]

From 2e3c60b4a659d2dce774320c1b667f16ba815e85 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Mon, 4 Apr 2022 20:54:40 +0530
Subject: [PATCH] taglib: update URLs and configure_args, adopt

---
 srcpkgs/taglib/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/taglib/template b/srcpkgs/taglib/template
index 05b6f143efee..5a8191316ded 100644
--- a/srcpkgs/taglib/template
+++ b/srcpkgs/taglib/template
@@ -1,15 +1,17 @@
 # Template file for 'taglib'
 pkgname=taglib
 version=1.12
-revision=1
+revision=2
 build_style=cmake
-configure_args="-DWITH_MP4=ON -DWITH_ASF=ON -DBUILD_SHARED_LIBS=ON"
+configure_args="-DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release
+ -DWITH_MP4=ON -DWITH_ASF=ON -DNO_ITUNES_HACKS=ON"
 hostmakedepends="pkg-config"
 makedepends="zlib-devel"
 short_desc="Library for accessing ID tags in various media files"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="LGPL-2.1-or-later, MPL-1.1"
-homepage="https://taglib.github.io/"
+homepage="https://taglib.org/"
+changelog="https://raw.githubusercontent.com/taglib/taglib/master/NEWS"
 distfiles="https://github.com/taglib/taglib/archive/v${version}.tar.gz"
 checksum=b5a56f78a8bd962aaaec992b25a031f541b949b6eb30aa232bd6d5fa17cf8fa8
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
@ 2022-04-05  8:40 ` sgn
  2022-04-05 12:44 ` subnut
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: sgn @ 2022-04-05  8:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/36518#discussion_r842524726

Comment:
Why `-DCMAKE_BUILD_TYPE=Release`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
  2022-04-05  8:40 ` [PR REVIEW] " sgn
@ 2022-04-05 12:44 ` subnut
  2022-04-05 15:11 ` subnut
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: subnut @ 2022-04-05 12:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36518#discussion_r842739971

Comment:
Their [`INSTALL.md`](https://github.com/taglib/taglib/blob/master/INSTALL.md#taglib-installation) suggests it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
  2022-04-05  8:40 ` [PR REVIEW] " sgn
  2022-04-05 12:44 ` subnut
@ 2022-04-05 15:11 ` subnut
  2022-06-29 21:11 ` Duncaen
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: subnut @ 2022-04-05 15:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New review comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36518#discussion_r842739971

Comment:
[`INSTALL.md`](https://github.com/taglib/taglib/blob/master/INSTALL.md#taglib-installation) recommends to set that

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
                   ` (2 preceding siblings ...)
  2022-04-05 15:11 ` subnut
@ 2022-06-29 21:11 ` Duncaen
  2022-06-29 21:11 ` Duncaen
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Duncaen @ 2022-06-29 21:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36518#discussion_r910416887

Comment:
Looks like it doesn't anything and just forces the cmake defaults on us which we avoid in https://github.com/void-linux/void-packages/commit/1af5a29d87a.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR REVIEW] taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
                   ` (3 preceding siblings ...)
  2022-06-29 21:11 ` Duncaen
@ 2022-06-29 21:11 ` Duncaen
  2022-06-30  5:21 ` subnut
  2022-06-30  5:21 ` [PR PATCH] [Closed]: " subnut
  6 siblings, 0 replies; 8+ messages in thread
From: Duncaen @ 2022-06-29 21:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/36518#discussion_r910417369

Comment:
Why `-DNO_ITUNES_HACKS=ON`?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
                   ` (4 preceding siblings ...)
  2022-06-29 21:11 ` Duncaen
@ 2022-06-30  5:21 ` subnut
  2022-06-30  5:21 ` [PR PATCH] [Closed]: " subnut
  6 siblings, 0 replies; 8+ messages in thread
From: subnut @ 2022-06-30  5:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/36518#issuecomment-1170776484

Comment:
Sorry, but I've forgotten why I'd made these changes.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PR PATCH] [Closed]: taglib: update URLs and configure_args, adopt
  2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
                   ` (5 preceding siblings ...)
  2022-06-30  5:21 ` subnut
@ 2022-06-30  5:21 ` subnut
  6 siblings, 0 replies; 8+ messages in thread
From: subnut @ 2022-06-30  5:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]

There's a closed pull request on the void-packages repository

taglib: update URLs and configure_args, adopt
https://github.com/void-linux/void-packages/pull/36518

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-06-30  5:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-04 15:28 [PR PATCH] taglib: update URLs and configure_args, adopt subnut
2022-04-05  8:40 ` [PR REVIEW] " sgn
2022-04-05 12:44 ` subnut
2022-04-05 15:11 ` subnut
2022-06-29 21:11 ` Duncaen
2022-06-29 21:11 ` Duncaen
2022-06-30  5:21 ` subnut
2022-06-30  5:21 ` [PR PATCH] [Closed]: " subnut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).