Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] runit: Remove zsh completions
@ 2022-04-09  2:18 foopub
  2022-04-09  2:25 ` foopub
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: foopub @ 2022-04-09  2:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

New issue by foopub on void-packages repository

https://github.com/void-linux/void-packages/issues/36593

Description:
The file https://github.com/void-linux/void-packages/blob/master/srcpkgs/runit/files/_sv seems unnecessary as better completions are provided by the default https://github.com/zsh-users/zsh/blob/master/Completion/Unix/Command/_runit (which seems to have been created only a few months after in 2014... weird no one has noticed until now)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
@ 2022-04-09  2:25 ` foopub
  2022-07-09  2:14 ` github-actions
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: foopub @ 2022-04-09  2:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

New comment by foopub on void-packages repository

https://github.com/void-linux/void-packages/issues/36593#issuecomment-1093599205

Comment:

https://github.com/void-linux/void-packages/pull/28790
https://github.com/void-linux/runit/pull/15
also seem relevant, but the template does seem to use the version provided in the files here:
```
	vinstall ${FILESDIR}/_sv 644 usr/share/zsh/site-functions
```

Any point opening the same issue in the void runit repo? 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
  2022-04-09  2:25 ` foopub
@ 2022-07-09  2:14 ` github-actions
  2022-07-23  2:14 ` [ISSUE] [CLOSED] " github-actions
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-07-09  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/36593#issuecomment-1179460566

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ISSUE] [CLOSED] runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
  2022-04-09  2:25 ` foopub
  2022-07-09  2:14 ` github-actions
@ 2022-07-23  2:14 ` github-actions
  2022-10-27 21:29 ` RunningDroid
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2022-07-23  2:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Closed issue by foopub on void-packages repository

https://github.com/void-linux/void-packages/issues/36593

Description:
The file https://github.com/void-linux/void-packages/blob/master/srcpkgs/runit/files/_sv seems unnecessary as better completions are provided by the default https://github.com/zsh-users/zsh/blob/master/Completion/Unix/Command/_runit (which seems to have been created only a few months after in 2014... weird no one has noticed until now)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
                   ` (2 preceding siblings ...)
  2022-07-23  2:14 ` [ISSUE] [CLOSED] " github-actions
@ 2022-10-27 21:29 ` RunningDroid
  2023-01-18 19:45 ` leahneukirchen
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: RunningDroid @ 2022-10-27 21:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/issues/36593#issuecomment-1294083479

Comment:
Sorry for bumping a stale issue, but I wanted to point out that (after https://github.com/void-linux/runit/pull/15 is merged) neither completion is better than the other (IMO.)
The completion from zsh-users has prettier prompts, but it doesn't ignore `$SVDIR` when using `sudo`\*.
The completion that we (will) ship with runit (that we apparently have 2 copies of) ignores `$SVDIR` when using `sudo`\*, but it has relatively minimalist prompts.
The good news is that the licenses between the two completions [appears to be](https://en.wikipedia.org/wiki/License_compatibility#/media/File:Floss-license-slide-image.svg) compatible, runit is licensed BSD-3-CLAUSE & the zsh-users completion appears to be licensed MIT, so we (aka void-linux/runit) can copy the fancy prompts but I don't think they can copy the `sudo`\* detection without re-licensing their completions.

\*:and `su -c`, and `doas`

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
                   ` (3 preceding siblings ...)
  2022-10-27 21:29 ` RunningDroid
@ 2023-01-18 19:45 ` leahneukirchen
  2023-04-19  1:54 ` github-actions
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: leahneukirchen @ 2023-01-18 19:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/issues/36593#issuecomment-1387675034

Comment:
+1 for removing our completion.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
                   ` (4 preceding siblings ...)
  2023-01-18 19:45 ` leahneukirchen
@ 2023-04-19  1:54 ` github-actions
  2023-05-04  1:51 ` [ISSUE] [CLOSED] " github-actions
  2023-06-16 12:26 ` leahneukirchen
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2023-04-19  1:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/36593#issuecomment-1514023430

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ISSUE] [CLOSED] runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
                   ` (5 preceding siblings ...)
  2023-04-19  1:54 ` github-actions
@ 2023-05-04  1:51 ` github-actions
  2023-06-16 12:26 ` leahneukirchen
  7 siblings, 0 replies; 9+ messages in thread
From: github-actions @ 2023-05-04  1:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Closed issue by foopub on void-packages repository

https://github.com/void-linux/void-packages/issues/36593

Description:
The file https://github.com/void-linux/void-packages/blob/master/srcpkgs/runit/files/_sv seems unnecessary as better completions are provided by the default https://github.com/zsh-users/zsh/blob/master/Completion/Unix/Command/_runit (which seems to have been created only a few months after in 2014... weird no one has noticed until now)

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ISSUE] [CLOSED] runit: Remove zsh completions
  2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
                   ` (6 preceding siblings ...)
  2023-05-04  1:51 ` [ISSUE] [CLOSED] " github-actions
@ 2023-06-16 12:26 ` leahneukirchen
  7 siblings, 0 replies; 9+ messages in thread
From: leahneukirchen @ 2023-06-16 12:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Closed issue by foopub on void-packages repository

https://github.com/void-linux/void-packages/issues/36593

Description:
The file https://github.com/void-linux/void-packages/blob/master/srcpkgs/runit/files/_sv seems unnecessary as better completions are provided by the default https://github.com/zsh-users/zsh/blob/master/Completion/Unix/Command/_runit (which seems to have been created only a few months after in 2014... weird no one has noticed until now)

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-06-16 12:26 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09  2:18 [ISSUE] runit: Remove zsh completions foopub
2022-04-09  2:25 ` foopub
2022-07-09  2:14 ` github-actions
2022-07-23  2:14 ` [ISSUE] [CLOSED] " github-actions
2022-10-27 21:29 ` RunningDroid
2023-01-18 19:45 ` leahneukirchen
2023-04-19  1:54 ` github-actions
2023-05-04  1:51 ` [ISSUE] [CLOSED] " github-actions
2023-06-16 12:26 ` leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).