Github messages for voidlinux
 help / color / mirror / Atom feed
* [ISSUE] Request: package nnn with gitstatus
@ 2022-04-14 16:54 ElDifinitivo
  2022-04-14 20:25 ` paper42
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: ElDifinitivo @ 2022-04-14 16:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

New issue by ElDifinitivo on void-packages repository

https://github.com/void-linux/void-packages/issues/36693

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname: `Void 5.15.32_1 x86_64 AuthenticAMD uptodate rrmFFFFFFFFFFFFF`
* package: `nnn-4.4_1`

Specifically with this diff: [https://github.com/jarun/nnn/blob/master/patches/gitstatus/mainline.diff](https://github.com/jarun/nnn/blob/master/patches/gitstatus/mainline.diff).

It becomes incredibly useful in vim/nvim when using an nnn plugin as a file-picker as a replacement for nerdtree to see the git status for project files. It adds a `-G` flag to `nnn` to enable git status symbols. An example of how it looks can be seen [here](https://github.com/luukvbaal/nnn.nvim#git-status).

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
@ 2022-04-14 20:25 ` paper42
  2022-04-15 13:47 ` tibequadorian
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: paper42 @ 2022-04-14 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 396 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/36693#issuecomment-1099591701

Comment:
> A [patch framework](https://github.com/jarun/nnn/tree/master/patches) hosts sizable user-submitted patches which are subjective in nature.

I don't think it's a good idea to make the void nnn package use a user submitted patch in the default build.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
  2022-04-14 20:25 ` paper42
@ 2022-04-15 13:47 ` tibequadorian
  2022-07-15  2:15 ` github-actions
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: tibequadorian @ 2022-04-15 13:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/issues/36693#issuecomment-1100120327

Comment:
> I don't think it's a good idea to make the void nnn package use a user submitted patch in the default build.

Agree with that. However I think it would be okay to add a build option in the template that enables this patch as it is done in our [dmenu template](https://github.com/void-linux/void-packages/blob/master/srcpkgs/dmenu/template) already.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
  2022-04-14 20:25 ` paper42
  2022-04-15 13:47 ` tibequadorian
@ 2022-07-15  2:15 ` github-actions
  2022-07-15 20:44 ` [ISSUE] [CLOSED] " Duncaen
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: github-actions @ 2022-07-15  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/36693#issuecomment-1185097752

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
                   ` (3 preceding siblings ...)
  2022-07-15 20:44 ` [ISSUE] [CLOSED] " Duncaen
@ 2022-07-15 20:44 ` Duncaen
  2022-07-15 20:47 ` tibequadorian
  2022-07-15 20:52 ` Duncaen
  6 siblings, 0 replies; 8+ messages in thread
From: Duncaen @ 2022-07-15 20:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/36693#issuecomment-1185905490

Comment:
No the build option is a bad idea, if someone wants to maintain their own patched builds they can simply drop their patches into the patches directory, some package mantainer deciding that they should add patches for their usecase as build option is the wrong approach and belongs into their own fork/package.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [ISSUE] [CLOSED] Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
                   ` (2 preceding siblings ...)
  2022-07-15  2:15 ` github-actions
@ 2022-07-15 20:44 ` Duncaen
  2022-07-15 20:44 ` Duncaen
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: Duncaen @ 2022-07-15 20:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Closed issue by ElDifinitivo on void-packages repository

https://github.com/void-linux/void-packages/issues/36693

Description:
<!-- Don't request update of package. We have a script for that. https://alpha.de.repo.voidlinux.org/void-updates/void-updates.txt . However, a quality pull request may help. -->
### System

* xuname: `Void 5.15.32_1 x86_64 AuthenticAMD uptodate rrmFFFFFFFFFFFFF`
* package: `nnn-4.4_1`

Specifically with this diff: [https://github.com/jarun/nnn/blob/master/patches/gitstatus/mainline.diff](https://github.com/jarun/nnn/blob/master/patches/gitstatus/mainline.diff).

It becomes incredibly useful in vim/nvim when using an nnn plugin as a file-picker as a replacement for nerdtree to see the git status for project files. It adds a `-G` flag to `nnn` to enable git status symbols. An example of how it looks can be seen [here](https://github.com/luukvbaal/nnn.nvim#git-status).

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
                   ` (4 preceding siblings ...)
  2022-07-15 20:44 ` Duncaen
@ 2022-07-15 20:47 ` tibequadorian
  2022-07-15 20:52 ` Duncaen
  6 siblings, 0 replies; 8+ messages in thread
From: tibequadorian @ 2022-07-15 20:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by tibequadorian on void-packages repository

https://github.com/void-linux/void-packages/issues/36693#issuecomment-1185910461

Comment:
Does that mean we should drop the fuzzymatch patch in dmenu?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Request: package nnn with gitstatus
  2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
                   ` (5 preceding siblings ...)
  2022-07-15 20:47 ` tibequadorian
@ 2022-07-15 20:52 ` Duncaen
  6 siblings, 0 replies; 8+ messages in thread
From: Duncaen @ 2022-07-15 20:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/36693#issuecomment-1185920254

Comment:
IMHO yes, there is no justification for what patches we should have in templates and users already have to build it with the option enabled, so  they can just drop the patch into the right directory, they most likely already do it for `config.h` anyways.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-07-15 20:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 16:54 [ISSUE] Request: package nnn with gitstatus ElDifinitivo
2022-04-14 20:25 ` paper42
2022-04-15 13:47 ` tibequadorian
2022-07-15  2:15 ` github-actions
2022-07-15 20:44 ` [ISSUE] [CLOSED] " Duncaen
2022-07-15 20:44 ` Duncaen
2022-07-15 20:47 ` tibequadorian
2022-07-15 20:52 ` Duncaen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).