* [PR PATCH] signond: don't use -fno-rtti
@ 2022-04-18 8:29 hervyqa
2022-04-18 9:22 ` hervyqa
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: hervyqa @ 2022-04-18 8:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
There is a new pull request by hervyqa against master on the void-packages repository
https://github.com/hervyqa/void-packages signond
https://github.com/void-linux/void-packages/pull/36748
signond: don't use -fno-rtti
Close: #34935
Successfully add a new account in Online Account (kde plasma).
Reference:
- https://build.opensuse.org/package/view_file/openSUSE:Factory/signon/0001-Don-t-use-fno-rtti.patch?expand=1
bug:
- https://bugs.kde.org/show_bug.cgi?id=427063
- https://bugzilla.opensuse.org/show_bug.cgi?id=1172904
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
Before:
After:
A patch file from https://github.com/void-linux/void-packages/pull/36748.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signond-36748.patch --]
[-- Type: text/x-diff, Size: 5738 bytes --]
From d4df52aa9e26686decfb6faaf63c3a1045002e69 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@pm.me>
Date: Mon, 18 Apr 2022 15:22:04 +0700
Subject: [PATCH] signond: don't use -fno-rtti
---
.../signond/patches/don-t-use-fno-rtti.patch | 124 ++++++++++++++++++
srcpkgs/signond/template | 2 +-
2 files changed, 125 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/signond/patches/don-t-use-fno-rtti.patch
diff --git a/srcpkgs/signond/patches/don-t-use-fno-rtti.patch b/srcpkgs/signond/patches/don-t-use-fno-rtti.patch
new file mode 100644
index 000000000000..62aad43ea29a
--- /dev/null
+++ b/srcpkgs/signond/patches/don-t-use-fno-rtti.patch
@@ -0,0 +1,124 @@
+iFrom e21867fa27e32f5391d73d145eef1c8d908dee44 Mon Sep 17 00:00:00 2001
+From: Fabian Vogt <fabian@ritter-vogt.de>
+Date: Thu, 18 Jun 2020 10:22:04 +0200
+Subject: [PATCH] Don't use -fno-rtti
+
+QProcess uses typeid and crashes otherwise.
+---
+ common-project-config.pri | 2 --
+ src/extensions/cryptsetup/cryptsetup.pro | 1 -
+ src/plugins/plugins.pri | 3 +--
+ src/remotepluginprocess/remotepluginprocess.pro | 3 +--
+ tests/extensions/extensions.pri | 3 +--
+ tests/libsignon-qt-tests/libsignon-qt-tests.pro | 3 +--
+ tests/passwordplugintest/passwordplugintest.pro | 3 +--
+ tests/signond-tests/signond-tests.pri | 3 +--
+ 8 files changed, 6 insertions(+), 15 deletions(-)
+
+diff --git a/common-project-config.pri b/common-project-config.pri
+index 606f70b..abe6cf6 100644
+--- a/common-project-config.pri
++++ b/common-project-config.pri
+@@ -13,8 +13,6 @@ RCC_DIR = resources
+
+ # we don't like warnings...
+ QMAKE_CXXFLAGS -= -Werror -Wno-write-strings
+-# Disable RTTI
+-QMAKE_CXXFLAGS += -fno-rtti
+ # Disable exceptions
+ CONFIG += exceptions_off
+ # Use C++11
+diff --git a/src/extensions/cryptsetup/cryptsetup.pro b/src/extensions/cryptsetup/cryptsetup.pro
+index f4b6e53..5cc214e 100644
+--- a/src/extensions/cryptsetup/cryptsetup.pro
++++ b/src/extensions/cryptsetup/cryptsetup.pro
+@@ -29,7 +29,6 @@ QT -= gui
+
+ QMAKE_CXXFLAGS += \
+ -fno-exceptions \
+- -fno-rtti \
+ -fvisibility=hidden
+
+ DEFINES += QT_NO_CAST_TO_ASCII QT_NO_CAST_FROM_ASCII
+diff --git a/src/plugins/plugins.pri b/src/plugins/plugins.pri
+index 2c03e74..074896d 100644
+--- a/src/plugins/plugins.pri
++++ b/src/plugins/plugins.pri
+@@ -22,8 +22,7 @@ LIBS += -lsignon-plugins
+ QMAKE_LIBDIR += \
+ $${TOP_BUILD_DIR}/lib/plugins
+
+-QMAKE_CXXFLAGS += -fno-exceptions \
+- -fno-rtti
++QMAKE_CXXFLAGS += -fno-exceptions
+
+ headers.path = $${INSTALL_PREFIX}/include/signon-plugins
+
+diff --git a/src/remotepluginprocess/remotepluginprocess.pro b/src/remotepluginprocess/remotepluginprocess.pro
+index 7c2ea00..36b4cbe 100644
+--- a/src/remotepluginprocess/remotepluginprocess.pro
++++ b/src/remotepluginprocess/remotepluginprocess.pro
+@@ -40,8 +40,7 @@ LIBS += \
+ -lsignon-plugins-common \
+ -lsignon-plugins
+
+-QMAKE_CXXFLAGS += -fno-exceptions \
+- -fno-rtti
++QMAKE_CXXFLAGS += -fno-exceptions
+
+ #DEFINES += QT_NO_CAST_TO_ASCII \
+ # QT_NO_CAST_FROM_ASCII
+diff --git a/tests/extensions/extensions.pri b/tests/extensions/extensions.pri
+index 179cd28..2fd7595 100644
+--- a/tests/extensions/extensions.pri
++++ b/tests/extensions/extensions.pri
+@@ -20,5 +20,4 @@ INCLUDEPATH += . \
+ $$TOP_SRC_DIR/lib/signond
+
+ QMAKE_CXXFLAGS += \
+- -fno-exceptions \
+- -fno-rtti
++ -fno-exceptions
+diff --git a/tests/libsignon-qt-tests/libsignon-qt-tests.pro b/tests/libsignon-qt-tests/libsignon-qt-tests.pro
+index 43f2d59..ac87781 100644
+--- a/tests/libsignon-qt-tests/libsignon-qt-tests.pro
++++ b/tests/libsignon-qt-tests/libsignon-qt-tests.pro
+@@ -36,8 +36,7 @@ INCLUDEPATH += . \
+ $$TOP_SRC_DIR/src/plugins/test
+ DEFINES += SSO_CI_TESTMANAGEMENT
+ DEFINES += "SIGNOND_PLUGINS_DIR=$${SIGNOND_PLUGINS_DIR_QUOTED}"
+-QMAKE_CXXFLAGS += -fno-exceptions \
+- -fno-rtti
++QMAKE_CXXFLAGS += -fno-exceptions
+
+ check.depends = $$TARGET
+ check.commands = "SSO_PLUGINS_DIR=$${TOP_BUILD_DIR}/src/plugins/test SSO_EXTENSIONS_DIR=$${TOP_BUILD_DIR}/non-existing-dir $$RUN_WITH_SIGNOND ./libsignon-qt-tests"
+diff --git a/tests/passwordplugintest/passwordplugintest.pro b/tests/passwordplugintest/passwordplugintest.pro
+index 6132921..ce16fdc 100644
+--- a/tests/passwordplugintest/passwordplugintest.pro
++++ b/tests/passwordplugintest/passwordplugintest.pro
+@@ -19,5 +19,4 @@ INCLUDEPATH += $${TOP_SRC_DIR}/lib/plugins \
+ $${TOP_SRC_DIR}/src/plugins \
+ $${TOP_SRC_DIR}/lib
+
+-QMAKE_CXXFLAGS += -fno-exceptions \
+- -fno-rtti
++QMAKE_CXXFLAGS += -fno-exceptions
+diff --git a/tests/signond-tests/signond-tests.pri b/tests/signond-tests/signond-tests.pri
+index 1bbd5a1..e95556b 100644
+--- a/tests/signond-tests/signond-tests.pri
++++ b/tests/signond-tests/signond-tests.pri
+@@ -34,8 +34,7 @@ INCLUDEPATH += . \
+ $${TOP_SRC_DIR}/lib/plugins/signon-plugins-common/SignOn \
+ $${TOP_SRC_DIR}/lib \
+
+-QMAKE_CXXFLAGS += -fno-exceptions \
+- -fno-rtti
++QMAKE_CXXFLAGS += -fno-exceptions
+
+ check.depends = $$TARGET
+ check.commands = "SSO_PLUGINS_DIR=$${TOP_BUILD_DIR}/src/plugins/test SSO_EXTENSIONS_DIR=$${TOP_BUILD_DIR}/non-existing-dir $$RUN_WITH_SIGNOND ./$$TARGET"
+--
+2.25.1
+
+
diff --git a/srcpkgs/signond/template b/srcpkgs/signond/template
index 9a2f0cff8c26..1395e7afb4a8 100644
--- a/srcpkgs/signond/template
+++ b/srcpkgs/signond/template
@@ -1,7 +1,7 @@
# Template file for 'signond'
pkgname=signond
version=8.60
-revision=3
+revision=4
wrksrc="signond-VERSION_${version}"
build_style=qmake
configure_args="LIBDIR=/usr/lib"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: signond: don't use -fno-rtti
2022-04-18 8:29 [PR PATCH] signond: don't use -fno-rtti hervyqa
@ 2022-04-18 9:22 ` hervyqa
2022-04-18 9:39 ` [PR PATCH] [Updated] " hervyqa
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: hervyqa @ 2022-04-18 9:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New comment by hervyqa on void-packages repository
https://github.com/void-linux/void-packages/pull/36748#issuecomment-1101254695
Comment:
v8.61 available. I'll change it soon
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] signond: don't use -fno-rtti
2022-04-18 8:29 [PR PATCH] signond: don't use -fno-rtti hervyqa
2022-04-18 9:22 ` hervyqa
@ 2022-04-18 9:39 ` hervyqa
2022-04-18 18:16 ` signond: update to 8.61 hervyqa
2022-04-18 21:00 ` [PR PATCH] [Merged]: " Johnnynator
3 siblings, 0 replies; 5+ messages in thread
From: hervyqa @ 2022-04-18 9:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]
There is an updated pull request by hervyqa against master on the void-packages repository
https://github.com/hervyqa/void-packages signond
https://github.com/void-linux/void-packages/pull/36748
signond: don't use -fno-rtti
Close: #34935
Successfully add a new account in Online Account (kde plasma).
Reference:
- https://build.opensuse.org/package/view_file/openSUSE:Factory/signon/0001-Don-t-use-fno-rtti.patch?expand=1
bug:
- https://bugs.kde.org/show_bug.cgi?id=427063
- https://bugzilla.opensuse.org/show_bug.cgi?id=1172904
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
Before:
After:
A patch file from https://github.com/void-linux/void-packages/pull/36748.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-signond-36748.patch --]
[-- Type: text/x-diff, Size: 1101 bytes --]
From a97cb3fffca4312cb6521bf20a6c9f757b20b5a7 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@pm.me>
Date: Mon, 18 Apr 2022 15:22:04 +0700
Subject: [PATCH] signond: update to 8.61
---
srcpkgs/signond/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/signond/template b/srcpkgs/signond/template
index 9a2f0cff8c26..6a3bb44122ab 100644
--- a/srcpkgs/signond/template
+++ b/srcpkgs/signond/template
@@ -1,7 +1,7 @@
# Template file for 'signond'
pkgname=signond
-version=8.60
-revision=3
+version=8.61
+revision=1
wrksrc="signond-VERSION_${version}"
build_style=qmake
configure_args="LIBDIR=/usr/lib"
@@ -13,7 +13,7 @@ maintainer="John Rowley <enterthevoid@codesector.co>"
license="LGPL-2.1-only"
homepage="https://gitlab.com/accounts-sso/signond"
distfiles="${homepage}/-/archive/VERSION_${version}/signond-VERSION_${version}.tar.gz"
-checksum=0da2a080e4b01f44855d1a519f828007a5c756ee93827db9098a1b4b880f28fe
+checksum=3dd57c25e1bf1583b2cb857f96831e38e73d40264ff66ca43e63bb7233f76828
pre_configure() {
if [ "$CROSS_BUILD" ]; then
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: signond: update to 8.61
2022-04-18 8:29 [PR PATCH] signond: don't use -fno-rtti hervyqa
2022-04-18 9:22 ` hervyqa
2022-04-18 9:39 ` [PR PATCH] [Updated] " hervyqa
@ 2022-04-18 18:16 ` hervyqa
2022-04-18 21:00 ` [PR PATCH] [Merged]: " Johnnynator
3 siblings, 0 replies; 5+ messages in thread
From: hervyqa @ 2022-04-18 18:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New comment by hervyqa on void-packages repository
https://github.com/void-linux/void-packages/pull/36748#issuecomment-1101254695
Comment:
~~v8.61 available. I'll change it soon~~
Done.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: signond: update to 8.61
2022-04-18 8:29 [PR PATCH] signond: don't use -fno-rtti hervyqa
` (2 preceding siblings ...)
2022-04-18 18:16 ` signond: update to 8.61 hervyqa
@ 2022-04-18 21:00 ` Johnnynator
3 siblings, 0 replies; 5+ messages in thread
From: Johnnynator @ 2022-04-18 21:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
There's a merged pull request on the void-packages repository
signond: update to 8.61
https://github.com/void-linux/void-packages/pull/36748
Description:
Close: #34935
Successfully add a new account in Online Account (kde plasma).
#### Bug
- https://bugs.kde.org/show_bug.cgi?id=427063
- https://bugzilla.opensuse.org/show_bug.cgi?id=1172904
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
#### Add image
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-18 21:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 8:29 [PR PATCH] signond: don't use -fno-rtti hervyqa
2022-04-18 9:22 ` hervyqa
2022-04-18 9:39 ` [PR PATCH] [Updated] " hervyqa
2022-04-18 18:16 ` signond: update to 8.61 hervyqa
2022-04-18 21:00 ` [PR PATCH] [Merged]: " Johnnynator
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).