[PR PATCH] kdeconnect: add breeze-icons to depends

[PR PATCH] kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]

There is a new pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1035 bytes --]

From 43812b43383a3f936b86e4644177dfe9d1dc6466 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons to depends

---
 srcpkgs/kdeconnect/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index a7b4fcf1e5b3..1184873ae70e 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -12,7 +12,7 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols breeze-icons"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: kdeconnect: add breeze-icons to depends

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1101955325

Comment:
Cc: @Johnnynator 

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1035 bytes --]

From b381a71adc3cc743c8dafd51ee9b36f05b9a0b70 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons to depends

---
 srcpkgs/kdeconnect/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index 1f48792b51ca..39cfaac4ea60 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -12,7 +12,7 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols breeze-icons"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 2169 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1140368008

Comment:
Rebasing caused a test to fail:
```
=> kdeconnect-22.04.1_1: running do_check ...
[0/1] Running tests...
Test project /builddir/kdeconnect-kde-22.04.1/build
    Start 1: pluginloadtest
1/3 Test #1: pluginloadtest ...................   Passed    0.09 sec
    Start 2: sendfiletest
2/3 Test #2: sendfiletest .....................***Failed    0.06 sec
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
********* Start testing of TestSendFile *********
Config: Using QtTest library 5.15.2, Qt 5.15.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 10.2.1 20201203), unknown unknown
PASS   : TestSendFile::initTestCase()
FAIL!  : TestSendFile::testSend() 'plugin' returned FALSE. ()
   Loc: [/builddir/kdeconnect-kde-22.04.1/tests/sendfiletest.cpp(67)]
QWARN  : TestSendFile::testSslJobs() QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
PASS   : TestSendFile::testSslJobs()
PASS   : TestSendFile::cleanupTestCase()
Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted, 26ms
********* Finished testing of TestSendFile *********

    Start 3: testsocketlinereader
3/3 Test #3: testsocketlinereader .............   Passed    4.16 sec

67% tests passed, 1 tests failed out of 3

Total Test time (real) =   4.31 sec

The following tests FAILED:
	  2 - sendfiletest (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util 
cd /builddir/kdeconnect-kde-22.04.1/build && /usr/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.
=> ERROR: kdeconnect-22.04.1_1: do_check: '${make_check_pre} ${make_cmd} ${make_check_args} ${make_check_target}' exited with 1
=> ERROR:   in do_check() at common/build-style/cmake.sh:119
```
I'm rebuilding it locally to see if it's a transient error, if it's not then I might not be able to get to it right away.

Re: kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1140368755

Comment:
it's not a transient error, I don't know enough C or QT to work out what's going wrong though.
I'll look into it some more later, but this is the line that fails: https://github.com/KDE/kdeconnect-kde/blob/edbea8c3fdb3e7cc2106792c09cfcb48f7da78a2/tests/sendfiletest.cpp#L67

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1035 bytes --]

From 7b5104a10fb13ff703f289652cc0594f4dacd689 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons to depends

---
 srcpkgs/kdeconnect/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index ab135176f03f..92e8c44b135e 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -12,7 +12,7 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols breeze-icons"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]

From 4d989e0ab042836138f5dd4f272816405a2c575d Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons & kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index ab135176f03f..a7e22e60cf48 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -12,7 +12,8 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: kdeconnect: add breeze-icons to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1242650093

Comment:
Rebased & added `kpeoplevcard` to fix https://bugs.kde.org/show_bug.cgi?id=458304

I'm probably gonna hit their IRC or forum at some point for help with the failing test.

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons & kpeoplevcard to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]

From 644d2363ec24bc4891817fe66eac454b97e1a56e Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons & kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index ab135176f03f..a7e22e60cf48 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -12,7 +12,8 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons & kpeoplevcard to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]

From 7ef3bf9580e7eb2564e824418295b8ad9480dcad Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons & kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index 6ef41ea86537..b730853c8c62 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -12,7 +12,8 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1242650093

Comment:
Rebased & added `kpeoplevcard` to fix https://bugs.kde.org/show_bug.cgi?id=458304

~~I'm probably gonna hit their IRC or forum at some point for help with the failing test.~~
edit: I never got around to it & the tests pass now

Re: kdeconnect: add breeze-icons & kpeoplevcard to depends

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1357085148

Comment:
can you rebase and bump revision?

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons & kpeoplevcard to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1702 bytes --]

From 011c0affc18562cf8f7735976bdfd94c92316c49 Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: update to 22.12.0; add breeze-icons &
 kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index 3bdbb3294f77..845be17bf868 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -1,7 +1,7 @@
 # Template file for 'kdeconnect'
 pkgname=kdeconnect
-version=22.08.2
-revision=2
+version=22.12.0
+revision=1
 build_style=cmake
 configure_args="-DWaylandScanner_EXECUTABLE=/usr/bin/wayland-scanner"
 hostmakedepends="extra-cmake-modules qt5-host-tools
@@ -11,12 +11,13 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/KDE/kdeconnect-kde"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-kde-${version}.tar.xz"
-checksum=80ed7943dd0846b39168b7e97fb171142799f240fa005a15e085ccbbc68c0991
+checksum=a652994b4d7280effb384483ee41d022827efd17f6dc7c5f748b9f95e8d47688
 python_version=3

Re: kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1358888827

Comment:
Done

Re: kdeconnect: add breeze-icons & kpeoplevcard to depends

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1477172898

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons & kpeoplevcard to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1087 bytes --]

From bc447ffa325421ec3a9d2f21552891aaa47397bb Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: update to 22.12.0; add breeze-icons &
 kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index ee36684837fa..d7fc61d8a77d 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -11,7 +11,8 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: kdeconnect: add breeze-icons & kpeoplevcard to depends

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36761#issuecomment-1478378056

Comment:
commit message mentions an update but the diff doesn't have that. also revbump

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons & kpeoplevcard to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1067 bytes --]

From 9bc41e01a5a7dc13930b4f5bed290d2f0c6ed38f Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons & kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index ee36684837fa..d7fc61d8a77d 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -11,7 +11,8 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: [PR PATCH] [Updated] kdeconnect: add breeze-icons & kpeoplevcard to depends

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 1668 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages add_kdeconnect_depend
https://github.com/void-linux/void-packages/pull/36761

kdeconnect: add breeze-icons & kpeoplevcard to depends
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add_kdeconnect_depend-36761.patch --]
[-- Type: text/x-diff, Size: 1324 bytes --]

From 278cdc601d37988d9a149b873341a40363610d5b Mon Sep 17 00:00:00 2001
From: RunningDroid <runningdroid@zoho.com>
Date: Mon, 18 Apr 2022 22:29:17 -0400
Subject: [PATCH] kdeconnect: add breeze-icons & kpeoplevcard to depends

---
 srcpkgs/kdeconnect/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/kdeconnect/template b/srcpkgs/kdeconnect/template
index ee36684837fa..37e97df6455e 100644
--- a/srcpkgs/kdeconnect/template
+++ b/srcpkgs/kdeconnect/template
@@ -1,7 +1,7 @@
 # Template file for 'kdeconnect'
 pkgname=kdeconnect
 version=22.12.1
-revision=1
+revision=2
 build_style=cmake
 configure_args="-DWaylandScanner_EXECUTABLE=/usr/bin/wayland-scanner"
 hostmakedepends="extra-cmake-modules qt5-host-tools
@@ -11,7 +11,8 @@ makedepends="kcmutils-devel qca-qt5-devel frameworkintegration-devel
  qt5-declarative-devel libfakekey-devel kwayland-devel
  qt5-multimedia-devel kpeoplevcard-devel kirigami2-devel
  qqc2-desktop-style-devel pulseaudio-qt-devel"
-depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols"
+depends="kde-cli-tools qca-qt5-ossl fuse-sshfs kirigami2 qt5-quickcontrols
+ breeze-icons kpeoplevcard"
 checkdepends="qca-qt5-ossl"
 short_desc="Multi-platform app that allows your devices to communicate"
 maintainer="John <me@johnnynator.dev>"

Re: [PR PATCH] [Merged]: kdeconnect: add breeze-icons & kpeoplevcard to depends

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

There's a merged pull request on the void-packages repository

kdeconnect: add breeze-icons & kpeoplevcard to depends
https://github.com/void-linux/void-packages/pull/36761

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

kdeconnect appears to depend on breeze-icons for it's icons

without breeze-icons installed:
![2022-04-18 22:31:49](https://user-images.githubusercontent.com/486393/163912139-5e22f7fe-bd82-4ce3-8342-fef79e4ada5b.png)
with breeze-icons installed:
![2022-04-18 22:32:36](https://user-images.githubusercontent.com/486393/163912167-cf39261c-0b17-4f67-af70-8eeda711f21a.png)

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->