Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/build-style/cargo.sh: use offline install
@ 2022-05-07 23:48 0x5c
  2022-05-14  6:01 ` 0x5c
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: 0x5c @ 2022-05-07 23:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]

There is a new pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages rust-install-offline
https://github.com/void-linux/void-packages/pull/37029

common/build-style/cargo.sh: use offline install
This prevents `cargo install` from wasting time fetching the crate registry.

[CI skip]

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37029.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-install-offline-37029.patch --]
[-- Type: text/x-diff, Size: 888 bytes --]

From b4aa0acdb0d40ba08bf4fd3d4c92c41c480277b1 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Sat, 7 May 2022 19:41:22 -0400
Subject: [PATCH] common/build-style/cargo.sh: use offline install

This prevents `cargo install` from wasting time fetching the crate registry.

[CI skip]
---
 common/build-style/cargo.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/cargo.sh b/common/build-style/cargo.sh
index 573a69003614..4c456394df5b 100644
--- a/common/build-style/cargo.sh
+++ b/common/build-style/cargo.sh
@@ -20,7 +20,7 @@ do_install() {
 	: ${make_install_args:=--path .}
 
 	${make_cmd} install --target ${RUST_TARGET} --root="${DESTDIR}/usr" \
-		--locked ${configure_args} ${make_install_args}
+		--offline --locked ${configure_args} ${make_install_args}
 
 	rm -f "${DESTDIR}"/usr/.crates.toml
 	rm -f "${DESTDIR}"/usr/.crates2.json

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: common/build-style/cargo.sh: use offline install
  2022-05-07 23:48 [PR PATCH] common/build-style/cargo.sh: use offline install 0x5c
@ 2022-05-14  6:01 ` 0x5c
  2022-05-16 21:46 ` ericonr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: 0x5c @ 2022-05-14  6:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/37029#issuecomment-1126649677

Comment:
> Please don't add `[ci skip]` to the commit itself, it's enough in the PR description.

It got there because I was writing my commit message in so it could be the PR message as-is. Didn't think it fully through tho. I can remove it if you want

> Which packages have you tested with this?

I tested it with `riff` (https://github.com/void-linux/void-packages/pull/37013), but it should work for everything else since fetching the registry in the install phase doesn't have an effect in the first place because we use `--locked` in the install. So this gets rid of a long networked no-op that can fail (the `Updating crates.io index` line in the install phase).


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: common/build-style/cargo.sh: use offline install
  2022-05-07 23:48 [PR PATCH] common/build-style/cargo.sh: use offline install 0x5c
  2022-05-14  6:01 ` 0x5c
@ 2022-05-16 21:46 ` ericonr
  2022-05-17  8:13 ` [PR PATCH] [Updated] " 0x5c
  2022-05-17  8:14 ` 0x5c
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2022-05-16 21:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37029#issuecomment-1128169769

Comment:
>  I can remove it if you want

Please do :)

I'm going to try and test this around a bit.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] common/build-style/cargo.sh: use offline install
  2022-05-07 23:48 [PR PATCH] common/build-style/cargo.sh: use offline install 0x5c
  2022-05-14  6:01 ` 0x5c
  2022-05-16 21:46 ` ericonr
@ 2022-05-17  8:13 ` 0x5c
  2022-05-17  8:14 ` 0x5c
  3 siblings, 0 replies; 5+ messages in thread
From: 0x5c @ 2022-05-17  8:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

There is an updated pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages rust-install-offline
https://github.com/void-linux/void-packages/pull/37029

common/build-style/cargo.sh: use offline install
This prevents `cargo install` from wasting time fetching the crate registry.

[CI skip]

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37029.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-install-offline-37029.patch --]
[-- Type: text/x-diff, Size: 877 bytes --]

From ea27964de5bb72704430a19f81b39de7b8c463b2 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Sat, 7 May 2022 19:41:22 -0400
Subject: [PATCH] common/build-style/cargo.sh: use offline install

This prevents `cargo install` from wasting time fetching the crate registry.
---
 common/build-style/cargo.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/cargo.sh b/common/build-style/cargo.sh
index 573a69003614..4c456394df5b 100644
--- a/common/build-style/cargo.sh
+++ b/common/build-style/cargo.sh
@@ -20,7 +20,7 @@ do_install() {
 	: ${make_install_args:=--path .}
 
 	${make_cmd} install --target ${RUST_TARGET} --root="${DESTDIR}/usr" \
-		--locked ${configure_args} ${make_install_args}
+		--offline --locked ${configure_args} ${make_install_args}
 
 	rm -f "${DESTDIR}"/usr/.crates.toml
 	rm -f "${DESTDIR}"/usr/.crates2.json

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: common/build-style/cargo.sh: use offline install
  2022-05-07 23:48 [PR PATCH] common/build-style/cargo.sh: use offline install 0x5c
                   ` (2 preceding siblings ...)
  2022-05-17  8:13 ` [PR PATCH] [Updated] " 0x5c
@ 2022-05-17  8:14 ` 0x5c
  3 siblings, 0 replies; 5+ messages in thread
From: 0x5c @ 2022-05-17  8:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/37029#issuecomment-1128559101

Comment:
The commit message has been cleaned

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-17  8:14 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-07 23:48 [PR PATCH] common/build-style/cargo.sh: use offline install 0x5c
2022-05-14  6:01 ` 0x5c
2022-05-16 21:46 ` ericonr
2022-05-17  8:13 ` [PR PATCH] [Updated] " 0x5c
2022-05-17  8:14 ` 0x5c

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).