Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] erlang: switch to wxWidgets-gtk3
@ 2022-05-08  5:16 AviKav
  2022-05-14  1:13 ` ericonr
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: AviKav @ 2022-05-08  5:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 740 bytes --]

There is a new pull request by AviKav against master on the void-packages repository

https://github.com/AviKav/void-packages master
https://github.com/void-linux/void-packages/pull/37031

erlang: switch to wxWidgets-gtk3


#### Testing the changes
- I tested the changes in this PR: **briefly** (https://github.com/elixir-desktop/desktop-example-app)

- I built this PR locally for my native architecture, (x86_64-glibc)

This package seems to have been missed by #2664

As an aside, `kerl`/`asdf-erlang` needed `KERL_CONFIGURE_OPTIONS=--with-wx-config=wx-config-gtk3` for wxWebView to work. Not sure where that should be fixed/documented

A patch file from https://github.com/void-linux/void-packages/pull/37031.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-37031.patch --]
[-- Type: text/x-diff, Size: 1012 bytes --]

From 2c4e827cfdbf7bf57c72c1d058a50fe061b1b15f Mon Sep 17 00:00:00 2001
From: AviKav <avikav@avikav.net>
Date: Sat, 7 May 2022 04:38:15 -0400
Subject: [PATCH] erlang: switch to wxWidgets-gtk3

---
 srcpkgs/erlang/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/erlang/template b/srcpkgs/erlang/template
index d59eeb464e74..4b3df25204e9 100644
--- a/srcpkgs/erlang/template
+++ b/srcpkgs/erlang/template
@@ -1,7 +1,7 @@
 # Template file for 'erlang'
 pkgname=erlang
 version=24.3.2
-revision=1
+revision=2
 create_wrksrc=yes
 build_wrksrc="otp-OTP-${version}"
 build_style=gnu-configure
@@ -18,8 +18,8 @@ checksum=cdc9cf788d28a492eb6b24881fbd06a0a5c785dc374ad415b3be1db96326583c
 subpackages="erlang-doc"
 
 if [ -z "$CROSS_BUILD" ]; then
-	configure_args+=" --with-wx-config=wx-config-3.0"
-	makedepends+=" wxWidgets-devel glu-devel"
+	configure_args+=" --with-wx-config=wx-config-gtk3"
+	makedepends+=" wxWidgets-gtk3-devel glu-devel"
 	subpackages+=" erlang-wx"
 fi
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: erlang: switch to wxWidgets-gtk3
  2022-05-08  5:16 [PR PATCH] erlang: switch to wxWidgets-gtk3 AviKav
@ 2022-05-14  1:13 ` ericonr
  2022-05-15  1:50 ` [PR PATCH] [Closed]: " AviKav
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2022-05-14  1:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/37031#issuecomment-1126601667

Comment:
Please rebase your PR.

@leahneukirchen ok?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: erlang: switch to wxWidgets-gtk3
  2022-05-08  5:16 [PR PATCH] erlang: switch to wxWidgets-gtk3 AviKav
  2022-05-14  1:13 ` ericonr
@ 2022-05-15  1:50 ` AviKav
  2022-05-15  1:50 ` [PR PATCH] [Updated] " AviKav
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: AviKav @ 2022-05-15  1:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 592 bytes --]

There's a closed pull request on the void-packages repository

erlang: switch to wxWidgets-gtk3
https://github.com/void-linux/void-packages/pull/37031

Description:


#### Testing the changes
- I tested the changes in this PR: **briefly** (https://github.com/elixir-desktop/desktop-example-app)

- I built this PR locally for my native architecture, (x86_64-glibc)

This package seems to have been missed by #2664

As an aside, `kerl`/`asdf-erlang` needed `KERL_CONFIGURE_OPTIONS=--with-wx-config=wx-config-gtk3` for wxWebView to work. Not sure where that should be fixed/documented

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] erlang: switch to wxWidgets-gtk3
  2022-05-08  5:16 [PR PATCH] erlang: switch to wxWidgets-gtk3 AviKav
  2022-05-14  1:13 ` ericonr
  2022-05-15  1:50 ` [PR PATCH] [Closed]: " AviKav
@ 2022-05-15  1:50 ` AviKav
  2022-05-15  1:56 ` AviKav
  2022-05-15  1:58 ` AviKav
  4 siblings, 0 replies; 6+ messages in thread
From: AviKav @ 2022-05-15  1:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

There is an updated pull request by AviKav against master on the void-packages repository

https://github.com/AviKav/void-packages master
https://github.com/void-linux/void-packages/pull/37031

erlang: switch to wxWidgets-gtk3


#### Testing the changes
- I tested the changes in this PR: **briefly** (https://github.com/elixir-desktop/desktop-example-app)

- I built this PR locally for my native architecture, (x86_64-glibc)

This package seems to have been missed by #2664

As an aside, `kerl`/`asdf-erlang` needed `KERL_CONFIGURE_OPTIONS=--with-wx-config=wx-config-gtk3` for wxWebView to work. Not sure where that should be fixed/documented

A patch file from https://github.com/void-linux/void-packages/pull/37031.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-37031.patch --]
[-- Type: text/x-diff, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Updated] erlang: switch to wxWidgets-gtk3
  2022-05-08  5:16 [PR PATCH] erlang: switch to wxWidgets-gtk3 AviKav
                   ` (2 preceding siblings ...)
  2022-05-15  1:50 ` [PR PATCH] [Updated] " AviKav
@ 2022-05-15  1:56 ` AviKav
  2022-05-15  1:58 ` AviKav
  4 siblings, 0 replies; 6+ messages in thread
From: AviKav @ 2022-05-15  1:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

There is an updated pull request by AviKav against master on the void-packages repository

https://github.com/AviKav/void-packages master
https://github.com/void-linux/void-packages/pull/37031

erlang: switch to wxWidgets-gtk3


#### Testing the changes
- I tested the changes in this PR: **briefly** (https://github.com/elixir-desktop/desktop-example-app)

- I built this PR locally for my native architecture, (x86_64-glibc)

This package seems to have been missed by #2664

As an aside, `kerl`/`asdf-erlang` needed `KERL_CONFIGURE_OPTIONS=--with-wx-config=wx-config-gtk3` for wxWebView to work. Not sure where that should be fixed/documented

A patch file from https://github.com/void-linux/void-packages/pull/37031.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-37031.patch --]
[-- Type: text/x-diff, Size: 1012 bytes --]

From f598b5a637df2af7522cca255285d20c38e050a0 Mon Sep 17 00:00:00 2001
From: AviKav <avikav@avikav.net>
Date: Sat, 7 May 2022 04:38:15 -0400
Subject: [PATCH] erlang: switch to wxWidgets-gtk3

---
 srcpkgs/erlang/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/erlang/template b/srcpkgs/erlang/template
index fb0fa77fc4c4..df05095e4398 100644
--- a/srcpkgs/erlang/template
+++ b/srcpkgs/erlang/template
@@ -1,7 +1,7 @@
 # Template file for 'erlang'
 pkgname=erlang
 version=24.3.4
-revision=1
+revision=2
 create_wrksrc=yes
 build_wrksrc="otp-OTP-${version}"
 build_style=gnu-configure
@@ -18,8 +18,8 @@ checksum=e59bedbb871af52244ca5284fd0a572d52128abd4decf4347fe2aef047b65c58
 subpackages="erlang-doc"
 
 if [ -z "$CROSS_BUILD" ]; then
-	configure_args+=" --with-wx-config=wx-config-3.0"
-	makedepends+=" wxWidgets-devel glu-devel"
+	configure_args+=" --with-wx-config=wx-config-gtk3"
+	makedepends+=" wxWidgets-gtk3-devel glu-devel"
 	subpackages+=" erlang-wx"
 fi
 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: erlang: switch to wxWidgets-gtk3
  2022-05-08  5:16 [PR PATCH] erlang: switch to wxWidgets-gtk3 AviKav
                   ` (3 preceding siblings ...)
  2022-05-15  1:56 ` AviKav
@ 2022-05-15  1:58 ` AviKav
  4 siblings, 0 replies; 6+ messages in thread
From: AviKav @ 2022-05-15  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by AviKav on void-packages repository

https://github.com/void-linux/void-packages/pull/37031#issuecomment-1126841608

Comment:
Sorry, force pushed [e4327f9](https://github.com/void-linux/void-packages/commit/e4327f92d30923a630a584002583105f0543e541) by accident which made github think the PR should be closed

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-15  1:58 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-08  5:16 [PR PATCH] erlang: switch to wxWidgets-gtk3 AviKav
2022-05-14  1:13 ` ericonr
2022-05-15  1:50 ` [PR PATCH] [Closed]: " AviKav
2022-05-15  1:50 ` [PR PATCH] [Updated] " AviKav
2022-05-15  1:56 ` AviKav
2022-05-15  1:58 ` AviKav

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).