Github messages for voidlinux
 help / color / mirror / Atom feed
From: dmarto <dmarto@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] python3-chardet: fix split with python2 pkg, revbump
Date: Mon, 09 May 2022 18:48:05 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37061@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

There is a new pull request by dmarto against master on the void-packages repository

https://github.com/dmarto/void-packages chardet
https://github.com/void-linux/void-packages/pull/37061

python3-chardet: fix split with python2 pkg, revbump
The current template is broken, and won't build a working package. Currently all works, just because there wasn't a revbump since the split.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**

I tested an update from the previous rev to this, there were no problems with the alternatives.
Also, as the python2 pkg still exists in the repos, I made them `conflict` to ensure there won't be any strange behaviour with alts. 

A patch file from https://github.com/void-linux/void-packages/pull/37061.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chardet-37061.patch --]
[-- Type: text/x-diff, Size: 1408 bytes --]

From 0d530984e3de0bc4302a11312484fc6a2652911d Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Mon, 9 May 2022 18:29:26 +0300
Subject: [PATCH] python3-chardet: fix split with python2 pkg, revbump

Fix depends.
Drop alternatives (wrong and also obsolete).

Add conflict with the python2 version of the pkgs (as it still exist
in the official bin repos) to ensure that there won't be any issues.
---
 srcpkgs/python3-chardet/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-chardet/template b/srcpkgs/python3-chardet/template
index bc5dfe6ee5ec..e4e30c7b8940 100644
--- a/srcpkgs/python3-chardet/template
+++ b/srcpkgs/python3-chardet/template
@@ -1,11 +1,11 @@
 # Template file for 'python3-chardet'
 pkgname=python3-chardet
 version=4.0.0
-revision=3
+revision=4
 wrksrc="chardet-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools"
+depends="python3"
 checkdepends="python3-pytest"
 short_desc="Universal encoding detector"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
@@ -13,4 +13,4 @@ license="LGPL-2.1-only"
 homepage="https://github.com/chardet/chardet"
 distfiles="${PYPI_SITE}/c/chardet/chardet-${version}.tar.gz"
 checksum=0d6f53a15db4120f2b08c94f11e7d93d2c911ee118b6b30a04ec3ee8310179fa
-alternatives="chardet:chardetect:/usr/bin/chardetect2"
+conflicts="python-chardet"

             reply	other threads:[~2022-05-09 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 16:48 dmarto [this message]
2022-05-10  7:37 ` [PR REVIEW] " classabbyamp
2022-05-10  8:05 ` dmarto
2022-05-22 11:33 ` ahesford
2022-05-22 11:33 ` [PR PATCH] [Merged]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37061@inbox.vuxu.org \
    --to=dmarto@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).