[PR PATCH] python3-chardet: fix split with python2 pkg, revbump

[PR PATCH] python3-chardet: fix split with python2 pkg, revbump

[dmarto]

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

There is a new pull request by dmarto against master on the void-packages repository

https://github.com/dmarto/void-packages chardet
https://github.com/void-linux/void-packages/pull/37061

python3-chardet: fix split with python2 pkg, revbump
The current template is broken, and won't build a working package. Currently all works, just because there wasn't a revbump since the split.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**

I tested an update from the previous rev to this, there were no problems with the alternatives.
Also, as the python2 pkg still exists in the repos, I made them `conflict` to ensure there won't be any strange behaviour with alts. 

A patch file from https://github.com/void-linux/void-packages/pull/37061.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chardet-37061.patch --]
[-- Type: text/x-diff, Size: 1408 bytes --]

From 0d530984e3de0bc4302a11312484fc6a2652911d Mon Sep 17 00:00:00 2001
From: Martin Dimov <martin@dmarto.com>
Date: Mon, 9 May 2022 18:29:26 +0300
Subject: [PATCH] python3-chardet: fix split with python2 pkg, revbump

Fix depends.
Drop alternatives (wrong and also obsolete).

Add conflict with the python2 version of the pkgs (as it still exist
in the official bin repos) to ensure that there won't be any issues.
---
 srcpkgs/python3-chardet/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-chardet/template b/srcpkgs/python3-chardet/template
index bc5dfe6ee5ec..e4e30c7b8940 100644
--- a/srcpkgs/python3-chardet/template
+++ b/srcpkgs/python3-chardet/template
@@ -1,11 +1,11 @@
 # Template file for 'python3-chardet'
 pkgname=python3-chardet
 version=4.0.0
-revision=3
+revision=4
 wrksrc="chardet-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-setuptools"
+depends="python3"
 checkdepends="python3-pytest"
 short_desc="Universal encoding detector"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
@@ -13,4 +13,4 @@ license="LGPL-2.1-only"
 homepage="https://github.com/chardet/chardet"
 distfiles="${PYPI_SITE}/c/chardet/chardet-${version}.tar.gz"
 checksum=0d6f53a15db4120f2b08c94f11e7d93d2c911ee118b6b30a04ec3ee8310179fa
-alternatives="chardet:chardetect:/usr/bin/chardetect2"
+conflicts="python-chardet"

Re: [PR REVIEW] python3-chardet: fix split with python2 pkg, revbump

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37061#discussion_r868797027

Comment:
i don't think the `conflicts` is necessary, the py2 version is a removed package

Re: [PR REVIEW] python3-chardet: fix split with python2 pkg, revbump

[dmarto]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New review comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/pull/37061#discussion_r868941684

Comment:
True, but it still exists in the repos and can be installed (or someone could have it installed and ignored), and as we all know the `alternatives` do have some issues. So, isn't it better to keep it around until the pkg is removed from the repos as well? 

Re: [PR REVIEW] python3-chardet: fix split with python2 pkg, revbump

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 351 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/37061#discussion_r878845210

Comment:
We have been converting alternatives to conflicts when dropping py2 packages to provide some explicit indicator for people who might keep the py2 package around. This is consistent with broader practice.

Re: [PR PATCH] [Merged]: python3-chardet: fix split with python2 pkg, revbump

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

There's a merged pull request on the void-packages repository

python3-chardet: fix split with python2 pkg, revbump
https://github.com/void-linux/void-packages/pull/37061

Description:
The current template is broken, and won't build a working package. Currently all works, just because there wasn't a revbump since the split.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, **x86_64-glibc**

I tested an update from the previous rev to this, there were no problems with the alternatives.
Also, as the python2 pkg still exists in the repos, I made them `conflict` to ensure there won't be any strange behaviour with alts.