Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: ruby-webrick-1.7.0
@ 2022-05-23 22:39 Benjamin-L
  2022-05-24 17:56 ` [PR PATCH] [Closed]: " Chocimier
  2022-05-24 17:56 ` Chocimier
  0 siblings, 2 replies; 3+ messages in thread
From: Benjamin-L @ 2022-05-23 22:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

There is a new pull request by Benjamin-L against master on the void-packages repository

https://github.com/Benjamin-L/void-packages new-package-ruby-webrick
https://github.com/void-linux/void-packages/pull/37261

New package: ruby-webrick-1.7.0
Webrick used to be included in the ruby standard library, but was [removed][1] in version 3.0 due to security and maintenance concerns. It is needed to run the tests for `rset`, which I am attempting to package in #31003.

[1]: https://bugs.ruby-lang.org/issues/17303

#### Testing the changes
- I tested the changes in this PR: **briefly**

In addition to running the built-in tests in the check stage, I ran the minimal example from the webrick README, which went fine. I don't actually use this package myself, and didn't perform any more extensive testing.

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl (crossbuild)
  - armv7l (crossbuild)
  - armv6l-musl (crossbuild)


A patch file from https://github.com/void-linux/void-packages/pull/37261.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-ruby-webrick-37261.patch --]
[-- Type: text/x-diff, Size: 948 bytes --]

From 5af025436760ced5fccbdc979ee5875fa3d53a1b Mon Sep 17 00:00:00 2001
From: Benjamin Lee <benjamin@typ3.tech>
Date: Mon, 23 May 2022 15:20:23 -0700
Subject: [PATCH] New package: ruby-webrick-1.7.0

---
 srcpkgs/ruby-webrick/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/ruby-webrick/template

diff --git a/srcpkgs/ruby-webrick/template b/srcpkgs/ruby-webrick/template
new file mode 100644
index 000000000000..f84388454b06
--- /dev/null
+++ b/srcpkgs/ruby-webrick/template
@@ -0,0 +1,18 @@
+# Template file for 'ruby-webrick'
+pkgname=ruby-webrick
+version=1.7.0
+revision=1
+build_style=gem
+short_desc="Ruby HTTP server toolkit"
+maintainer="Benjamin Lee <benjamin@typ3.tech>"
+license="BSD-2-Clause"
+homepage="https://github.com/ruby/webrick"
+checksum=87e9b8e39947b7925338a5eb55427b11ce1f2b25a3645770ec9f39d8ebdb8cb4
+
+do_check() {
+	rake test
+}
+
+post_install() {
+	vlicense LICENSE.txt
+}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New package: ruby-webrick-1.7.0
  2022-05-23 22:39 [PR PATCH] New package: ruby-webrick-1.7.0 Benjamin-L
  2022-05-24 17:56 ` [PR PATCH] [Closed]: " Chocimier
@ 2022-05-24 17:56 ` Chocimier
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2022-05-24 17:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37261#issuecomment-1136266073

Comment:
Dependencies should be put in same PR so that CI will run.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Closed]: New package: ruby-webrick-1.7.0
  2022-05-23 22:39 [PR PATCH] New package: ruby-webrick-1.7.0 Benjamin-L
@ 2022-05-24 17:56 ` Chocimier
  2022-05-24 17:56 ` Chocimier
  1 sibling, 0 replies; 3+ messages in thread
From: Chocimier @ 2022-05-24 17:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

There's a closed pull request on the void-packages repository

New package: ruby-webrick-1.7.0
https://github.com/void-linux/void-packages/pull/37261

Description:
Webrick used to be included in the ruby standard library, but was [removed][1] in version 3.0 due to security and maintenance concerns. It is needed to run the tests for `rset`, which I am attempting to package in #31003.

[1]: https://bugs.ruby-lang.org/issues/17303

#### Testing the changes
- I tested the changes in this PR: **briefly**

In addition to running the built-in tests in the check stage, I ran the minimal example from the webrick README, which went fine. I don't actually use this package myself, and didn't perform any more extensive testing.

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl (crossbuild)
  - armv7l (crossbuild)
  - armv6l-musl (crossbuild)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-24 17:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 22:39 [PR PATCH] New package: ruby-webrick-1.7.0 Benjamin-L
2022-05-24 17:56 ` [PR PATCH] [Closed]: " Chocimier
2022-05-24 17:56 ` Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).