From: JamiKettunen <JamiKettunen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] json-c++: run all tests that don't require a git checkout
Date: Wed, 25 May 2022 15:31:41 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37291@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
There is a new pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages json-c++-tests
https://github.com/void-linux/void-packages/pull/37291
json-c++: run all tests that don't require a git checkout
<!-- Uncomment relevant sections and delete options which are not applicable -->
Running the unit tests (including without a git checkout) [is documented here](https://github.com/nlohmann/json#execute-unit-tests).
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/37291.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-json-c++-tests-37291.patch --]
[-- Type: text/x-diff, Size: 1139 bytes --]
From 2cfb494f627abe469e86fac6ead5ccc31cd1b707 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Wed, 25 May 2022 16:08:38 +0300
Subject: [PATCH] json-c++: run all tests that don't require a git checkout
---
srcpkgs/json-c++/template | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/json-c++/template b/srcpkgs/json-c++/template
index 018ef8e1ff74..c0f8729ed021 100644
--- a/srcpkgs/json-c++/template
+++ b/srcpkgs/json-c++/template
@@ -1,7 +1,7 @@
# Template file for 'json-c++'
pkgname=json-c++
version=3.10.5
-revision=1
+revision=2
wrksrc="json-${version}"
build_style=cmake
configure_args="-DJSON_MultipleHeaders=ON"
@@ -12,9 +12,12 @@ license="MIT"
homepage="https://github.com/nlohmann/json"
distfiles="https://github.com/nlohmann/json/archive/v${version}.tar.gz"
checksum=5daca6ca216495edf89d167f808d1d03c4a4d929cef7da5e10f135ae1540c7e4
-# tests only work in git repository
-make_check=no
+do_check() {
+ # skip tests requiring wrksrc to be a git clone as they always fail
+ cd build
+ ctest -LE "git_required"
+}
post_install() {
vdoc README.md
next reply other threads:[~2022-05-25 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 13:31 JamiKettunen [this message]
2022-05-25 14:18 ` [PR PATCH] [Updated] " JamiKettunen
2022-05-26 4:22 ` sgn
2022-05-26 19:53 ` [PR PATCH] [Updated] " JamiKettunen
2022-05-27 15:46 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37291@inbox.vuxu.org \
--to=jamikettunen@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).