[PR PATCH] Manual.md: recommend keeping systemd units

[PR PATCH] Manual.md: recommend keeping systemd units

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages systemd
https://github.com/void-linux/void-packages/pull/37395

Manual.md: recommend keeping systemd units
Closes #32481

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **N/A**


A patch file from https://github.com/void-linux/void-packages/pull/37395.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-systemd-37395.patch --]
[-- Type: text/x-diff, Size: 832 bytes --]

From a4aec302583d13bd96bc72bd71ad85e905f40276 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 2 Jun 2022 11:58:53 -0700
Subject: [PATCH] Manual.md: recommend keeping systemd units

Closes #32481
---
 Manual.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Manual.md b/Manual.md
index 8afe781f0ec1..33eb02735c3f 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1410,6 +1410,9 @@ If the service requires directories in parts of the system that are not generall
 temporary filesystems. Then use the `make_dirs` variable in the template to create
 those directories when the package is installed.
 
+If the package installs a systemd service file or other unit, leave it in place as a
+reference point so long as including it has no negative side effects.
+
 <a id="32bit_pkgs"></a>
 ### 32bit packages
 

Re: Manual.md: recommend keeping systemd units

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37395#issuecomment-1146227122

Comment:
What are possible negative side effects?

Re: Manual.md: recommend keeping systemd units

[Anachron]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/pull/37395#issuecomment-1147802141

Comment:
Also closes https://github.com/void-linux/void-packages/issues/32154

About the side effects: 
Some packages do check for systemd service files on runtime and try to start/stop when being found.
So I guess if we packaged them and keep the systemd.service files those programs might cause unexpected behavior on Void.

Re: Manual.md: recommend keeping systemd units

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37395#issuecomment-1147809505

Comment:
One scenario I had in mind was if there was some configure flag that installed the units but also changed the runtime of the service in some way. I did not want packagers feeling like they had to install units in that case, or patch the software to get around it. It is just sort of a generic out, letting the packager know they won't get dinged if they exclude the units.

Re: Manual.md: recommend keeping systemd units

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 534 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37395#issuecomment-1147809505

Comment:
One scenario I had in mind was if there was some configure flag that installed the units but also changed the runtime or dependencies of the package in some way. I did not want packagers feeling like they had to install units in that case, or patch the software to get around it. It is just sort of a generic out, letting the packager know they won't get dinged if they exclude the units.

Re: Manual.md: recommend keeping systemd units

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37395#issuecomment-1192728555

Comment:
> installed the units but also changed the runtime or dependencies of the package in some way

Okay, please mention this as example in manual.

Re: [PR PATCH] [Updated] Manual.md: recommend keeping systemd units

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

There is an updated pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages systemd
https://github.com/void-linux/void-packages/pull/37395

Manual.md: recommend keeping systemd units
Closes #32481

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **N/A**


A patch file from https://github.com/void-linux/void-packages/pull/37395.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-systemd-37395.patch --]
[-- Type: text/x-diff, Size: 1054 bytes --]

From d486316769de6eaa9863724f50d17682c8b69825 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 2 Jun 2022 11:58:53 -0700
Subject: [PATCH] Manual.md: recommend keeping systemd units

Ref #32154
Closes #32481
---
 Manual.md | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Manual.md b/Manual.md
index 0f16aeb3875c..2f17549d52bf 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1415,6 +1415,14 @@ If the service requires directories in parts of the system that are not generall
 temporary filesystems. Then use the `make_dirs` variable in the template to create
 those directories when the package is installed.
 
+If the package installs a systemd service file or other unit, leave it in place as a
+reference point so long as including it has no negative side effects.
+
+Examples of when *not* to install systemd units:
+
+1. When doing so changes runtime behavior of the packaged software.
+2. When it is done via a compile time flag that also changes build dependencies.
+
 <a id="32bit_pkgs"></a>
 ### 32bit packages
 

Re: Manual.md: recommend keeping systemd units

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/37395#issuecomment-1194802590

Comment:
Alright added the examples.

Re: [PR PATCH] [Merged]: Manual.md: recommend keeping systemd units

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

There's a merged pull request on the void-packages repository

Manual.md: recommend keeping systemd units
https://github.com/void-linux/void-packages/pull/37395

Description:
Closes #32481

[ci skip]

#### Testing the changes
- I tested the changes in this PR: **N/A**