Github messages for voidlinux
 help / color / mirror / Atom feed
From: PaperStork <PaperStork@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] scaleway-cli: fix version in build
Date: Tue, 07 Jun 2022 13:16:58 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37433@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is a new pull request by PaperStork against master on the void-packages repository

https://github.com/PaperStork/void-packages master
https://github.com/void-linux/void-packages/pull/37433

scaleway-cli: fix version in build
<!-- Uncomment relevant sections and delete options which are not applicable -->

The version reported by the CLI was "2.0.0-dev" due to a missing build option. It is now the correct version ($VERSION-$REVISION).

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)



A patch file from https://github.com/void-linux/void-packages/pull/37433.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-37433.patch --]
[-- Type: text/x-diff, Size: 896 bytes --]

From 02ff7456a5929a259895cb025c8d5e1d915e8a19 Mon Sep 17 00:00:00 2001
From: PaperStork <vincent.hour.del@gmail.com>
Date: Tue, 7 Jun 2022 13:12:21 +0200
Subject: [PATCH] scaleway-cli: fix version in build

---
 srcpkgs/scaleway-cli/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/scaleway-cli/template b/srcpkgs/scaleway-cli/template
index caad6e99dde0..a2c2d0baad57 100644
--- a/srcpkgs/scaleway-cli/template
+++ b/srcpkgs/scaleway-cli/template
@@ -1,10 +1,11 @@
 # Template file for 'scaleway-cli'
 pkgname=scaleway-cli
 version=2.5.1
-revision=1
+revision=2
 build_style=go
 go_import_path=github.com/scaleway/scaleway-cli
 go_package=github.com/scaleway/scaleway-cli/cmd/scw
+go_ldflags="-X main.Version=$version-$revision"
 short_desc="Interact with the Scaleway API from the command line"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"

             reply	other threads:[~2022-06-07 11:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 11:16 PaperStork [this message]
2022-06-07 15:39 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37433@inbox.vuxu.org \
    --to=paperstork@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).