[PR PATCH] vice: update to 3.6.1.

[PR PATCH] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]

There is a new pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.6.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 3297 bytes --]

From d88f53b21188e1378d61ecf2a40f5c9eed970883 Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.6.1.

---
 srcpkgs/vice/files/desktop-install.sh |  3 ++
 srcpkgs/vice/template                 | 54 +++++++--------------------
 2 files changed, 16 insertions(+), 41 deletions(-)
 create mode 100755 srcpkgs/vice/files/desktop-install.sh

diff --git a/srcpkgs/vice/files/desktop-install.sh b/srcpkgs/vice/files/desktop-install.sh
new file mode 100755
index 000000000000..823c4f50569a
--- /dev/null
+++ b/srcpkgs/vice/files/desktop-install.sh
@@ -0,0 +1,3 @@
+#!/bin/sh -e
+dir=$DESTDIR/usr/share/applications/
+[ "$1" = install ] && mkdir -p $dir && shift && for f; do cp $f $dir; done
diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..eab0f976095d 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,57 +1,29 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.6.1
 revision=1
 build_style=gnu-configure
-configure_args="
-	$(vopt_enable sdl2 sdlui2)
-	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
-	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
-	--enable-cpuhistory
-	--enable-x64
-	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
-makedepends="
-	zlib-devel
-	readline-devel
-	libpng-devel
-	giflib-devel
-	glew-devel
-	alsa-lib-devel
-	$(vopt_if sdl2 SDL2_mixer-devel)
-	$(vopt_if sdl2 SDL2-devel)
-	$(vopt_if gtk3 gtk+3-devel)
-	$(vopt_if gtk3 pulseaudio-devel)
-	$(vopt_if gtk3 pango-devel)
-	$(vopt_if ffmpeg ffmpeg-devel)"
+configure_args="XDG_DESKTOP_MENU=${FILESDIR}/desktop-install.sh
+ --libdir=/usr/lib$XBPS_TARGET_WORDSIZE
+ --enable-cpuhistory --enable-x64 --disable-pdf-docs
+ $(vopt_enable sdl2 sdlui2) $(vopt_with sdl2 sdlsound)
+ $(vopt_enable gtk3 native-gtk3ui) $(vopt_enable gtk3 desktop-files)
+ $(vopt_with gtk3 pulse) $(vopt_enable ffmpeg external-ffmpeg)"
+hostmakedepends="pkgconf flex dos2unix xa perl glib-devel"
+makedepends="zlib-devel readline-devel libpng-devel glew-devel alsa-lib-devel
+ $(vopt_if sdl2 SDL2-devel) $(vopt_if sdl2 SDL2_mixer-devel)
+ $(vopt_if gtk3 gtk+3-devel) $(vopt_if gtk3 pulseaudio-devel)
+ $(vopt_if gtk3 pango-devel) $(vopt_if ffmpeg ffmpeg-devel)"
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="http://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=20df84c851aaf2f5000510927f6d31b32f269916d351465c366dc0afc9dc150c
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
 build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
-
-CFLAGS="-fcommon"
-
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
-
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
-}

Re: [PR REVIEW] vice: update to 3.6.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r894675757

Comment:
```suggestion
homepage="https://vice-emu.sourceforge.net/"
```

Re: [PR REVIEW] vice: update to 3.6.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r894683155

Comment:
Is there a reason why you didn't just add xdg-utils to hostmakedepends?

Re: [PR REVIEW] vice: update to 3.6.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r894675652

Comment:
I would prefer if we could keep this in the old format, it would make the whole PR much easier to review.

Re: [PR REVIEW] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r894743716

Comment:
@paper42 it didn't install properly into DESTDIR, I'm not sure if there's some XDG_ env var that needs to be set for it to work

Re: [PR PATCH] [Updated] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.6.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 2807 bytes --]

From 61469b9f30caad6916a8e160e4641d4b89382577 Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.6.1.

---
 srcpkgs/vice/files/desktop-install.sh |  3 +++
 srcpkgs/vice/template                 | 32 ++++++++-------------------
 2 files changed, 12 insertions(+), 23 deletions(-)
 create mode 100755 srcpkgs/vice/files/desktop-install.sh

diff --git a/srcpkgs/vice/files/desktop-install.sh b/srcpkgs/vice/files/desktop-install.sh
new file mode 100755
index 000000000000..823c4f50569a
--- /dev/null
+++ b/srcpkgs/vice/files/desktop-install.sh
@@ -0,0 +1,3 @@
+#!/bin/sh -e
+dir=$DESTDIR/usr/share/applications/
+[ "$1" = install ] && mkdir -p $dir && shift && for f; do cp $f $dir; done
diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..d28ef75a9573 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,26 +1,25 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.6.1
 revision=1
 build_style=gnu-configure
 configure_args="
 	$(vopt_enable sdl2 sdlui2)
 	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
+	$(vopt_enable gtk3 native-gtk3ui)
+	$(vopt_enable gtk3 desktop-files)
 	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
+	$(vopt_enable ffmpeg external-ffmpeg)
 	--enable-cpuhistory
 	--enable-x64
 	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
+	--libdir=/usr/lib$XBPS_TARGET_WORDSIZE
+	XDG_DESKTOP_MENU=${FILESDIR}/desktop-install.sh"
+hostmakedepends="pkgconf flex dos2unix xa perl glib-devel"
 makedepends="
 	zlib-devel
 	readline-devel
 	libpng-devel
-	giflib-devel
 	glew-devel
 	alsa-lib-devel
 	$(vopt_if sdl2 SDL2_mixer-devel)
@@ -32,26 +31,13 @@ makedepends="
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://vice-emu.sourceforge.net/"
+homepage="https://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=20df84c851aaf2f5000510927f6d31b32f269916d351465c366dc0afc9dc150c
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
 build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
-
-CFLAGS="-fcommon"
-
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
-
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
-}

Re: vice: update to 3.6.1.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#issuecomment-1241420678

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#issuecomment-1242656460

Comment:
bump

Re: [PR REVIEW] vice: update to 3.6.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r967631585

Comment:
Did you try XDG_DATA_DIRS?

Re: [PR REVIEW] vice: update to 3.6.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r967623841

Comment:
pkg-config

Re: [PR REVIEW] vice: update to 3.6.1.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r967624170

Comment:
--libdir should already be set by the gnu-configure build style

Re: [PR REVIEW] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

New review comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r967860267

Comment:
Not specifying it there causes 
```
=== configuring in src/resid (/builddir/vice-3.6.1/src/resid)
configure: running /bin/sh ./configure '--prefix=/usr' --disable-option-checking  '--sysconfdir=/etc' '--sbindir=/usr/bin' '--bindir=/usr/bin' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--localstatedir=/var' '--host=x86_64-unknown-linux-gnu' '--build=x86_64-unknown-linux-gnu' '--libdir=NONE/lib64' '--disable-sdlui2' '--without-sdlsound' '--enable-native-gtk3ui' '--enable-desktop-files' '--with-pulse' '--enable-external-ffmpeg' '--enable-cpuhistory' '--enable-x64' '--disable-pdf-docs' 'build_alias=x86_64-unknown-linux-gnu' 'host_alias=x86_64-unknown-linux-gnu' 'CC=cc' 'CFLAGS=-fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -fdebug-prefix-map=/builddir/vice-3.6.1=.' 'LDFLAGS=-Wl,-z,relro -Wl,-z,now -Wl,--as-needed    ' 'CPPFLAGS=
 ' 'CPP=cpp' 'CXX=g++' 'CXXFLAGS=-fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -fdebug-prefix-map=/builddir/vice-3.6.1=.' 'PKG_CONFIG=pkg-config' '--disable-option-checking' '--srcdir=.' --cache-file=
configure: error: expected an absolute directory name for --libdir: NONE/lib64
configure: error: ./configure failed for src/resid
=> ERROR: vice-3.6.1_1: do_configure: '${configure_script} ${configure_args}' exited with 1
```

Re: [PR REVIEW] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]

New review comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r967860267

Comment:
Not specifying it there causes 
```
=== configuring in src/resid (/builddir/vice-3.6.1/src/resid)
configure: running /bin/sh ./configure '--prefix=/usr' --disable-option-checking  '--sysconfdir=/etc' '--sbindir=/usr/bin' '--bindir=/usr/bin' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--localstatedir=/var' '--host=x86_64-unknown-linux-gnu' '--build=x86_64-unknown-linux-gnu' '--libdir=NONE/lib64' '--disable-sdlui2' '--without-sdlsound' '--enable-native-gtk3ui' '--enable-desktop-files' '--with-pulse' '--enable-external-ffmpeg' '--enable-cpuhistory' '--enable-x64' '--disable-pdf-docs' 'build_alias=x86_64-unknown-linux-gnu' 'host_alias=x86_64-unknown-linux-gnu' 'CC=cc' 'CFLAGS=-fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -fdebug-prefix-map=/builddir/vice-3.6.1=.' 'LDFLAGS=-Wl,-z,relro -Wl,-z,now -Wl,--as-needed    ' 'CPPFLAGS=
 ' 'CPP=cpp' 'CXX=g++' 'CXXFLAGS=-fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -O2 -pipe    -fdebug-prefix-map=/builddir/vice-3.6.1=.' 'PKG_CONFIG=pkg-config' '--disable-option-checking' '--srcdir=.' --cache-file=
configure: error: expected an absolute directory name for --libdir: NONE/lib64
configure: error: ./configure failed for src/resid
=> ERROR: vice-3.6.1_1: do_configure: '${configure_script} ${configure_args}' exited with 1
```
(presumably it's lack of exec_prefix somewhere)

Re: [PR PATCH] [Updated] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.6.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 2634 bytes --]

From 3bfefda9b66fc2a43841e8311f298cd18cc38def Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.6.1.

---
 srcpkgs/vice/template | 34 +++++++++++++++-------------------
 1 file changed, 15 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..3dc6cbb0d2f8 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,26 +1,24 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.6.1
 revision=1
 build_style=gnu-configure
 configure_args="
 	$(vopt_enable sdl2 sdlui2)
 	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
+	$(vopt_enable gtk3 native-gtk3ui)
+	$(vopt_enable gtk3 desktop-files)
 	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
+	$(vopt_enable ffmpeg external-ffmpeg)
 	--enable-cpuhistory
 	--enable-x64
 	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
+	--libdir=/usr/lib$XBPS_TARGET_WORDSIZE"
+hostmakedepends="pkg-config flex dos2unix xa perl glib-devel xdg-utils"
 makedepends="
 	zlib-devel
 	readline-devel
 	libpng-devel
-	giflib-devel
 	glew-devel
 	alsa-lib-devel
 	$(vopt_if sdl2 SDL2_mixer-devel)
@@ -32,10 +30,10 @@ makedepends="
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://vice-emu.sourceforge.net/"
+homepage="https://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=20df84c851aaf2f5000510927f6d31b32f269916d351465c366dc0afc9dc150c
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
@@ -43,15 +41,13 @@ build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
 
-CFLAGS="-fcommon"
+export XDG_DATA_DIRS=$DESTDIR/usr/share
 
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
+post_patch() {
+	sed -i -e 's/\$(XDG_DESKTOP_MENU) install/$(XDG_DESKTOP_MENU) install --mode system/' src/arch/gtk3/data/unix/Makefile.in
+}
 
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
+pre_install() {
+	# required for xdg-desktop-menu to work
+	mkdir -p $DESTDIR/usr/share/{applications,desktop-directories}
 }

Re: [PR REVIEW] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r967863929

Comment:
Ah, I did but it needs directories to exist already

Re: vice: update to 3.6.1.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#issuecomment-1345434000

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#issuecomment-1345440849

Comment:
bump

Re: vice: update to 3.6.1.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#issuecomment-1465070413

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by ypsvlq on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#issuecomment-1465122052

Comment:
bump i guess

Re: [PR REVIEW] vice: update to 3.6.1.

[zlice]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New review comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r1160979183

Comment:
do a `configure_args+=` and see if that works w/o the `--libdir`?

Re: [PR REVIEW] vice: update to 3.6.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r1240918908

Comment:
use vsed

Re: [PR REVIEW] vice: update to 3.6.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37480#discussion_r1240918892

Comment:
use vmkdir

Re: [PR PATCH] [Updated] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.6.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From 33b3a659607050daa95c12165897da53e69c65a1 Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.6.1.

---
 srcpkgs/vice/template | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..fc69890183cd 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,26 +1,24 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.6.1
 revision=1
 build_style=gnu-configure
 configure_args="
 	$(vopt_enable sdl2 sdlui2)
 	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
+	$(vopt_enable gtk3 native-gtk3ui)
+	$(vopt_enable gtk3 desktop-files)
 	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
+	$(vopt_enable ffmpeg external-ffmpeg)
 	--enable-cpuhistory
 	--enable-x64
 	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
+	--libdir=/usr/lib$XBPS_TARGET_WORDSIZE"
+hostmakedepends="pkg-config flex dos2unix xa perl glib-devel xdg-utils"
 makedepends="
 	zlib-devel
 	readline-devel
 	libpng-devel
-	giflib-devel
 	glew-devel
 	alsa-lib-devel
 	$(vopt_if sdl2 SDL2_mixer-devel)
@@ -32,10 +30,10 @@ makedepends="
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://vice-emu.sourceforge.net/"
+homepage="https://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=20df84c851aaf2f5000510927f6d31b32f269916d351465c366dc0afc9dc150c
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
@@ -43,15 +41,14 @@ build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
 
-CFLAGS="-fcommon"
+export XDG_DATA_DIRS=$DESTDIR/usr/share
 
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
+post_patch() {
+	vsed -i src/arch/gtk3/data/unix/Makefile.in -e 's/\$(XDG_DESKTOP_MENU) install/$(XDG_DESKTOP_MENU) install --mode system/'
+}
 
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
+pre_install() {
+	# required for xdg-desktop-menu to work
+	vmkdir usr/share/applications
+	vmkdir usr/share/desktop-directories
 }

Re: [PR PATCH] [Updated] vice: update to 3.6.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.6.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From 8efe9cce4ccb49ba93e97442aa0dfd7f1d70af80 Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.7.1.

---
 srcpkgs/vice/template | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..fc69890183cd 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,26 +1,24 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.6.1
 revision=1
 build_style=gnu-configure
 configure_args="
 	$(vopt_enable sdl2 sdlui2)
 	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
+	$(vopt_enable gtk3 native-gtk3ui)
+	$(vopt_enable gtk3 desktop-files)
 	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
+	$(vopt_enable ffmpeg external-ffmpeg)
 	--enable-cpuhistory
 	--enable-x64
 	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
+	--libdir=/usr/lib$XBPS_TARGET_WORDSIZE"
+hostmakedepends="pkg-config flex dos2unix xa perl glib-devel xdg-utils"
 makedepends="
 	zlib-devel
 	readline-devel
 	libpng-devel
-	giflib-devel
 	glew-devel
 	alsa-lib-devel
 	$(vopt_if sdl2 SDL2_mixer-devel)
@@ -32,10 +30,10 @@ makedepends="
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://vice-emu.sourceforge.net/"
+homepage="https://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=20df84c851aaf2f5000510927f6d31b32f269916d351465c366dc0afc9dc150c
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
@@ -43,15 +41,14 @@ build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
 
-CFLAGS="-fcommon"
+export XDG_DATA_DIRS=$DESTDIR/usr/share
 
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
+post_patch() {
+	vsed -i src/arch/gtk3/data/unix/Makefile.in -e 's/\$(XDG_DESKTOP_MENU) install/$(XDG_DESKTOP_MENU) install --mode system/'
+}
 
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
+pre_install() {
+	# required for xdg-desktop-menu to work
+	vmkdir usr/share/applications
+	vmkdir usr/share/desktop-directories
 }

Re: [PR PATCH] [Updated] vice: update to 3.7.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.7.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From 82f72ed4d88bdd0d937ee1841cbf919564e666f3 Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.7.1.

---
 srcpkgs/vice/template | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..10ad40afc369 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,26 +1,24 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.7.1
 revision=1
 build_style=gnu-configure
 configure_args="
 	$(vopt_enable sdl2 sdlui2)
 	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
+	$(vopt_enable gtk3 native-gtk3ui)
+	$(vopt_enable gtk3 desktop-files)
 	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
+	$(vopt_enable ffmpeg external-ffmpeg)
 	--enable-cpuhistory
 	--enable-x64
 	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
+	--libdir=/usr/lib$XBPS_TARGET_WORDSIZE"
+hostmakedepends="pkg-config flex dos2unix xa perl glib-devel xdg-utils"
 makedepends="
 	zlib-devel
 	readline-devel
 	libpng-devel
-	giflib-devel
 	glew-devel
 	alsa-lib-devel
 	$(vopt_if sdl2 SDL2_mixer-devel)
@@ -32,10 +30,10 @@ makedepends="
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://vice-emu.sourceforge.net/"
+homepage="https://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=20df84c851aaf2f5000510927f6d31b32f269916d351465c366dc0afc9dc150c
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
@@ -43,15 +41,14 @@ build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
 
-CFLAGS="-fcommon"
+export XDG_DATA_DIRS=$DESTDIR/usr/share
 
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
+post_patch() {
+	vsed -i src/arch/gtk3/data/unix/Makefile.in -e 's/\$(XDG_DESKTOP_MENU) install/$(XDG_DESKTOP_MENU) install --mode system/'
+}
 
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
+pre_install() {
+	# required for xdg-desktop-menu to work
+	vmkdir usr/share/applications
+	vmkdir usr/share/desktop-directories
 }

Re: [PR PATCH] [Updated] vice: update to 3.7.1.

[ypsvlq]

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is an updated pull request by ypsvlq against master on the void-packages repository

https://github.com/ypsvlq/void-packages vice
https://github.com/void-linux/void-packages/pull/37480

vice: update to 3.7.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37480.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vice-37480.patch --]
[-- Type: text/x-diff, Size: 2642 bytes --]

From 27a6e4c1c0f23144774e9b47bddcfc4fa1533cdf Mon Sep 17 00:00:00 2001
From: Elaine Gibson <ypsvlq@gmail.com>
Date: Fri, 10 Jun 2022 09:53:21 +0100
Subject: [PATCH] vice: update to 3.7.1.

---
 srcpkgs/vice/template | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/vice/template b/srcpkgs/vice/template
index 0924767cfcfb..fe9d33a81194 100644
--- a/srcpkgs/vice/template
+++ b/srcpkgs/vice/template
@@ -1,26 +1,24 @@
 # Template file for 'vice'
 pkgname=vice
-version=3.5
+version=3.7.1
 revision=1
 build_style=gnu-configure
 configure_args="
 	$(vopt_enable sdl2 sdlui2)
 	$(vopt_with sdl2 sdlsound)
-	$(vopt_enable gtk3 gnomeui3)
+	$(vopt_enable gtk3 native-gtk3ui)
+	$(vopt_enable gtk3 desktop-files)
 	$(vopt_with gtk3 pulse)
-	$(vopt_enable ffmpeg  external-ffmpeg)
-	--disable-option-checking
+	$(vopt_enable ffmpeg external-ffmpeg)
 	--enable-cpuhistory
 	--enable-x64
 	--disable-pdf-docs
-	AR=${AR}"
-hostmakedepends="bdftopcf flex mkfontdir perl pkg-config xa
- glib-devel autoconf texinfo automake dos2unix"
+	--libdir=/usr/lib$XBPS_TARGET_WORDSIZE"
+hostmakedepends="pkg-config flex dos2unix xa perl glib-devel xdg-utils"
 makedepends="
 	zlib-devel
 	readline-devel
 	libpng-devel
-	giflib-devel
 	glew-devel
 	alsa-lib-devel
 	$(vopt_if sdl2 SDL2_mixer-devel)
@@ -32,10 +30,10 @@ makedepends="
 short_desc="Emulator for C64, C128, CBM-II, PET, VIC20, Plus4 and C16"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
-homepage="http://vice-emu.sourceforge.net/"
+homepage="https://vice-emu.sourceforge.net/"
 changelog="https://vice-emu.sourceforge.io/NEWS"
 distfiles="${SOURCEFORGE_SITE}/vice-emu/releases/vice-${version}.tar.gz"
-checksum=56b978faaeb8b2896032bd604d03c3501002187eef1ca58ceced40f11a65dc0e
+checksum=7e3811e6024db0698bfbc321bb324572446b8853d01b4073f09865957b0cab98
 
 # Package build options
 build_options="sdl2 gtk3 ffmpeg"
@@ -43,15 +41,14 @@ build_options_default="gtk3 ffmpeg"
 
 desc_option_ffmpeg="Support video recording via FFmpeg"
 
-CFLAGS="-fcommon"
+export XDG_DATA_DIRS=$DESTDIR/usr/share
 
-case "$XBPS_TARGET_MACHINE" in
-	*-musl) configure_args+=" --disable-nls";;
-esac
+post_patch() {
+	vsed -i src/arch/gtk3/data/unix/Makefile.in -e 's/\$(XDG_DESKTOP_MENU) install/$(XDG_DESKTOP_MENU) install --mode system/'
+}
 
-pre_configure() {
-	# __u_char is not portable...
-	sed -i 's,__u_char,unsigned char,g' src/*.[ch]
-	sed -i 's/lib64/lib/g' configure.ac
-	autoreconf -fi
+pre_install() {
+	# required for xdg-desktop-menu to work
+	vmkdir usr/share/applications
+	vmkdir usr/share/desktop-directories
 }

Re: [PR PATCH] [Merged]: vice: update to 3.7.1.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

There's a merged pull request on the void-packages repository

vice: update to 3.7.1.
https://github.com/void-linux/void-packages/pull/37480

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->