[PR PATCH] libotr: make it compile/test with new tools

[chexum <chexum@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1430 bytes --]

There is a new pull request by chexum against master on the void-packages repository

https://github.com/chexum/void-packages libotr-regression
https://github.com/void-linux/void-packages/pull/37563

libotr: make it compile/test with new tools
An irssi update triggered a build of libotr on my system.  It seems the package does
no longer builds.  It was last updated several years ago, toolset was likely more
lax then.

The patch is only needed for the regression test (which is ran by default), so the
code changes don't warrant an actual respin of the binary, it's just needed so
that it can be built from scratch again.

In case other archs fail, I'll check what I can do.

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- [x] I built this PR locally for my native architecture, (x86_64-glibc)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/37563.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libotr-regression-37563.patch --]
[-- Type: text/x-diff, Size: 1615 bytes --]

From 7c267c52bf0d9368c231d37747661c4e70298a05 Mon Sep 17 00:00:00 2001
From: J Farkas <chexum+git@gmail.com>
Date: Tue, 14 Jun 2022 19:47:48 +0000
Subject: [PATCH] libotr: make it compile/test with new tools

Package last updated several years ago, toolset was likely more
lax then.
---
 srcpkgs/libotr/patches/regr-socket.patch | 11 +++++++++++
 srcpkgs/libotr/template                  |  1 +
 2 files changed, 12 insertions(+)
 create mode 100644 srcpkgs/libotr/patches/regr-socket.patch

diff --git a/srcpkgs/libotr/patches/regr-socket.patch b/srcpkgs/libotr/patches/regr-socket.patch
new file mode 100644
index 000000000000..c76db347631b
--- /dev/null
+++ b/srcpkgs/libotr/patches/regr-socket.patch
@@ -0,0 +1,11 @@
+diff -urpN libotr-4.1.1/tests/regression/client/client.c libotr-4.1.1/tests/regression/client/client.c
+--- libotr-4.1.1/tests/regression/client/client.c	2015-12-25 17:39:45.000000000 +0000
++++ libotr-4.1.1/tests/regression/client/client.c	2022-06-14 19:36:19.015005905 +0000
+@@ -26,6 +26,7 @@
+ #include <stdlib.h>
+ #include <syscall.h>
+ #include <sys/epoll.h>
++#include <sys/socket.h>
+ #include <sys/types.h>
+ #include <sys/un.h>
+ #include <unistd.h>
diff --git a/srcpkgs/libotr/template b/srcpkgs/libotr/template
index e4a0f9266716..070d661d4785 100644
--- a/srcpkgs/libotr/template
+++ b/srcpkgs/libotr/template
@@ -4,6 +4,7 @@ version=4.1.1
 revision=1
 build_style=gnu-configure
 makedepends="libgcrypt-devel"
+checkdepends="perl"
 short_desc="Off-the-Record Messaging Library and Toolkit"
 maintainer="Orphaned <orphan@voidlinux.org>"
 homepage="http://www.cypherpunks.ca/otr/"