Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] maxima: enable sbcl option only on supported archs
@ 2022-06-18  6:57 paper42
  2022-06-18 11:48 ` q66
  2022-06-24 21:55 ` [PR PATCH] [Merged]: " paper42
  0 siblings, 2 replies; 3+ messages in thread
From: paper42 @ 2022-06-18  6:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1466 bytes --]

There is a new pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages maxima-sbcl
https://github.com/void-linux/void-packages/pull/37608

maxima: enable sbcl option only on supported archs
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (only build tested)

@tornaria not having sbcl support in maxima on some archs might break sagemath (?), but this is an overall improvement, the maxima package wasn't built at all for cross archs (arm, ppc)
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/37608.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-maxima-sbcl-37608.patch --]
[-- Type: text/x-diff, Size: 1615 bytes --]

From cb5fa463a690099fdbddf9b59180d9cab2682c6d Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 18 Jun 2022 08:51:05 +0200
Subject: [PATCH] maxima: enable sbcl option only on supported archs

---
 srcpkgs/maxima/template | 12 ++++++++++--
 srcpkgs/sbcl/template   |  1 +
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/maxima/template b/srcpkgs/maxima/template
index 69af367ca11d..69e85ec833e8 100644
--- a/srcpkgs/maxima/template
+++ b/srcpkgs/maxima/template
@@ -1,7 +1,7 @@
 # Template file for 'maxima'
 pkgname=maxima
 version=5.45.1
-revision=3
+revision=4
 build_style=gnu-configure
 configure_args="$(vopt_enable clisp) $(vopt_enable sbcl sbcl-exec) $(vopt_enable ecl)"
 hostmakedepends="python3 perl emacs texinfo patchelf"
@@ -28,7 +28,15 @@ build_options="clisp sbcl ecl"
 desc_option_clisp="Build with CLISP"
 desc_option_sbcl="Build with SBCL"
 desc_option_ecl="Build with ECL"
-build_options_default="sbcl ecl"
+build_options_default="ecl"
+
+# sbcl is only available for these architectures
+case "$XBPS_TARGET_MACHINE" in
+	i686|x86_64*|armv7l|aarch64|ppc64le*)
+		build_options_default+=" sbcl"
+		;;
+esac
+
 vopt_conflict clisp sbcl
 
 post_configure() {
diff --git a/srcpkgs/sbcl/template b/srcpkgs/sbcl/template
index cd2e813dc7f8..43e3045f5fc9 100644
--- a/srcpkgs/sbcl/template
+++ b/srcpkgs/sbcl/template
@@ -2,6 +2,7 @@
 pkgname=sbcl
 version=2.2.5
 revision=1
+# make sure the sbcl option in maxima is enabled for the same archs
 archs="i686 x86_64* armv7l aarch64 ppc64le*"
 hostmakedepends="iana-etc texinfo"
 makedepends="zlib-devel"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: maxima: enable sbcl option only on supported archs
  2022-06-18  6:57 [PR PATCH] maxima: enable sbcl option only on supported archs paper42
@ 2022-06-18 11:48 ` q66
  2022-06-24 21:55 ` [PR PATCH] [Merged]: " paper42
  1 sibling, 0 replies; 3+ messages in thread
From: q66 @ 2022-06-18 11:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/37608#issuecomment-1159450482

Comment:
ppc is not a cross arch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: maxima: enable sbcl option only on supported archs
  2022-06-18  6:57 [PR PATCH] maxima: enable sbcl option only on supported archs paper42
  2022-06-18 11:48 ` q66
@ 2022-06-24 21:55 ` paper42
  1 sibling, 0 replies; 3+ messages in thread
From: paper42 @ 2022-06-24 21:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

There's a merged pull request on the void-packages repository

maxima: enable sbcl option only on supported archs
https://github.com/void-linux/void-packages/pull/37608

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (only build tested)

@tornaria not having sbcl support in maxima on some archs might break sagemath (?), but this is an overall improvement, the maxima package wasn't built at all for cross archs (arm, ~~ppc~~)
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-24 21:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-18  6:57 [PR PATCH] maxima: enable sbcl option only on supported archs paper42
2022-06-18 11:48 ` q66
2022-06-24 21:55 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).