Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mpg123: update to 1.30.0.
@ 2022-06-30 10:02 r-ricci
  2022-06-30 15:08 ` Duncaen
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: r-ricci @ 2022-06-30 10:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

There is a new pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages mpg123
https://github.com/void-linux/void-packages/pull/37754

mpg123: update to 1.30.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Unless explicitly configured to use only the internal network code, it requires either `wget` (default) or `curl`. It doesn't fallback on the internal code when neither are found. What should the package depend on?

A patch file from https://github.com/void-linux/void-packages/pull/37754.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpg123-37754.patch --]
[-- Type: text/x-diff, Size: 1388 bytes --]

From f91ea3abbbc38cfdeaf5f0b287db3b7d2226a2c2 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Thu, 30 Jun 2022 11:44:01 +0200
Subject: [PATCH] mpg123: update to 1.30.0.

---
 srcpkgs/mpg123/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/mpg123/template b/srcpkgs/mpg123/template
index 561ecb5d3a7d..79b22232db88 100644
--- a/srcpkgs/mpg123/template
+++ b/srcpkgs/mpg123/template
@@ -1,19 +1,19 @@
 # Template file for 'mpg123'
 pkgname=mpg123
-version=1.29.3
+version=1.30.0
 revision=1
 build_style=gnu-configure
 # --with-cpu not necessary, upstream detects features correctly
-configure_args="--with-optimization=0 --with-default-audio=alsa
- --enable-ipv6=yes --enable-network=yes"
+configure_args="--with-optimization=0 --with-default-audio=alsa"
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel jack-devel pulseaudio-devel sndio-devel SDL2-devel"
+depends="curl"
 short_desc="Fast console MPEG audio decoder/player"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-only"
 homepage="https://www.mpg123.org/"
 distfiles="${SOURCEFORGE_SITE}/mpg123/mpg123-${version}.tar.bz2"
-checksum=963885d8cc77262f28b77187c7d189e32195e64244de2530b798ddf32183e847
+checksum=397ead52f0299475f2cefd38c3835977193fd9b1db6593680346c4e9109ed61c
 
 case "$XBPS_TARGET_MACHINE" in
 	# No LFS required with musl

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mpg123: update to 1.30.0.
  2022-06-30 10:02 [PR PATCH] mpg123: update to 1.30.0 r-ricci
@ 2022-06-30 15:08 ` Duncaen
  2022-06-30 18:00 ` r-ricci
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Duncaen @ 2022-06-30 15:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/37754#issuecomment-1171339939

Comment:
Maybe just leave out the dependency, nobody complained about it and most users have curl or wget installed anyways.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mpg123: update to 1.30.0.
  2022-06-30 10:02 [PR PATCH] mpg123: update to 1.30.0 r-ricci
  2022-06-30 15:08 ` Duncaen
@ 2022-06-30 18:00 ` r-ricci
  2022-06-30 18:03 ` [PR PATCH] [Updated] " r-ricci
  2022-07-01  5:34 ` [PR PATCH] [Merged]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2022-06-30 18:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by r-ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/37754#issuecomment-1171519206

Comment:
> nobody complained about it

Before this release there was only the non-TLS internal implementation.

Anyway, I think leaving the dependency out is fine.



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] mpg123: update to 1.30.0.
  2022-06-30 10:02 [PR PATCH] mpg123: update to 1.30.0 r-ricci
  2022-06-30 15:08 ` Duncaen
  2022-06-30 18:00 ` r-ricci
@ 2022-06-30 18:03 ` r-ricci
  2022-07-01  5:34 ` [PR PATCH] [Merged]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: r-ricci @ 2022-06-30 18:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1477 bytes --]

There is an updated pull request by r-ricci against master on the void-packages repository

https://github.com/r-ricci/void-packages mpg123
https://github.com/void-linux/void-packages/pull/37754

mpg123: update to 1.30.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Unless explicitly configured to use only the internal network code, it requires either `wget` (default) or `curl` to support HTTP streaming. It doesn't fallback on the internal code when neither are found. What should the package depend on?

A patch file from https://github.com/void-linux/void-packages/pull/37754.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpg123-37754.patch --]
[-- Type: text/x-diff, Size: 1388 bytes --]

From 7e7456d331277697ffbe6f36be52e086c9b1c966 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Thu, 30 Jun 2022 11:44:01 +0200
Subject: [PATCH] mpg123: update to 1.30.0.

---
 srcpkgs/mpg123/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/mpg123/template b/srcpkgs/mpg123/template
index 561ecb5d3a7d..6327b7ab9513 100644
--- a/srcpkgs/mpg123/template
+++ b/srcpkgs/mpg123/template
@@ -1,11 +1,10 @@
 # Template file for 'mpg123'
 pkgname=mpg123
-version=1.29.3
+version=1.30.0
 revision=1
 build_style=gnu-configure
 # --with-cpu not necessary, upstream detects features correctly
-configure_args="--with-optimization=0 --with-default-audio=alsa
- --enable-ipv6=yes --enable-network=yes"
+configure_args="--with-optimization=0 --with-default-audio=alsa"
 hostmakedepends="pkg-config"
 makedepends="alsa-lib-devel jack-devel pulseaudio-devel sndio-devel SDL2-devel"
 short_desc="Fast console MPEG audio decoder/player"
@@ -13,7 +12,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-only"
 homepage="https://www.mpg123.org/"
 distfiles="${SOURCEFORGE_SITE}/mpg123/mpg123-${version}.tar.bz2"
-checksum=963885d8cc77262f28b77187c7d189e32195e64244de2530b798ddf32183e847
+checksum=397ead52f0299475f2cefd38c3835977193fd9b1db6593680346c4e9109ed61c
 
 case "$XBPS_TARGET_MACHINE" in
 	# No LFS required with musl

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: mpg123: update to 1.30.0.
  2022-06-30 10:02 [PR PATCH] mpg123: update to 1.30.0 r-ricci
                   ` (2 preceding siblings ...)
  2022-06-30 18:03 ` [PR PATCH] [Updated] " r-ricci
@ 2022-07-01  5:34 ` classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-07-01  5:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

There's a merged pull request on the void-packages repository

mpg123: update to 1.30.0.
https://github.com/void-linux/void-packages/pull/37754

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Unless explicitly configured to use only the internal network code, it requires either `wget` (default) or `curl` to support HTTP streaming. It doesn't fallback on the internal code when neither are found. What should the package depend on?

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-07-01  5:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 10:02 [PR PATCH] mpg123: update to 1.30.0 r-ricci
2022-06-30 15:08 ` Duncaen
2022-06-30 18:00 ` r-ricci
2022-06-30 18:03 ` [PR PATCH] [Updated] " r-ricci
2022-07-01  5:34 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).