From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] RcloneBrowser: do not check for updates by default
Date: Fri, 01 Jul 2022 19:45:25 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37790@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1461 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages rclonebrowser-update
https://github.com/void-linux/void-packages/pull/37790
RcloneBrowser: do not check for updates by default
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
It checks once a day and this PR only changes the default = if you ran rclone-browser at least once, the settings are already written and this PR won't change anything for you.
@zdykstra
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/37790.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rclonebrowser-update-37790.patch --]
[-- Type: text/x-diff, Size: 3379 bytes --]
From 910ca643ffef6de2c450001a36444690f01733cc Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Fri, 1 Jul 2022 19:42:05 +0200
Subject: [PATCH] RcloneBrowser: do not check for updates by default
---
.../patches/do-not-check-for-updates.patch | 51 +++++++++++++++++++
srcpkgs/RcloneBrowser/template | 2 +-
2 files changed, 52 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/RcloneBrowser/patches/do-not-check-for-updates.patch
diff --git a/srcpkgs/RcloneBrowser/patches/do-not-check-for-updates.patch b/srcpkgs/RcloneBrowser/patches/do-not-check-for-updates.patch
new file mode 100644
index 000000000000..56f1ae667451
--- /dev/null
+++ b/srcpkgs/RcloneBrowser/patches/do-not-check-for-updates.patch
@@ -0,0 +1,51 @@
+From 2976c391098c83bce55547db0b8c5d70c046fde1 Mon Sep 17 00:00:00 2001
+From: Michal Vasilek <michal@vasilek.cz>
+Date: Fri, 1 Jul 2022 19:32:55 +0200
+Subject: [PATCH] do not check for updates
+
+---
+ src/main_window.cpp | 4 ++--
+ src/preferences_dialog.cpp | 4 ++--
+ 2 files changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/src/main_window.cpp b/src/main_window.cpp
+index 3bf6340..41d4f93 100644
+--- a/src/main_window.cpp
++++ b/src/main_window.cpp
+@@ -527,7 +527,7 @@ void MainWindow::rcloneGetVersion() {
+ // during first run the key might not exist yet
+ if (!(settings->contains("Settings/checkRcloneUpdates"))) {
+ // if checkRcloneUpdates does not exist create new key
+- settings->setValue("Settings/checkRcloneUpdates", true);
++ settings->setValue("Settings/checkRcloneUpdates", false);
+ };
+
+ bool checkRcloneUpdates =
+@@ -605,7 +605,7 @@ void MainWindow::rcloneGetVersion() {
+ // during first run the key might not exist yet
+ if (!(settings->contains("Settings/checkRcloneBrowserUpdates"))) {
+ // if checkRcloneBrowserUpdates does not exist create new key
+- settings->setValue("Settings/checkRcloneBrowserUpdates", true);
++ settings->setValue("Settings/checkRcloneBrowserUpdates", false);
+ };
+
+ bool checkRcloneBrowserUpdates =
+diff --git a/src/preferences_dialog.cpp b/src/preferences_dialog.cpp
+index 1564621..76eb531 100644
+--- a/src/preferences_dialog.cpp
++++ b/src/preferences_dialog.cpp
+@@ -94,9 +94,9 @@ PreferencesDialog::PreferencesDialog(QWidget *parent) : QDialog(parent) {
+ settings->value("Settings/defaultRcloneOptions").toString());
+
+ ui.checkRcloneBrowserUpdates->setChecked(
+- settings->value("Settings/checkRcloneBrowserUpdates", true).toBool());
++ settings->value("Settings/checkRcloneBrowserUpdates", false).toBool());
+ ui.checkRcloneUpdates->setChecked(
+- settings->value("Settings/checkRcloneUpdates", true).toBool());
++ settings->value("Settings/checkRcloneUpdates", false).toBool());
+
+ if (QSystemTrayIcon::isSystemTrayAvailable()) {
+ ui.alwaysShowInTray->setChecked(
+--
+2.37.0
+
diff --git a/srcpkgs/RcloneBrowser/template b/srcpkgs/RcloneBrowser/template
index b96d82b57f8c..c3fecd0afb50 100644
--- a/srcpkgs/RcloneBrowser/template
+++ b/srcpkgs/RcloneBrowser/template
@@ -1,7 +1,7 @@
# Template file for 'RcloneBrowser'
pkgname=RcloneBrowser
version=1.8.0
-revision=1
+revision=2
build_style=cmake
hostmakedepends="qt5-devel"
makedepends="qt5-devel"
next reply other threads:[~2022-07-01 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 17:45 paper42 [this message]
2022-07-01 17:51 ` zdykstra
2022-07-01 18:02 ` paper42
2022-07-01 18:16 ` zdykstra
2022-07-02 23:07 ` zdykstra
2022-07-03 10:33 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-37790@inbox.vuxu.org \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).