[PR PATCH] New package:sirikali-1.5.0

[PR PATCH] New package:sirikali-1.5.0

[ankit255]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

There is a new pull request by ankit255 against master on the void-packages repository

https://github.com/ankit255/void-packages sirikali-branch
https://github.com/void-linux/void-packages/pull/37801

New package:sirikali-1.5.0

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/37801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sirikali-branch-37801.patch --]
[-- Type: text/x-diff, Size: 1436 bytes --]

From 96302ccda15860fb940f03f9ee5f848b6a054098 Mon Sep 17 00:00:00 2001
From: Ankit Pasi <ankitpasi1@gmail.com>
Date: Sat, 2 Jul 2022 14:11:23 +0530
Subject: [PATCH] New package:sirikali-1.5.0

---
 srcpkgs/sirikali/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/sirikali/template

diff --git a/srcpkgs/sirikali/template b/srcpkgs/sirikali/template
new file mode 100644
index 000000000000..46595ce155bd
--- /dev/null
+++ b/srcpkgs/sirikali/template
@@ -0,0 +1,24 @@
+# Template file for 'sirikali'
+pkgname=sirikali
+version=1.5.0
+revision=1
+#archs="i686 x86_64"
+wrksrc="SiriKali-${version}"
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DQT5=true
+ -DCMAKE_BUILD_TYPE=RELEASE"
+#make_build_args=""
+#make_install_args=""
+#conf_files=""
+#make_dirs="/var/log/dir 0755 root root"
+hostmakedepends="qt5-qmake qt5-host-tools pkg-config qt5-devel"
+makedepends="libgcrypt-devel libpwquality-devel
+ libsecret-devel $(vopt_if kde kwallet-devel)"
+short_desc="GUI for cryfs, encfs, gocryptfs, securefs encrypted folders"
+maintainer="moot <realmoot@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/mhogomchungu/sirikali"
+#changelog=""
+distfiles="https://github.com/mhogomchungu/sirikali/releases/download/${version}/SiriKali-${version}.tar.xz"
+checksum=848506f6130a3e10ccc3b767c4ae7b27b1f69828ef25d42dfa8d651cd3d5520e

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912388941

Comment:
https://mhogomchungu.github.io/sirikali/

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912389187

Comment:
also, line wrapping is only needed at ~80 characters, this could probably fit on one line

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912388737

Comment:
this is not needed (and is what's breaking CI)

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912388810

Comment:
this is not the correct licence

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912388864

Comment:
this build option is not defined anywhere in the template

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912388896

Comment:
https://raw.githubusercontent.com/mhogomchungu/sirikali/master/changelog

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912389069

Comment:
```suggestion
configure_args="-DQT5=true"
```
the build style defines two of those already:
https://github.com/void-linux/void-packages/blob/69267e8b403c0b6b29732fb3aef96ad0b4876547/common/build-style/cmake.sh#L54-L55

Re: [PR REVIEW] New package:sirikali-1.5.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#discussion_r912388744

Comment:
remove all the commented variables

Re: [PR PATCH] [Updated] New package:sirikali-1.5.0

[ankit255]

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

There is an updated pull request by ankit255 against master on the void-packages repository

https://github.com/ankit255/void-packages sirikali-branch
https://github.com/void-linux/void-packages/pull/37801

New package:sirikali-1.5.0

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/37801.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sirikali-branch-37801.patch --]
[-- Type: text/x-diff, Size: 2248 bytes --]

From 96302ccda15860fb940f03f9ee5f848b6a054098 Mon Sep 17 00:00:00 2001
From: Ankit Pasi <ankitpasi1@gmail.com>
Date: Sat, 2 Jul 2022 14:11:23 +0530
Subject: [PATCH 1/2] New package:sirikali-1.5.0

---
 srcpkgs/sirikali/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/sirikali/template

diff --git a/srcpkgs/sirikali/template b/srcpkgs/sirikali/template
new file mode 100644
index 000000000000..46595ce155bd
--- /dev/null
+++ b/srcpkgs/sirikali/template
@@ -0,0 +1,24 @@
+# Template file for 'sirikali'
+pkgname=sirikali
+version=1.5.0
+revision=1
+#archs="i686 x86_64"
+wrksrc="SiriKali-${version}"
+create_wrksrc=yes
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DQT5=true
+ -DCMAKE_BUILD_TYPE=RELEASE"
+#make_build_args=""
+#make_install_args=""
+#conf_files=""
+#make_dirs="/var/log/dir 0755 root root"
+hostmakedepends="qt5-qmake qt5-host-tools pkg-config qt5-devel"
+makedepends="libgcrypt-devel libpwquality-devel
+ libsecret-devel $(vopt_if kde kwallet-devel)"
+short_desc="GUI for cryfs, encfs, gocryptfs, securefs encrypted folders"
+maintainer="moot <realmoot@protonmail.com>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/mhogomchungu/sirikali"
+#changelog=""
+distfiles="https://github.com/mhogomchungu/sirikali/releases/download/${version}/SiriKali-${version}.tar.xz"
+checksum=848506f6130a3e10ccc3b767c4ae7b27b1f69828ef25d42dfa8d651cd3d5520e

From f45d47c2a9ccb94e96ea53a9ed5bc9a980dabff7 Mon Sep 17 00:00:00 2001
From: ankit255 <ankitpasi1@gmail.com>
Date: Sun, 3 Jul 2022 07:36:24 +0530
Subject: [PATCH 2/2] Update srcpkgs/sirikali/template

Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
---
 srcpkgs/sirikali/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/sirikali/template b/srcpkgs/sirikali/template
index 46595ce155bd..8326fdac5bd0 100644
--- a/srcpkgs/sirikali/template
+++ b/srcpkgs/sirikali/template
@@ -6,8 +6,7 @@ revision=1
 wrksrc="SiriKali-${version}"
 create_wrksrc=yes
 build_style=cmake
-configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DQT5=true
- -DCMAKE_BUILD_TYPE=RELEASE"
+configure_args="-DQT5=true"
 #make_build_args=""
 #make_install_args=""
 #conf_files=""

Re: New package:sirikali-1.5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/37801#issuecomment-1264201451

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package:sirikali-1.5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There's a closed pull request on the void-packages repository

New package:sirikali-1.5.0
https://github.com/void-linux/void-packages/pull/37801

Description:

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)