Github messages for voidlinux
 help / color / mirror / Atom feed
From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] python3-pymediainfo: remove unused dependency.
Date: Sat, 23 Jul 2022 12:10:01 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38205@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 998 bytes --]

There is a new pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages fix-meta-pymediainfo
https://github.com/void-linux/void-packages/pull/38205

python3-pymediainfo: remove unused dependency.
python3-importlib_metadata is a backport of new-ish importlib APIs for python
versions under 3.10 (3.8 in some cases). Since Void already has python 3.10,
the backport is completely unused and the package is already using the builtin
importlib.metadata (note the dot in place of the underscore).

https://github.com/sbraz/pymediainfo/commit/8af1511195f70ba2776bd9f1c15afbf6d2377b9b

@TinfoilSubmarine

#### Testing the changes
- I tested the changes in this PR: **briefly**
    `importlib.metadata` is mainly used to get the version, and that seems to be working perfectly. I used the library to get info on a png image and it seemed to work fine.


A patch file from https://github.com/void-linux/void-packages/pull/38205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-meta-pymediainfo-38205.patch --]
[-- Type: text/x-diff, Size: 1269 bytes --]

From 617f13aa310574857f0049343ddbc0ef36e4bc89 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Sat, 23 Jul 2022 05:38:40 -0400
Subject: [PATCH] python3-pymediainfo: remove unused dependency.

python3-importlib_metadata is a backport of new-ish importlib APIs for python
versions under 3.10 (3.8 in some cases). Since Void already has python 3.10,
the backport is completely unused and the package is already using the builtin
importlib.metadata (note the dot in place of the underscore).
---
 srcpkgs/python3-pymediainfo/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-pymediainfo/template b/srcpkgs/python3-pymediainfo/template
index 745c82cb37ce..002729dd0a38 100644
--- a/srcpkgs/python3-pymediainfo/template
+++ b/srcpkgs/python3-pymediainfo/template
@@ -1,11 +1,11 @@
 # Template file for 'python3-pymediainfo'
 pkgname=python3-pymediainfo
 version=5.1.0
-revision=1
+revision=2
 wrksrc="pymediainfo-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools_scm"
-depends="python3-importlib_metadata libmediainfo"
+depends="libmediainfo"
 checkdepends="python3-pytest libmediainfo"
 short_desc="Python wrapper around the MediaInfo library"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"

             reply	other threads:[~2022-07-23 10:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23 10:10 0x5c [this message]
2022-07-25 11:35 ` [PR PATCH] [Merged]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38205@inbox.vuxu.org \
    --to=0x5c@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).