[PR PATCH] python3-pyperclip: update to 1.8.2.

[PR PATCH] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-pyperclip
https://github.com/void-linux/void-packages/pull/38209

python3-pyperclip: update to 1.8.2.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/38209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pyperclip-38209.patch --]
[-- Type: text/x-diff, Size: 1226 bytes --]

From a5c45218cd2136d95a4d1f016aa3afa70ef62210 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 23 Jul 2022 19:29:39 +0530
Subject: [PATCH] python3-pyperclip: update to 1.8.2.

---
 srcpkgs/python3-pyperclip/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-pyperclip/template b/srcpkgs/python3-pyperclip/template
index fe8e5095fa43..16fb6f097e25 100644
--- a/srcpkgs/python3-pyperclip/template
+++ b/srcpkgs/python3-pyperclip/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-pyperclip'
 pkgname=python3-pyperclip
-version=1.8.1
-revision=2
+version=1.8.2
+revision=1
 wrksrc=pyperclip-${version}
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -11,7 +11,11 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://pypi.org/project/pyperclip"
 distfiles="${PYPI_SITE}/p/pyperclip/pyperclip-${version}.tar.gz"
-checksum=9abef1e79ce635eb62309ecae02dfb5a3eb952fa7d6dce09c1aef063f81424d3
+checksum=105254a8b04934f0bc84e9c24eb360a591aaf6535c9def5f29d92af107a9bf57
+
+do_check() {
+	PYTHONPATH="$(cd build/lib* && pwd)" python3 tests/test_pyperclip.py
+}
 
 post_install() {
 	vlicense LICENSE.txt

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r928141271

Comment:
why does the PYTHONPATH need to be evaluated? iirc the name of the lib dir should always be the same

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r928141845

Comment:
TBH I have no idea. I got that bit from when I read the python3-module build-style file for the first time and been using it since whenever I have to write a `do_check()`.

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r928946560

Comment:
The name of the library directory is not always the same. It's `build/lib` for pure-Python packages and `build/lib.<arch>` for packages with compiled extensions.

That said, this is unnecessary here for two reasons:
1. All you need to do is add `python3-pytest` to `checkdepends` and let the default check run.
2. 99/101 tests are skipped because there is no functional clipboard in the environment. If you can't get a working clipboard in the test environment, you might as well just `make_check=no` because all of the real tests are ignored anyway.

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929056327

Comment:
I can't seem to make the skipped tests run locally even after adding `wl-clipboard` to the `checkdepends`. So probably have to do with `make_check=no` for now. But anyway this module uses python unittests so I don't think adding pytest works.

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929071010

Comment:
[pytest can run unittest-based tests](https://docs.pytest.org/en/latest/how-to/unittest.html)

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929094465

Comment:
Oh! totally missed that.

Re: [PR PATCH] [Updated] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-pyperclip
https://github.com/void-linux/void-packages/pull/38209

python3-pyperclip: update to 1.8.2.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/38209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pyperclip-38209.patch --]
[-- Type: text/x-diff, Size: 1200 bytes --]

From 160e28e0476ea2c41f05fc81e08dff0a2d072dcb Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 23 Jul 2022 19:29:39 +0530
Subject: [PATCH] python3-pyperclip: update to 1.8.2.

---
 srcpkgs/python3-pyperclip/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-pyperclip/template b/srcpkgs/python3-pyperclip/template
index fe8e5095fa43..2eafd4b3cfd9 100644
--- a/srcpkgs/python3-pyperclip/template
+++ b/srcpkgs/python3-pyperclip/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-pyperclip'
 pkgname=python3-pyperclip
-version=1.8.1
-revision=2
+version=1.8.2
+revision=1
 wrksrc=pyperclip-${version}
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -11,7 +11,8 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://pypi.org/project/pyperclip"
 distfiles="${PYPI_SITE}/p/pyperclip/pyperclip-${version}.tar.gz"
-checksum=9abef1e79ce635eb62309ecae02dfb5a3eb952fa7d6dce09c1aef063f81424d3
+checksum=105254a8b04934f0bc84e9c24eb360a591aaf6535c9def5f29d92af107a9bf57
+make_check=no # can't get clipboard working in the test environment
 
 post_install() {
 	vlicense LICENSE.txt

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929119608

Comment:
```
checkdepends="python3-pytest xsel xclip"
make_check_pre="xvfb-run"
```

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929124918

Comment:
This requires `xvfb-run` in `checkdepends` as well, right?

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929128819

Comment:
I forgot about that, yes

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929131310

Comment:
20 passed, 81 skipped

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929144950

Comment:
That's definitely better than 99 skipped; I imagine the tests consider all possible clipboards and it won't be worth trying to get other clipboards to work in testing.

Re: [PR PATCH] [Updated] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-pyperclip
https://github.com/void-linux/void-packages/pull/38209

python3-pyperclip: update to 1.8.2.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/38209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pyperclip-38209.patch --]
[-- Type: text/x-diff, Size: 1270 bytes --]

From 5e85a5d445f83087b7a58e6b1ea5132dc76e3703 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 23 Jul 2022 19:29:39 +0530
Subject: [PATCH] python3-pyperclip: update to 1.8.2.

---
 srcpkgs/python3-pyperclip/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-pyperclip/template b/srcpkgs/python3-pyperclip/template
index fe8e5095fa43..0631d9acffa3 100644
--- a/srcpkgs/python3-pyperclip/template
+++ b/srcpkgs/python3-pyperclip/template
@@ -1,17 +1,19 @@
 # Template file for 'python3-pyperclip'
 pkgname=python3-pyperclip
-version=1.8.1
-revision=2
+version=1.8.2
+revision=1
 wrksrc=pyperclip-${version}
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3"
+checkdepends="python3-pytest xclip xsel xvfb-run"
 short_desc="Cross-platform clipboard module (Python3)"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://pypi.org/project/pyperclip"
 distfiles="${PYPI_SITE}/p/pyperclip/pyperclip-${version}.tar.gz"
-checksum=9abef1e79ce635eb62309ecae02dfb5a3eb952fa7d6dce09c1aef063f81424d3
+checksum=105254a8b04934f0bc84e9c24eb360a591aaf6535c9def5f29d92af107a9bf57
+make_check_pre="xvfb-run"
 
 post_install() {
 	vlicense LICENSE.txt

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929200680

Comment:
That one test failed on `x86_64-musl` for some reason. I guess the upstream README is correct
> Note: xsel does not always seem to work

Re: [PR REVIEW] python3-pyperclip: update to 1.8.2.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#discussion_r929210248

Comment:
> That's definitely better than 99 skipped; I imagine the tests consider all possible clipboards and it won't be worth trying to get other clipboards to work in testing.

Yes, I looked at the code and it tries to run tests for different clipboard managers, skipping the ones that are not available. xsel and xclip were easy to set up, so I only enabled those.

Re: python3-pyperclip: update to 1.8.2.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/38209#issuecomment-1288314651

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] python3-pyperclip: update to 1.8.2.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages python3-pyperclip
https://github.com/void-linux/void-packages/pull/38209

python3-pyperclip: update to 1.8.2.
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

A patch file from https://github.com/void-linux/void-packages/pull/38209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-pyperclip-38209.patch --]
[-- Type: text/x-diff, Size: 1265 bytes --]

From a380f4a722ba0baef62ace90e854f44f27dd522d Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 23 Jul 2022 19:29:39 +0530
Subject: [PATCH] python3-pyperclip: update to 1.8.2.

---
 srcpkgs/python3-pyperclip/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-pyperclip/template b/srcpkgs/python3-pyperclip/template
index fe8e5095fa43..d18de13677d2 100644
--- a/srcpkgs/python3-pyperclip/template
+++ b/srcpkgs/python3-pyperclip/template
@@ -1,17 +1,19 @@
 # Template file for 'python3-pyperclip'
 pkgname=python3-pyperclip
-version=1.8.1
-revision=2
+version=1.8.2
+revision=1
 wrksrc=pyperclip-${version}
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3"
+checkdepends="python3-pytest xclip xvfb-run"
 short_desc="Cross-platform clipboard module (Python3)"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://pypi.org/project/pyperclip"
 distfiles="${PYPI_SITE}/p/pyperclip/pyperclip-${version}.tar.gz"
-checksum=9abef1e79ce635eb62309ecae02dfb5a3eb952fa7d6dce09c1aef063f81424d3
+checksum=105254a8b04934f0bc84e9c24eb360a591aaf6535c9def5f29d92af107a9bf57
+make_check_pre="xvfb-run"
 
 post_install() {
 	vlicense LICENSE.txt

Re: [PR PATCH] [Merged]: python3-pyperclip: update to 1.8.2.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

There's a merged pull request on the void-packages repository

python3-pyperclip: update to 1.8.2.
https://github.com/void-linux/void-packages/pull/38209

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, x86_64