From: MarleDK <MarleDK@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] docker-credential-pass: Fix broken post_install
Date: Mon, 25 Jul 2022 11:28:45 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38267@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 583 bytes --]
There is a new pull request by MarleDK against master on the void-packages repository
https://github.com/MarleDK/void-packages docker-credential-pass-fix-post_install
https://github.com/void-linux/void-packages/pull/38267
docker-credential-pass: Fix broken post_install
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO**
- Only checked that `xls` shows the right binary after packaging
A patch file from https://github.com/void-linux/void-packages/pull/38267.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-docker-credential-pass-fix-post_install-38267.patch --]
[-- Type: text/x-diff, Size: 1170 bytes --]
From cc8da9d39f80c237d2f28e75636e3b859e572667 Mon Sep 17 00:00:00 2001
From: Jakob Rydhof <jry@famly.co>
Date: Mon, 25 Jul 2022 11:23:50 +0200
Subject: [PATCH] docker-credential-pass: Fix broken post_install
There cannot be two `post_install` hooks in the template, it made the
second hook overwrite the first, which meant /usr/bin/cmd was never
moved.
---
srcpkgs/docker-credential-pass/template | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/srcpkgs/docker-credential-pass/template b/srcpkgs/docker-credential-pass/template
index 18daf0c1dd1f..f50da0c94b23 100644
--- a/srcpkgs/docker-credential-pass/template
+++ b/srcpkgs/docker-credential-pass/template
@@ -1,7 +1,7 @@
# Template file for 'docker-credential-pass'
pkgname=docker-credential-pass
version=0.6.4
-revision=1
+revision=2
wrksrc="docker-credential-helpers-${version}"
build_style=go
go_import_path="github.com/docker/docker-credential-helpers"
@@ -16,8 +16,5 @@ checksum=b97d27cefb2de7a18079aad31c9aef8e3b8a38313182b73aaf8b83701275ac83
post_install() {
mv ${DESTDIR}/usr/bin/cmd ${DESTDIR}/usr/bin/docker-credential-pass
-}
-
-post_install() {
vlicense LICENSE
}
next reply other threads:[~2022-07-25 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 9:28 MarleDK [this message]
2022-07-25 9:36 ` paper42
2022-07-25 9:36 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-38267@inbox.vuxu.org \
--to=marledk@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).