[PR PATCH] gopass-jsonapi: update to 1.14.3.

[PR PATCH] gopass-jsonapi: update to 1.14.3.

[kuhnchris]

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

There is a new pull request by kuhnchris against master on the void-packages repository

https://github.com/kuhnchris/void-packages master
https://github.com/void-linux/void-packages/pull/38289

gopass-jsonapi: update to 1.14.3.
#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

---
Previous revision accidently didn't set the -X main.version=${version} making gopassbridge complain about "please upgrade your gopass version to >1.8.3" despite having 1.13.X installed.

For future references, a test client for this is found in the gopassbridge repository (test-client directory) and a check can be invoked like this:
```
(master) gopassbridge/test-client % echo '{"type": "getVersion"}' | ./test-client | gopass-jsonapi listen                                                                                                
3{"version":"1.14.3","major":1,"minor":14,"patch":3}%       
```

A patch file from https://github.com/void-linux/void-packages/pull/38289.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-38289.patch --]
[-- Type: text/x-diff, Size: 866 bytes --]

From cd7b0d0c97c76643dc3149bc484d24623c044630 Mon Sep 17 00:00:00 2001
From: KuhnChris <kuhnchris@kuhnchris.eu>
Date: Wed, 27 Jul 2022 00:48:16 +0200
Subject: [PATCH] gopass-jsonapi: update to 1.14.3.

---
 srcpkgs/gopass-jsonapi/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/gopass-jsonapi/template b/srcpkgs/gopass-jsonapi/template
index 65408ca21596..e81f6d08cdb1 100644
--- a/srcpkgs/gopass-jsonapi/template
+++ b/srcpkgs/gopass-jsonapi/template
@@ -1,10 +1,11 @@
 # Template file for 'gopass-jsonapi'
 pkgname=gopass-jsonapi
 version=1.14.3
-revision=1
+revision=2
 create_wrksrc=yes
 build_style=go
 go_import_path=github.com/gopasspw/gopass-jsonapi
+go_ldflags="-X main.version=${version}"
 depends="gopass"
 short_desc="Gopass JSON bridge for extensions"
 maintainer="KuhnChris <kuhnchris+voidpackages@kuhnchris.eu>"

Re: gopass-jsonapi: update to 1.14.3.

[kuhnchris]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New comment by kuhnchris on void-packages repository

https://github.com/void-linux/void-packages/pull/38289#issuecomment-1196060980

Comment:
On a related note: the `go_ldflags` parameter is also not mentioned in the Contribution Guide / Manual. I just accidently found it while checking other templates like `docker-compose` or `revive`

Re: gopass-jsonapi: update to 1.14.3.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38289#issuecomment-1198968772

Comment:
commit message should be `gopass-jsonapi: add version to go_ldflags` or something similar

Re: gopass-jsonapi: update to 1.14.3.

[kuhnchris]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New comment by kuhnchris on void-packages repository

https://github.com/void-linux/void-packages/pull/38289#issuecomment-1199278071

Comment:
> commit message should be `gopass-jsonapi: add version to go_ldflags` or something similar

really? I thought it was disallowed to add anything aside what `xbump` pre-fills? I can change the commit message, sure, just making sure I don't cause any issues.

Re: gopass-jsonapi: update to 1.14.3.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38289#issuecomment-1199547462

Comment:
> > commit message should be `gopass-jsonapi: add version to go_ldflags` or something similar
> 
> really? I thought it was disallowed to add anything aside what `xbump` pre-fills? I can change the commit message, sure, just making sure I don't cause any issues.

xbump can only detect updates and new packages, so every other commit has to named manually. This is not an update, so the commit shouldn't say it is.

Re: gopass-jsonapi: update to 1.14.3.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38289#issuecomment-1201474856

Comment:
done in a3bf3340bf7dd3108b4362398f10de671819814c

Re: [PR PATCH] [Closed]: gopass-jsonapi: update to 1.14.3.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

There's a closed pull request on the void-packages repository

gopass-jsonapi: update to 1.14.3.
https://github.com/void-linux/void-packages/pull/38289

Description:
#### Testing the changes
- I tested the changes in this PR: YES

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

---
Previous revision accidently didn't set the -X main.version=${version} making gopassbridge complain about "please upgrade your gopass version to >1.8.3" despite having 1.13.X installed.

For future references, a test client for this is found in the gopassbridge repository (test-client directory) and a check can be invoked like this:
```
(master) gopassbridge/test-client % echo '{"type": "getVersion"}' | ./test-client | gopass-jsonapi listen                                                                                                
3{"version":"1.14.3","major":1,"minor":14,"patch":3}%       
```

Re: gopass-jsonapi: update to 1.14.3.

[kuhnchris]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by kuhnchris on void-packages repository

https://github.com/void-linux/void-packages/pull/38289#issuecomment-1201554675

Comment:
thanks