Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
@ 2022-07-27 23:22 classabbyamp
  2022-07-28 16:34 ` [PR PATCH] [Updated] " classabbyamp
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: classabbyamp @ 2022-07-27 23:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages ci/enable-all-archs
https://github.com/void-linux/void-packages/pull/38322

[RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (but it's a trivial change)

This has been how it's done since at least the switch to github CI (#26095), and how it was done in the travis CI era:

https://github.com/void-linux/void-packages/blob/71a25f3e735c1fef4178422b1a2bb70ec8e84e02/.travis.yml#L15-L21

Should it be changed? Is there a reason why CI isn't run on armv6l and armv7l-musl?


A patch file from https://github.com/void-linux/void-packages/pull/38322.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ci/enable-all-archs-38322.patch --]
[-- Type: text/x-diff, Size: 1041 bytes --]

From bc8decb98e2717f0db2466617fac1516e4a37b03 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 27 Jul 2022 19:16:22 -0400
Subject: [PATCH] .github/workflows/build.yaml: add armv6l, armv7l-musl to
 build matrix

---
 .github/workflows/build.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index bb05364b5e74..16f310bb64de 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -58,8 +58,10 @@ jobs:
           - { arch: i686, bootstrap: i686, test: 1 }
           - { arch: aarch64, bootstrap: x86_64, test: 0 }
           - { arch: armv7l, bootstrap: x86_64, test: 0 }
+          - { arch: armv6l, bootstrap: x86_64, test: 0 }
           - { arch: x86_64-musl, bootstrap: x86_64-musl, test: 1 }
           - { arch: armv6l-musl, bootstrap: x86_64-musl, test: 0 }
+          - { arch: armv7l-musl, bootstrap: x86_64-musl, test: 0 }
           - { arch: aarch64-musl, bootstrap: x86_64-musl, test: 0 }
 
     steps:

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
  2022-07-27 23:22 [PR PATCH] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix classabbyamp
@ 2022-07-28 16:34 ` classabbyamp
  2022-07-30 13:35 ` Chocimier
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-07-28 16:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages ci/enable-all-archs
https://github.com/void-linux/void-packages/pull/38322

[RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (but it's a trivial change)

This has been how it's done since at least the switch to github CI (#26095), and how it was done in the travis CI era:

https://github.com/void-linux/void-packages/blob/71a25f3e735c1fef4178422b1a2bb70ec8e84e02/.travis.yml#L15-L21

Should it be changed? Is there a reason why CI isn't currently run on armv6l and armv7l-musl?


A patch file from https://github.com/void-linux/void-packages/pull/38322.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ci/enable-all-archs-38322.patch --]
[-- Type: text/x-diff, Size: 1159 bytes --]

From cd3040f7617fe19ed9effbb7a1062c9ffd8eddf0 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 27 Jul 2022 19:16:22 -0400
Subject: [PATCH] .github/workflows/build.yaml: add armv6l, armv7l-musl to
 build matrix

---
 .github/workflows/build.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index bb05364b5e74..8931e6cf53f5 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -58,9 +58,11 @@ jobs:
           - { arch: i686, bootstrap: i686, test: 1 }
           - { arch: aarch64, bootstrap: x86_64, test: 0 }
           - { arch: armv7l, bootstrap: x86_64, test: 0 }
+          - { arch: armv6l, bootstrap: x86_64, test: 0 }
           - { arch: x86_64-musl, bootstrap: x86_64-musl, test: 1 }
-          - { arch: armv6l-musl, bootstrap: x86_64-musl, test: 0 }
           - { arch: aarch64-musl, bootstrap: x86_64-musl, test: 0 }
+          - { arch: armv7l-musl, bootstrap: x86_64-musl, test: 0 }
+          - { arch: armv6l-musl, bootstrap: x86_64-musl, test: 0 }
 
     steps:
       - name: Prepare container

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
  2022-07-27 23:22 [PR PATCH] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix classabbyamp
  2022-07-28 16:34 ` [PR PATCH] [Updated] " classabbyamp
@ 2022-07-30 13:35 ` Chocimier
  2022-07-31  7:25 ` classabbyamp
  2022-07-31  7:25 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: Chocimier @ 2022-07-30 13:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/38322#issuecomment-1200159163

Comment:
I think this won't catch any new problems, at cost of lowering throughput of CI.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
  2022-07-27 23:22 [PR PATCH] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix classabbyamp
  2022-07-28 16:34 ` [PR PATCH] [Updated] " classabbyamp
  2022-07-30 13:35 ` Chocimier
@ 2022-07-31  7:25 ` classabbyamp
  2022-07-31  7:25 ` [PR PATCH] [Closed]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-07-31  7:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38322#issuecomment-1200366694

Comment:
reasonable enough.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
  2022-07-27 23:22 [PR PATCH] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix classabbyamp
                   ` (2 preceding siblings ...)
  2022-07-31  7:25 ` classabbyamp
@ 2022-07-31  7:25 ` classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2022-07-31  7:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

There's a closed pull request on the void-packages repository

[RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix
https://github.com/void-linux/void-packages/pull/38322

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (but it's a trivial change)

This has been how it's done since at least the switch to github CI (#26095), and how it was done in the travis CI era:

https://github.com/void-linux/void-packages/blob/71a25f3e735c1fef4178422b1a2bb70ec8e84e02/.travis.yml#L15-L21

Should it be changed? Is there a reason why CI isn't currently run on armv6l and armv7l-musl?


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-07-31  7:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-27 23:22 [PR PATCH] [RFC] .github/workflows/build.yaml: add armv6l, armv7l-musl to build matrix classabbyamp
2022-07-28 16:34 ` [PR PATCH] [Updated] " classabbyamp
2022-07-30 13:35 ` Chocimier
2022-07-31  7:25 ` classabbyamp
2022-07-31  7:25 ` [PR PATCH] [Closed]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).