From 420a8ca9137fa8e3a3cadb757d0d03b0b03e670a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20W=C3=B3jcik?= <chocimier@tlen.pl>
Date: Mon, 8 Aug 2022 20:11:02 +0200
Subject: [PATCH] xbps-src: explicitly disallow pattern on build deps

It is not possible to use version other than currently in template.

Specifying pattern breaks build if dependency isn't in binary repo
already. That it worked when in repo was a coincidence.
---
 common/xbps-src/shutils/build_dependencies.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index e4e2210d4e56..bc6934fbda1f 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -160,6 +160,8 @@ install_pkg_deps() {
             if [ -f $XBPS_SRCPKGDIR/$f/template ]; then
                 templates+=" $f"
                 continue
+            elif [ "${f/>/}" != "${f}" ] || [ "${f/</}" != "${f}" ]; then
+                msg_error "$pkgver: version pattern in host dependency '$f' is invalid, template version is used always\n"
             fi
             local _repourl=$($XBPS_QUERY_CMD -R -prepository "$f" 2>/dev/null)
             if [ "$_repourl" ]; then
@@ -210,6 +212,8 @@ install_pkg_deps() {
             if [ -f $XBPS_SRCPKGDIR/$f/template ]; then
                 templates+=" $f"
                 continue
+            elif [ "${f/>/}" != "${f}" ] || [ "${f/</}" != "${f}" ]; then
+                msg_error "$pkgver: version pattern in check dependency '$f' is invalid, template version is used always\n"
             fi
             local _repourl=$($XBPS_QUERY_CMD -R -prepository "$f" 2>/dev/null)
             if [ "$_repourl" ]; then
@@ -260,6 +264,8 @@ install_pkg_deps() {
             if [ -f $XBPS_SRCPKGDIR/$f/template ]; then
                 templates+=" $f"
                 continue
+            elif [ "${f/>/}" != "${f}" ] || [ "${f/</}" != "${f}" ]; then
+                msg_error "$pkgver: version pattern in build dependency '$f' is invalid, template version is used always\n"
             fi
             local _repourl=$($XBPS_QUERY_XCMD -R -prepository "$f" 2>/dev/null)
             if [ "$_repourl" ]; then