Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dragon: improve description
@ 2022-08-17 21:30 UltimateNyn
  2022-08-17 23:36 ` paper42
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: UltimateNyn @ 2022-08-17 21:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

There is a new pull request by UltimateNyn against master on the void-packages repository

https://github.com/UltimateNyn/void-packages master
https://github.com/void-linux/void-packages/pull/38747

dragon: improve description
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


#### Why
- The description is misleading as the package also works under Wayland since it's build on top of GTK3. I confirmed that it's working under ``sway-1.7_1``

A patch file from https://github.com/void-linux/void-packages/pull/38747.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-38747.patch --]
[-- Type: text/x-diff, Size: 795 bytes --]

From d3b41cc9d899fb1629503ef7472a5dc87f91406b Mon Sep 17 00:00:00 2001
From: Donald4444 <ichquick3@gmail.com>
Date: Wed, 17 Aug 2022 23:22:35 +0200
Subject: [PATCH] dragon: improve description

---
 srcpkgs/dragon/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/dragon/template b/srcpkgs/dragon/template
index 6e19adab1dc9..b183e365c1d0 100644
--- a/srcpkgs/dragon/template
+++ b/srcpkgs/dragon/template
@@ -5,7 +5,7 @@ revision=1
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="gtk+3-devel"
-short_desc="Simple drag-and-drop source/sink for X"
+short_desc="Simple drag-and-drop source/sink for X and Wayland"
 maintainer="Daniel Lewan <vision360.daniel@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/mwh/dragon"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: dragon: improve description
  2022-08-17 21:30 [PR PATCH] dragon: improve description UltimateNyn
@ 2022-08-17 23:36 ` paper42
  2022-08-18  0:35 ` [PR PATCH] [Updated] " UltimateNyn
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-08-17 23:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/38747#issuecomment-1218660008

Comment:
Increase $revision, otherwise the package won't be built

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] dragon: improve description
  2022-08-17 21:30 [PR PATCH] dragon: improve description UltimateNyn
  2022-08-17 23:36 ` paper42
@ 2022-08-18  0:35 ` UltimateNyn
  2022-08-18  0:37 ` UltimateNyn
  2022-08-18 21:35 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: UltimateNyn @ 2022-08-18  0:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

There is an updated pull request by UltimateNyn against master on the void-packages repository

https://github.com/UltimateNyn/void-packages master
https://github.com/void-linux/void-packages/pull/38747

dragon: improve description
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


#### Why
- The description is misleading as the package also works under Wayland since it's build on top of GTK3. I confirmed that it's working under ``sway-1.7_1``

A patch file from https://github.com/void-linux/void-packages/pull/38747.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-38747.patch --]
[-- Type: text/x-diff, Size: 875 bytes --]

From 66001abc29c967c3184d79574c4080bfa4d6aff3 Mon Sep 17 00:00:00 2001
From: Donald4444 <ichquick3@gmail.com>
Date: Wed, 17 Aug 2022 23:22:35 +0200
Subject: [PATCH] dragon: improve description

---
 srcpkgs/dragon/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/dragon/template b/srcpkgs/dragon/template
index 6e19adab1dc9..a7c6be9f9d95 100644
--- a/srcpkgs/dragon/template
+++ b/srcpkgs/dragon/template
@@ -1,11 +1,11 @@
 # Template file for 'dragon'
 pkgname=dragon
 version=1.2.0
-revision=1
+revision=2
 build_style=gnu-makefile
 hostmakedepends="pkg-config"
 makedepends="gtk+3-devel"
-short_desc="Simple drag-and-drop source/sink for X"
+short_desc="Simple drag-and-drop source/sink for X and Wayland"
 maintainer="Daniel Lewan <vision360.daniel@gmail.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/mwh/dragon"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: dragon: improve description
  2022-08-17 21:30 [PR PATCH] dragon: improve description UltimateNyn
  2022-08-17 23:36 ` paper42
  2022-08-18  0:35 ` [PR PATCH] [Updated] " UltimateNyn
@ 2022-08-18  0:37 ` UltimateNyn
  2022-08-18 21:35 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: UltimateNyn @ 2022-08-18  0:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by UltimateNyn on void-packages repository

https://github.com/void-linux/void-packages/pull/38747#issuecomment-1218777503

Comment:
@paper42 fixed it. I force pushed it so it's only 1 commit to don't clutter the git history with unnecessary commits

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: dragon: improve description
  2022-08-17 21:30 [PR PATCH] dragon: improve description UltimateNyn
                   ` (2 preceding siblings ...)
  2022-08-18  0:37 ` UltimateNyn
@ 2022-08-18 21:35 ` paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-08-18 21:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There's a merged pull request on the void-packages repository

dragon: improve description
https://github.com/void-linux/void-packages/pull/38747

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture (x86_64-musl)


#### Why
- The description is misleading as the package also works under Wayland since it's build on top of GTK3. I confirmed that it's working under ``sway-1.7_1``

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-08-18 21:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-17 21:30 [PR PATCH] dragon: improve description UltimateNyn
2022-08-17 23:36 ` paper42
2022-08-18  0:35 ` [PR PATCH] [Updated] " UltimateNyn
2022-08-18  0:37 ` UltimateNyn
2022-08-18 21:35 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).