[PR PATCH] iwgtk: update to 0.8, adopt

[PR PATCH] iwgtk: update to 0.8, adopt

[subnut]

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

There is a new pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages iwgtk
https://github.com/void-linux/void-packages/pull/38752

iwgtk: update to 0.8, adopt
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iwgtk-38752.patch --]
[-- Type: text/x-diff, Size: 2691 bytes --]

From ef7a975c1397b59d711a8d2fba171a741e3549f6 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Thu, 18 Aug 2022 08:59:30 +0530
Subject: [PATCH] iwgtk: update to 0.8, adopt

---
 srcpkgs/iwgtk/patches/fix-makefile.patch | 29 ------------------------
 srcpkgs/iwgtk/template                   | 22 +++++++++++-------
 2 files changed, 14 insertions(+), 37 deletions(-)
 delete mode 100644 srcpkgs/iwgtk/patches/fix-makefile.patch

diff --git a/srcpkgs/iwgtk/patches/fix-makefile.patch b/srcpkgs/iwgtk/patches/fix-makefile.patch
deleted file mode 100644
index bd81d95b5908..000000000000
--- a/srcpkgs/iwgtk/patches/fix-makefile.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-https://patch-diff.githubusercontent.com/raw/J-Lentz/iwgtk/pull/14.patch
-
---- a/Makefile
-+++ b/Makefile
-@@ -1,8 +1,8 @@
--CC=gcc
--CFLAGS=`pkg-config --cflags gtk+-3.0`
-+CC?=gcc
-+CCINCS=`pkg-config --cflags gtk+-3.0`
- LDLIBS=`pkg-config --libs gtk+-3.0`
- 
--prefix=/usr/local
-+prefix?=$(PREFIX)
- exec_prefix=$(prefix)
- bindir=$(exec_prefix)/bin
- datarootdir=$(prefix)/share
-@@ -23,10 +23,10 @@
- .PHONY : clean install uninstall
- 
- iwgtk : $(objects)
--	$(CC) $(CFLAGS) -o $@ $^ $(LDLIBS)
-+	$(CC) $(CCINCS) $(CFLAGS) -o $@ $^ $(LDLIBS)
- 
- %.o : $(srcdir)/%.c $(headers)
--	$(CC) -c $(CFLAGS) -o $@ $<
-+	$(CC) -c $(CCINCS) $(CFLAGS) -o $@ $<
- 
- $(srcdir)/icons.c : icons.gresource.xml $(icons)
- 	glib-compile-resources --target=$@ --sourcedir=icons --generate-source $<
diff --git a/srcpkgs/iwgtk/template b/srcpkgs/iwgtk/template
index a9b23b80f0ca..9c7e5d71cca6 100644
--- a/srcpkgs/iwgtk/template
+++ b/srcpkgs/iwgtk/template
@@ -1,14 +1,20 @@
 # Template file for 'iwgtk'
 pkgname=iwgtk
-version=0.4
+version=0.8
 revision=1
-build_style=gnu-makefile
-hostmakedepends="glib-devel pkg-config"
-makedepends="gtk+3-devel"
+build_style=meson
+hostmakedepends="scdoc pkg-config gettext"
+makedepends="gtk4-devel qrencode-devel"
 depends="iwd"
-short_desc="GUI WiFi management utility to control iwd"
-maintainer="caughtquick <me@caughtquick.tech>"
+short_desc="Lightweight GTK frontend for iwd (WiFi)"
+maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="GPL-3.0-or-later"
-homepage="https://github.com/J-Lentz/iwgtk/"
+homepage="https://github.com/J-Lentz/iwgtk"
+changelog="https://raw.githubusercontent.com/J-Lentz/iwgtk/master/CHANGELOG"
 distfiles="https://github.com/J-Lentz/iwgtk/archive/refs/tags/v${version}.tar.gz"
-checksum=71bb85546a55bf710052d4947f6be5f5a01033d04d2d14a85a7e734dd570657d
+checksum=38e81e67004bbd246b6551ffc812b6ab019f84a7329f134bb8031eb61d9d732c
+
+post_install() {
+	# Remove systemd files
+	rm -rf "${DESTDIR}/usr/share/lib/systemd"
+}

Re: iwgtk: update to 0.8, adopt

[subnut]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by subnut on void-packages repository

https://github.com/void-linux/void-packages/pull/38752#issuecomment-1219004375

Comment:
@abenson Is it okay if I adopt this package?

Re: iwgtk: update to 0.8, adopt

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38752#issuecomment-1219010995

Comment:
the maintainer is actually @caughtquick

Re: iwgtk: update to 0.8, adopt

[caughtquick]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by caughtquick on void-packages repository

https://github.com/void-linux/void-packages/pull/38752#issuecomment-1219011437

Comment:
@classabbyamp thanks for the ping @subnut feel free to adopt this package, I don't use void anymore

Re: [PR REVIEW] iwgtk: update to 0.8, adopt

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/38752#discussion_r948625780

Comment:
https://github.com/void-linux/void-packages/blob/master/Manual.md#writing-runit-services

> If the package installs a systemd service file or other unit, leave it in place as a reference point so long as including it has no negative side effects.
> 
> Examples of when not to install systemd units:
> 
> 1. When doing so changes runtime behavior of the packaged software.
> 2. When it is done via a compile time flag that also changes build dependencies.

Re: [PR PATCH] [Updated] iwgtk: update to 0.8, adopt

[subnut]

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There is an updated pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages iwgtk
https://github.com/void-linux/void-packages/pull/38752

iwgtk: update to 0.8, adopt
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/38752.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-iwgtk-38752.patch --]
[-- Type: text/x-diff, Size: 2594 bytes --]

From 4c295a6351a72834f190222fa853e5dbc31855ae Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Thu, 18 Aug 2022 08:59:30 +0530
Subject: [PATCH] iwgtk: update to 0.8, adopt

---
 srcpkgs/iwgtk/patches/fix-makefile.patch | 29 ------------------------
 srcpkgs/iwgtk/template                   | 17 +++++++-------
 2 files changed, 9 insertions(+), 37 deletions(-)
 delete mode 100644 srcpkgs/iwgtk/patches/fix-makefile.patch

diff --git a/srcpkgs/iwgtk/patches/fix-makefile.patch b/srcpkgs/iwgtk/patches/fix-makefile.patch
deleted file mode 100644
index bd81d95b5908..000000000000
--- a/srcpkgs/iwgtk/patches/fix-makefile.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-https://patch-diff.githubusercontent.com/raw/J-Lentz/iwgtk/pull/14.patch
-
---- a/Makefile
-+++ b/Makefile
-@@ -1,8 +1,8 @@
--CC=gcc
--CFLAGS=`pkg-config --cflags gtk+-3.0`
-+CC?=gcc
-+CCINCS=`pkg-config --cflags gtk+-3.0`
- LDLIBS=`pkg-config --libs gtk+-3.0`
- 
--prefix=/usr/local
-+prefix?=$(PREFIX)
- exec_prefix=$(prefix)
- bindir=$(exec_prefix)/bin
- datarootdir=$(prefix)/share
-@@ -23,10 +23,10 @@
- .PHONY : clean install uninstall
- 
- iwgtk : $(objects)
--	$(CC) $(CFLAGS) -o $@ $^ $(LDLIBS)
-+	$(CC) $(CCINCS) $(CFLAGS) -o $@ $^ $(LDLIBS)
- 
- %.o : $(srcdir)/%.c $(headers)
--	$(CC) -c $(CFLAGS) -o $@ $<
-+	$(CC) -c $(CCINCS) $(CFLAGS) -o $@ $<
- 
- $(srcdir)/icons.c : icons.gresource.xml $(icons)
- 	glib-compile-resources --target=$@ --sourcedir=icons --generate-source $<
diff --git a/srcpkgs/iwgtk/template b/srcpkgs/iwgtk/template
index a9b23b80f0ca..7a0a9e2bbde1 100644
--- a/srcpkgs/iwgtk/template
+++ b/srcpkgs/iwgtk/template
@@ -1,14 +1,15 @@
 # Template file for 'iwgtk'
 pkgname=iwgtk
-version=0.4
+version=0.8
 revision=1
-build_style=gnu-makefile
-hostmakedepends="glib-devel pkg-config"
-makedepends="gtk+3-devel"
+build_style=meson
+hostmakedepends="scdoc pkg-config gettext"
+makedepends="gtk4-devel qrencode-devel"
 depends="iwd"
-short_desc="GUI WiFi management utility to control iwd"
-maintainer="caughtquick <me@caughtquick.tech>"
+short_desc="Lightweight GTK frontend for iwd (WiFi)"
+maintainer="Subhaditya Nath <sn03.general@gmail.com>"
 license="GPL-3.0-or-later"
-homepage="https://github.com/J-Lentz/iwgtk/"
+homepage="https://github.com/J-Lentz/iwgtk"
+changelog="https://raw.githubusercontent.com/J-Lentz/iwgtk/master/CHANGELOG"
 distfiles="https://github.com/J-Lentz/iwgtk/archive/refs/tags/v${version}.tar.gz"
-checksum=71bb85546a55bf710052d4947f6be5f5a01033d04d2d14a85a7e734dd570657d
+checksum=38e81e67004bbd246b6551ffc812b6ab019f84a7329f134bb8031eb61d9d732c

Re: [PR PATCH] [Merged]: iwgtk: update to 0.8, adopt

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

There's a merged pull request on the void-packages repository

iwgtk: update to 0.8, adopt
https://github.com/void-linux/void-packages/pull/38752

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!--
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->