* [PR PATCH] spotify-tui: fix build with recent rust
@ 2022-08-20 15:38 paper42
2022-08-20 16:16 ` paper42
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: paper42 @ 2022-08-20 15:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1379 bytes --]
There is a new pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages spotify-fix-rust
https://github.com/void-linux/void-packages/pull/38796
spotify-tui: fix build with recent rust
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO** only compile tested
@abenson I don't use spotify, but this seems to fix compilation issues with recent rust versions
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38796.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-fix-rust-38796.patch --]
[-- Type: text/x-diff, Size: 1651 bytes --]
From 55babb8f349814230663098d27d8325835af1b06 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 20 Aug 2022 17:17:40 +0200
Subject: [PATCH 1/2] spotify-tui: fix build with recent rust
---
srcpkgs/spotify-tui/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/spotify-tui/template b/srcpkgs/spotify-tui/template
index 8f94ee843c6f..3db1d2af43bf 100644
--- a/srcpkgs/spotify-tui/template
+++ b/srcpkgs/spotify-tui/template
@@ -13,7 +13,10 @@ distfiles="https://github.com/Rigellute/spotify-tui/archive/v${version}.tar.gz"
checksum=9d6fa998e625ceff958a5355b4379ab164ba76575143a7b6d5d8aeb6c36d70a7
pre_build() {
- cargo update --package openssl-sys --precise 0.9.58
+ # fix various compilation issues
+ cargo update --package num-traits:0.2.12 --precise 0.2.15
+ cargo update --package num-integer:0.1.43 --precise 0.1.45
+ cargo update --package autocfg:1.0.0 --precise 1.1.0
}
post_install() {
From d7808bcb30064fde248dcb90523a9af95e98fcc9 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 20 Aug 2022 17:24:14 +0200
Subject: [PATCH 2/2] spotifyd: fix build with recent rust
---
srcpkgs/spotifyd/template | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/srcpkgs/spotifyd/template b/srcpkgs/spotifyd/template
index 6c16a1b12a29..f8525c981f01 100644
--- a/srcpkgs/spotifyd/template
+++ b/srcpkgs/spotifyd/template
@@ -29,3 +29,7 @@ _features+="$(vopt_if portaudio ',portaudio_backend')"
if [ "$_features" ]; then
configure_args+=" --features $_features"
fi
+
+pre_build() {
+ cargo update --package priority-queue:1.1.1 --precise 1.2.3
+}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: spotify-tui: fix build with recent rust
2022-08-20 15:38 [PR PATCH] spotify-tui: fix build with recent rust paper42
@ 2022-08-20 16:16 ` paper42
2022-08-20 16:54 ` [PR PATCH] [Updated] " paper42
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-08-20 16:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38796#issuecomment-1221358313
Comment:
hmm, I am not sure why this fixed spotifyd for me before, but CI and I are still getting the same issue
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] spotify-tui: fix build with recent rust
2022-08-20 15:38 [PR PATCH] spotify-tui: fix build with recent rust paper42
2022-08-20 16:16 ` paper42
@ 2022-08-20 16:54 ` paper42
2022-08-20 16:54 ` paper42
2022-08-23 21:12 ` [PR PATCH] [Closed]: " abenson
3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-08-20 16:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages spotify-fix-rust
https://github.com/void-linux/void-packages/pull/38796
spotify-tui: fix build with recent rust
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO** only compile tested
@abenson I don't use spotify, but this seems to fix compilation issues with recent rust versions
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/38796.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-fix-rust-38796.patch --]
[-- Type: text/x-diff, Size: 963 bytes --]
From c7245dc1d358757b6ada7de9f6a5a106487ba32b Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sat, 20 Aug 2022 17:17:40 +0200
Subject: [PATCH] spotify-tui: fix build with recent rust
---
srcpkgs/spotify-tui/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/spotify-tui/template b/srcpkgs/spotify-tui/template
index 8f94ee843c6f..3db1d2af43bf 100644
--- a/srcpkgs/spotify-tui/template
+++ b/srcpkgs/spotify-tui/template
@@ -13,7 +13,10 @@ distfiles="https://github.com/Rigellute/spotify-tui/archive/v${version}.tar.gz"
checksum=9d6fa998e625ceff958a5355b4379ab164ba76575143a7b6d5d8aeb6c36d70a7
pre_build() {
- cargo update --package openssl-sys --precise 0.9.58
+ # fix various compilation issues
+ cargo update --package num-traits:0.2.12 --precise 0.2.15
+ cargo update --package num-integer:0.1.43 --precise 0.1.45
+ cargo update --package autocfg:1.0.0 --precise 1.1.0
}
post_install() {
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: spotify-tui: fix build with recent rust
2022-08-20 15:38 [PR PATCH] spotify-tui: fix build with recent rust paper42
2022-08-20 16:16 ` paper42
2022-08-20 16:54 ` [PR PATCH] [Updated] " paper42
@ 2022-08-20 16:54 ` paper42
2022-08-23 21:12 ` [PR PATCH] [Closed]: " abenson
3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-08-20 16:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/38796#issuecomment-1221366226
Comment:
I dropped the spotifyd commit from this branch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Closed]: spotify-tui: fix build with recent rust
2022-08-20 15:38 [PR PATCH] spotify-tui: fix build with recent rust paper42
` (2 preceding siblings ...)
2022-08-20 16:54 ` paper42
@ 2022-08-23 21:12 ` abenson
3 siblings, 0 replies; 5+ messages in thread
From: abenson @ 2022-08-23 21:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
There's a closed pull request on the void-packages repository
spotify-tui: fix build with recent rust
https://github.com/void-linux/void-packages/pull/38796
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **NO** only compile tested
@abenson I don't use spotify, but this seems to fix compilation issues with recent rust versions
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-23 21:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-20 15:38 [PR PATCH] spotify-tui: fix build with recent rust paper42
2022-08-20 16:16 ` paper42
2022-08-20 16:54 ` [PR PATCH] [Updated] " paper42
2022-08-20 16:54 ` paper42
2022-08-23 21:12 ` [PR PATCH] [Closed]: " abenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).